<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/lib/api, branch test-improve-gitlab-identifier</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Merge branch 'rc-improve-members-destroy-service' into 'master'</title>
<updated>2016-10-04T10:50:21+00:00</updated>
<author>
<name>Robert Speicher</name>
<email>robert@gitlab.com</email>
</author>
<published>2016-10-04T10:50:21+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=ef24c62593dd7ca8bae7fd0150f394b741f9d246'/>
<id>ef24c62593dd7ca8bae7fd0150f394b741f9d246</id>
<content type='text'>

Improve `Members::DestroyService`

Part of #21979.

See merge request !6267</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Improve `Members::DestroyService`

Part of #21979.

See merge request !6267</pre>
</div>
</content>
</entry>
<entry>
<title>GrapeDSL for Namespace endpoint</title>
<updated>2016-10-04T05:47:29+00:00</updated>
<author>
<name>Z.J. van de Weg</name>
<email>zegerjan@gitlab.com</email>
</author>
<published>2016-09-13T18:55:26+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d6e42e0ca1ab9962b7d43517c6f6beab5f1ade1c'/>
<id>d6e42e0ca1ab9962b7d43517c6f6beab5f1ade1c</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove useless code now that Member#add_user handles it</title>
<updated>2016-10-03T16:43:33+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2016-10-03T16:43:33+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=1592d57c18ba905d7bd1643ab6af56c902d709c1'/>
<id>1592d57c18ba905d7bd1643ab6af56c902d709c1</id>
<content type='text'>
Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix a few things after the initial improvment to Members::DestroyService</title>
<updated>2016-10-03T14:57:48+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2016-09-09T16:51:31+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=c8b1311934935c7ac7fd901558e19ac496fbad2c'/>
<id>c8b1311934935c7ac7fd901558e19ac496fbad2c</id>
<content type='text'>
Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Improve Members::DestroyService</title>
<updated>2016-10-03T14:57:48+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2016-07-28T17:31:17+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=3158f57dba6dcef3e586ae8fced7deb6fdbd6dc0'/>
<id>3158f57dba6dcef3e586ae8fced7deb6fdbd6dc0</id>
<content type='text'>
Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'zj-grape-award-emoji' into 'master'</title>
<updated>2016-10-03T12:13:39+00:00</updated>
<author>
<name>Robert Speicher</name>
<email>robert@gitlab.com</email>
</author>
<published>2016-10-03T12:13:39+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=dfb9cab828a11cf00522734d11c2472e8b540b5c'/>
<id>dfb9cab828a11cf00522734d11c2472e8b540b5c</id>
<content type='text'>

GrapeDSL for Award Emoji endpoints

Cherry-picked from !6330

See merge request !6629</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

GrapeDSL for Award Emoji endpoints

Cherry-picked from !6330

See merge request !6629</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'zj-grape-keys' into 'master'</title>
<updated>2016-10-03T10:57:52+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2016-10-03T10:57:52+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=5bc1e93c19a9082e6f572f293c9c389c36573523'/>
<id>5bc1e93c19a9082e6f572f293c9c389c36573523</id>
<content type='text'>

GrapeDSL for Keys endpoint

No changelog item as it doesn't change behaviour
Cherry-picket from !6330

See merge request !6631</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

GrapeDSL for Keys endpoint

No changelog item as it doesn't change behaviour
Cherry-picket from !6330

See merge request !6631</pre>
</div>
</content>
</entry>
<entry>
<title>GrapeDSL for Award Emoji endpoints</title>
<updated>2016-10-03T08:32:09+00:00</updated>
<author>
<name>Z.J. van de Weg</name>
<email>zegerjan@gitlab.com</email>
</author>
<published>2016-08-12T07:27:52+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d291ea97e0e944610c36469757a10b342ab0e05c'/>
<id>d291ea97e0e944610c36469757a10b342ab0e05c</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch '21983-member-add_user-doesn-t-detect-existing-members-that-have-requested-access' into 'master'</title>
<updated>2016-10-02T11:42:57+00:00</updated>
<author>
<name>Robert Speicher</name>
<email>robert@gitlab.com</email>
</author>
<published>2016-10-02T11:42:57+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=e64594ac4419a42b84f3ee36388f832e74361c8c'/>
<id>e64594ac4419a42b84f3ee36388f832e74361c8c</id>
<content type='text'>

Resolve "`Member.add_user`doesn't detect existing members that have requested access"

## What does this MR do?

This merge request handle the case when an access requester is added to a group or project (via the members page or the API).

In `Member.add_user`, if an access requester already exists, we simply accept their request (and set the `created_by`, `access_level` and `expires_at` attributes if given).

## Are there points in the code the reviewer needs to double check?

I've taken the opportunity to cleanup the whole `{Group,Project}Member.add_user*` methods since it was quite a mess.

## What are the relevant issue numbers?

Closes #21983

See merge request !6393</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Resolve "`Member.add_user`doesn't detect existing members that have requested access"

## What does this MR do?

This merge request handle the case when an access requester is added to a group or project (via the members page or the API).

In `Member.add_user`, if an access requester already exists, we simply accept their request (and set the `created_by`, `access_level` and `expires_at` attributes if given).

## Are there points in the code the reviewer needs to double check?

I've taken the opportunity to cleanup the whole `{Group,Project}Member.add_user*` methods since it was quite a mess.

## What are the relevant issue numbers?

Closes #21983

See merge request !6393</pre>
</div>
</content>
</entry>
<entry>
<title>GrapeDSL for Keys endpoint</title>
<updated>2016-10-01T09:11:41+00:00</updated>
<author>
<name>Z.J. van de Weg</name>
<email>zegerjan@gitlab.com</email>
</author>
<published>2016-09-13T18:55:00+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=dd088d14bb51e9c0baee013b9d3b21a12a768051'/>
<id>dd088d14bb51e9c0baee013b9d3b21a12a768051</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
