delta/gitlab/gitlab-ce.git/lib/api/todos.rb, branch app-differences gitlab.com: gitlab-org/gitlab-ce.git Merge branch 'security-59581-related-merge-requests-count' into 'master' 2019-07-02T06:19:58+00:00 Marin Jankovski marin@gitlab.com 2019-07-02T06:19:58+00:00 f66169b35c29294ecc9f63eeeedc52085d2a3fd7 Expose merge requests count based on user access See merge request gitlab/gitlabhq!3157 
Expose merge requests count based on user access

See merge request gitlab/gitlabhq!3157
 Rename Todos.with_api_entity_associations to with_entity_associations 2019-06-24T17:49:13+00:00 Stan Hu stanhu@gmail.com 2019-06-24T17:48:50+00:00 f2d932268d1b30929e45d7503ef90b325a85e314 Since this scope is used in both the controller and the API, we rename it to make it clear that it's used for both. 
Since this scope is used in both the controller and the API, we rename
it to make it clear that it's used for both.
Expose merge requests count based on user access 2019-06-18T09:46:46+00:00 Alexandru Croitor acroitor@gitlab.com 2019-06-12T16:28:25+00:00 09163e423ac50c8eda82f67e5419142893faf18a Count issues related merge requests based on user access level. And issue can have related MRs from projects where user does not have access so the number of related merge requests should be adjusted based on user's ability to access the related MRs. https://gitlab.com/gitlab-org/gitlab-ce/issues/59581 
Count issues related merge requests based on user access level. And
issue can have related MRs from projects where user does not have
access so the number of related merge requests should be adjusted
based on user's ability to access the related MRs.

https://gitlab.com/gitlab-org/gitlab-ce/issues/59581
Significantly reduce N+1 queries in /api/v4/todos endpoint 2019-03-06T15:03:46+00:00 Stan Hu stanhu@gmail.com 2019-03-02T17:31:36+00:00 062efe4f7a83fb2b6d951b314692cca9ee8731cd By preloading associations and batching issuable metadata lookups, we can significantly cut the number of SQL queries needed to load the Todos API endpoint. On GitLab.com, my own tests showed my user's SQL queries went from 365 to under 60 SQL queries. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/40378 
By preloading associations and batching issuable metadata lookups,
we can significantly cut the number of SQL queries needed to load
the Todos API endpoint.

On GitLab.com, my own tests showed my user's SQL queries went
from 365 to under 60 SQL queries.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/40378
Enable the Layout/ExtraSpacing cop 2019-01-24T12:05:45+00:00 Rémy Coutable remy@rymai.me 2019-01-16T12:09:29+00:00 3a2abc1d50b419a353edb7f7cf68f3894dfdeeef Signed-off-by: Rémy Coutable <remy@rymai.me> 
Signed-off-by: Rémy Coutable <remy@rymai.me>
Fix API::Namespaces to accept namepaces with dots 2018-11-28T11:54:11+00:00 Imre Farkas ifarkas@gitlab.com 2018-11-08T12:18:17+00:00 b1e070bf4957a558ac51315dd4a6277056047e8a It also renames the API::PROJECT_ENDPOINT_REQUIREMENTS constant to API::NAMESPACE_OR_PROJECT_REQUIREMENTS 
It also renames the API::PROJECT_ENDPOINT_REQUIREMENTS constant to
API::NAMESPACE_OR_PROJECT_REQUIREMENTS
Enable frozen string in lib/api and lib/backup 2018-09-30T04:04:50+00:00 gfyoung gfyoung17@gmail.com 2018-09-29T22:34:47+00:00 3836d69119fee2a625edae2a564132eff9520bc8 Partially addresses #47424. Had to make changes to spec files because stubbing methods on frozen objects is a mess in RSpec and leads to failures: https://github.com/rspec/rspec-mocks/issues/1190 
Partially addresses #47424.

Had to make changes to spec files because
stubbing methods on frozen objects is a mess
in RSpec and leads to failures:

https://github.com/rspec/rspec-mocks/issues/1190
Merge branch 'security-10-4-todo-api-reveals-sensitive-information' into 'security-10-4' 2018-02-09T18:16:25+00:00 Robert Speicher robert@gitlab.com 2018-01-18T23:10:19+00:00 fec9fb05a5775b864ef6768df166d39fcb2be4bc Restrict Todo API mark_as_done endpoint to the user's todos only 
Restrict Todo API mark_as_done endpoint to the user's todos only
API: Use defined project requirements 2017-08-31T12:57:47+00:00 Robert Schilling rschilling@student.tugraz.at 2017-08-31T11:44:49+00:00 6a2ee0968e811d31fb4cc23b30a6b42e42adf47b 






Avoid plucking Todo ids and use sub-queries instead
2017-08-03T14:31:05+00:00

Toon Claes
toon@gitlab.com

2017-04-21T09:36:34+00:00

a723cba57493ec3220596ca8543a8b1b1ec118fe

TodoService should not call `.select(&:id)` on todos, because this is
bad performance. So instead use sub-queries, which will result in a
single SQL query to the database.

https://docs.gitlab.com/ee/development/sql.html#plucking-ids





TodoService should not call `.select(&:id)` on todos, because this is
bad performance. So instead use sub-queries, which will result in a
single SQL query to the database.

https://docs.gitlab.com/ee/development/sql.html#plucking-ids