<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/lib/api/helpers/runner.rb, branch patch-53</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Properly handle multiple X-Forwarded-For addresses in runner IP</title>
<updated>2019-02-24T22:50:55+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2019-02-24T16:45:00+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d03b7bb1e024dcbf68b523686751d3a2025ed03c'/>
<id>d03b7bb1e024dcbf68b523686751d3a2025ed03c</id>
<content type='text'>
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/24624 extracted
the X-Forwarded-For address directly, but this didn't consider the case
where multiple proxies are in the chain. To fix this, we use the Rails
implementation to filter trusted proxies, as documented by Grape:
https://github.com/ruby-grape/grape#remote-ip

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/58103
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/24624 extracted
the X-Forwarded-For address directly, but this didn't consider the case
where multiple proxies are in the chain. To fix this, we use the Rails
implementation to filter trusted proxies, as documented by Grape:
https://github.com/ruby-grape/grape#remote-ip

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/58103
</pre>
</div>
</content>
</entry>
<entry>
<title>Get remote address for runner</title>
<updated>2019-01-24T08:03:14+00:00</updated>
<author>
<name>Steve Azzopardi</name>
<email>steveazz@outlook.com</email>
</author>
<published>2019-01-24T07:55:22+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=cb67423d48f6e5e78c7ecd9196b93edf7666ba0c'/>
<id>cb67423d48f6e5e78c7ecd9196b93edf7666ba0c</id>
<content type='text'>
Check if `X-Forwarded-For` is set before getting the IP of the request,
with this the real IP address of the runner is shown if it's behind a
proxy.

closes https://gitlab.com/gitlab-org/gitlab-ce/issues/53676
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Check if `X-Forwarded-For` is set before getting the IP of the request,
with this the real IP address of the runner is shown if it's behind a
proxy.

closes https://gitlab.com/gitlab-org/gitlab-ce/issues/53676
</pre>
</div>
</content>
</entry>
<entry>
<title>Enable frozen string in lib/api and lib/backup</title>
<updated>2018-09-30T04:04:50+00:00</updated>
<author>
<name>gfyoung</name>
<email>gfyoung17@gmail.com</email>
</author>
<published>2018-09-29T22:34:47+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=3836d69119fee2a625edae2a564132eff9520bc8'/>
<id>3836d69119fee2a625edae2a564132eff9520bc8</id>
<content type='text'>
Partially addresses #47424.

Had to make changes to spec files because
stubbing methods on frozen objects is a mess
in RSpec and leads to failures:

https://github.com/rspec/rspec-mocks/issues/1190
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Partially addresses #47424.

Had to make changes to spec files because
stubbing methods on frozen objects is a mess
in RSpec and leads to failures:

https://github.com/rspec/rspec-mocks/issues/1190
</pre>
</div>
</content>
</entry>
<entry>
<title>Change update entrypoint instead of adding new keep-alive one</title>
<updated>2018-06-07T16:45:48+00:00</updated>
<author>
<name>Tomasz Maczukin</name>
<email>tomasz@maczukin.pl</email>
</author>
<published>2018-06-07T15:27:26+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=a6a900256e194c28d8342db9c2d67df784877c14'/>
<id>a6a900256e194c28d8342db9c2d67df784877c14</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Persist runner IP address on contact (#43489)</title>
<updated>2018-02-28T00:54:37+00:00</updated>
<author>
<name>Dylan Griffith</name>
<email>dyl.griffith@gmail.com</email>
</author>
<published>2018-02-22T06:03:00+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=b5a5fdf0e3b97622789db444bf0bf697e78dbb47'/>
<id>b5a5fdf0e3b97622789db444bf0bf697e78dbb47</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'master' into 38265-stuckcijobsworker-wrongly-detects-cancels-stuck-builds-when-per-job-timeout-is-more-than-an-hour</title>
<updated>2018-02-04T22:38:59+00:00</updated>
<author>
<name>Matija Čupić</name>
<email>matteeyah@gmail.com</email>
</author>
<published>2018-02-04T22:38:59+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=3366f377c1d4cbb02ecc5a2e47b059ed375c5e09'/>
<id>3366f377c1d4cbb02ecc5a2e47b059ed375c5e09</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Refactor runner attribute caching implementation</title>
<updated>2018-02-04T17:34:21+00:00</updated>
<author>
<name>Matija Čupić</name>
<email>matteeyah@gmail.com</email>
</author>
<published>2018-02-04T17:34:21+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=38c242126d10d0887ca0d3dd8565ef2669dfec46'/>
<id>38c242126d10d0887ca0d3dd8565ef2669dfec46</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>use Gitlab::UserSettings directly as a singleton instead of including/extending it</title>
<updated>2018-02-02T18:39:55+00:00</updated>
<author>
<name>Mario de la Ossa</name>
<email>mdelaossa@gitlab.com</email>
</author>
<published>2018-02-02T18:39:55+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=eaada9d7066a20b5af815f723e09cde60a5c8c10'/>
<id>eaada9d7066a20b5af815f723e09cde60a5c8c10</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Move info update implementation to Ci::Runner model</title>
<updated>2018-01-29T19:56:28+00:00</updated>
<author>
<name>Matija Čupić</name>
<email>matteeyah@gmail.com</email>
</author>
<published>2018-01-29T19:56:28+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=bdd3e39b0bd4e8fcec5d6e2d97297840211dd921'/>
<id>bdd3e39b0bd4e8fcec5d6e2d97297840211dd921</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Update runner info on all authenticated requests</title>
<updated>2018-01-29T16:21:30+00:00</updated>
<author>
<name>Matija Čupić</name>
<email>matteeyah@gmail.com</email>
</author>
<published>2018-01-29T16:21:30+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=397442a06140a8cf38bebe3f4519311b1448f23d'/>
<id>397442a06140a8cf38bebe3f4519311b1448f23d</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
