delta/gitlab/gitlab-ce.git/features/steps/project/issues, branch fix-commit-status gitlab.com: gitlab-org/gitlab-ce.git Merge branch '18334-truncate-award-emoji-users' into 'master' 2016-08-18T20:04:18+00:00 Jacob Schatz jschatz@gitlab.com 2016-08-18T20:04:18+00:00 2b487edc98186e7f46c93ef7e6d029902aa82ebe Truncated long user lists in award emoji tooltips ## What does this MR do? Truncates award emoji tooltips so that they only show 10 users maximum. Further users are indicated by appending "and X more." ## Are there points in the code the reviewer needs to double check? Is 10 too little, should it be raised? My test cases rely on join() to build the expected output. This feels a little iffy is it alright? ## Why was this MR needed? Some issues have a large number of thumbs causing tooltips to be very large. ## What are the relevant issue numbers? closes #18334, closes #19542 ## Screenshots (if relevant) ##### Before ![Screenshot_from_2016-06-20_19-49-12](/uploads/d7a14dd87bb3da2acd7c0818de99852b/Screenshot_from_2016-06-20_19-49-12.png) ##### After ![Screenshot_from_2016-06-20_19-50-58](/uploads/f7f05c44594bfe8cec7dfd48802753a6/Screenshot_from_2016-06-20_19-50-58.png) Truncation point modified for purposes of screenshot ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [x] API support added - [x] Tests - [x] Added for this feature/bug - [x] All builds are passing - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if you do - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) See merge request !4780 

Truncated long user lists in award emoji tooltips

## What does this MR do?
Truncates award emoji tooltips so that they only show 10 users maximum.

Further users are indicated by appending "and X more."

## Are there points in the code the reviewer needs to double check?
Is 10 too little, should it be raised?

My test cases rely on join() to build the expected output.
This feels a little iffy is it alright?

## Why was this MR needed?
Some issues have a large number of thumbs causing tooltips to be very large.

## What are the relevant issue numbers?
closes #18334, closes #19542

## Screenshots (if relevant)
##### Before
![Screenshot_from_2016-06-20_19-49-12](/uploads/d7a14dd87bb3da2acd7c0818de99852b/Screenshot_from_2016-06-20_19-49-12.png)

##### After
![Screenshot_from_2016-06-20_19-50-58](/uploads/f7f05c44594bfe8cec7dfd48802753a6/Screenshot_from_2016-06-20_19-50-58.png)

Truncation point modified for purposes of screenshot

## Does this MR meet the acceptance criteria?

- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [x] API support added
- [x] Tests
  - [x] Added for this feature/bug
  - [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

See merge request !4780
 Fix broken feature spec. 2016-08-18T00:05:41+00:00 Ruben Davila rdavila84@gmail.com 2016-08-18T00:05:41+00:00 de8d9328064da4295436f32043e47b2b3e051334 This older spec was failing: features/project/issues/issues.feature Looks like before we were doing an exact match for queries, that's why it was passing with this existing issue: https://gitlab.com/gitlab-org/gitlab-ce/blob/59fa031e6f7d5a1b658c370f581c4caaf4493150/features/project/issues/issues.feature#L128 Failed build: https://gitlab.com/gitlab-org/gitlab-ce/builds/3178231 
This older spec was failing: features/project/issues/issues.feature

Looks like before we were doing an exact match for queries, that's why
it was passing with this existing issue: https://gitlab.com/gitlab-org/gitlab-ce/blob/59fa031e6f7d5a1b658c370f581c4caaf4493150/features/project/issues/issues.feature#L128

Failed build: https://gitlab.com/gitlab-org/gitlab-ce/builds/3178231
Award tooltips refer to current user as "You" 2016-08-17T20:25:39+00:00 Jack Davison jack.davison@student.manchester.ac.uk 2016-07-11T18:53:07+00:00 6c1ed00afc98562e2c605aa3df313d26b3486da3 






Now waits for All issuables to load when clicked
2016-08-17T12:35:20+00:00

Luke Bennett
lukeeeebennettplus@gmail.com

2016-08-17T12:33:44+00:00

8691561016338a58e314cdaa69911523b35c6df4












Removed sleep calls introduced in !5740
2016-08-17T12:35:20+00:00

Luke Bennett
lukeeeebennettplus@gmail.com

2016-08-15T15:10:22+00:00

c0a722a223e50efeab5ed3f10523d83806a09215












Fixed filtering tests
2016-08-13T05:57:40+00:00

Phil Hughes
me@iamphill.com

2016-08-12T11:47:17+00:00

c617cbfcd66a5ded22041e06b5e68454c7145029












Updated tests
2016-08-13T05:57:40+00:00

Phil Hughes
me@iamphill.com

2016-08-11T16:48:32+00:00

f668da11cb225a9b2c2f1d3ba9d1e9fb2797d4f9












Revert "Merge branch 'gl-dropdown-issuable-form' into 'master'"
2016-07-15T23:46:29+00:00

Douwe Maan
douwe@gitlab.com

2016-07-15T23:46:29+00:00

2735e5f1c2859ad496bc4f7bd820a7be33f97527

This reverts merge request !4970




This reverts merge request !4970






Updated tests
2016-07-07T08:38:49+00:00

Phil Hughes
me@iamphill.com

2016-06-29T15:15:45+00:00

a6b4164017961add393e6cc863dc5e0c3d9c7f69












Enable Style/EmptyLines cop, remove redundant ones
2016-07-01T19:56:17+00:00

Grzegorz Bizon
grzesiek.bizon@gmail.com

2016-07-01T19:56:17+00:00

9e211091a85c20adea63b89111240350d6d8ffcb