<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/features/project/issues, branch commit-description-border</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Fix spinach tests</title>
<updated>2017-01-09T22:01:28+00:00</updated>
<author>
<name>Clement Ho</name>
<email>ClemMakesApps@gmail.com</email>
</author>
<published>2016-12-15T15:07:34+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=657ac981acdcd2b070d838e530a2620c4db8bf04'/>
<id>657ac981acdcd2b070d838e530a2620c4db8bf04</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Revert "Merge branch 'revert-bdb6f1e6' into 'master'"</title>
<updated>2016-07-20T09:48:02+00:00</updated>
<author>
<name>Phil Hughes</name>
<email>me@iamphill.com</email>
</author>
<published>2016-07-16T07:12:12+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=f0691ec7c589543f9e294bf0d9cbc9eea2c2f166'/>
<id>f0691ec7c589543f9e294bf0d9cbc9eea2c2f166</id>
<content type='text'>
This reverts merge request !5290</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This reverts merge request !5290</pre>
</div>
</content>
</entry>
<entry>
<title>Revert "Merge branch 'gl-dropdown-issuable-form' into 'master'"</title>
<updated>2016-07-15T23:46:29+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@gitlab.com</email>
</author>
<published>2016-07-15T23:46:29+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=2735e5f1c2859ad496bc4f7bd820a7be33f97527'/>
<id>2735e5f1c2859ad496bc4f7bd820a7be33f97527</id>
<content type='text'>
This reverts merge request !4970</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This reverts merge request !4970</pre>
</div>
</content>
</entry>
<entry>
<title>Updated tests</title>
<updated>2016-07-07T08:38:49+00:00</updated>
<author>
<name>Phil Hughes</name>
<email>me@iamphill.com</email>
</author>
<published>2016-06-29T15:15:45+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=a6b4164017961add393e6cc863dc5e0c3d9c7f69'/>
<id>a6b4164017961add393e6cc863dc5e0c3d9c7f69</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fixed logout tests</title>
<updated>2016-06-28T12:17:29+00:00</updated>
<author>
<name>Phil Hughes</name>
<email>me@iamphill.com</email>
</author>
<published>2016-06-27T13:31:19+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=a44988ae4abb494b1194bb575b2415ef0de68878'/>
<id>a44988ae4abb494b1194bb575b2415ef0de68878</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove prev/next buttons on issues and merge requests</title>
<updated>2016-06-06T16:01:50+00:00</updated>
<author>
<name>Alejandro Rodríguez</name>
<email>alejorro70@gmail.com</email>
</author>
<published>2016-06-06T16:01:50+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=535d11302e73fe88702f7c65effc3cd443bf56fc'/>
<id>535d11302e73fe88702f7c65effc3cd443bf56fc</id>
<content type='text'>
The buttons were rarely used and added at least 1 query each on every page load.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The buttons were rarely used and added at least 1 query each on every page load.
</pre>
</div>
</content>
</entry>
<entry>
<title>fix failing tests</title>
<updated>2016-04-14T10:16:24+00:00</updated>
<author>
<name>Arinde Eniola</name>
<email>eniolaarinde1@gmail.com</email>
</author>
<published>2016-04-14T10:16:24+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=5f53ca69ace953bf06afe478072836d083f941ca'/>
<id>5f53ca69ace953bf06afe478072836d083f941ca</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Create SSH keys for SSH clone Spinach tests</title>
<updated>2016-03-21T10:40:13+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2016-03-21T10:40:13+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=75aaf91cb1d08c4350e2881b18118faf30e1f310'/>
<id>75aaf91cb1d08c4350e2881b18118faf30e1f310</id>
<content type='text'>
These tests would check if the "This project is empty" banner would
contain SSH clone URLs. Oddly enough this should have never passed (as
far as I can tell) as SSH clone URLs in this banner are _only_ displayed
if the current user has at least 1 SSH key attached. Since the tests
never seem to create any they never should have passed, yet somehow they
did. To solve this the Spinach tests in question now ensure at least 1
SSH key is present.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
These tests would check if the "This project is empty" banner would
contain SSH clone URLs. Oddly enough this should have never passed (as
far as I can tell) as SSH clone URLs in this banner are _only_ displayed
if the current user has at least 1 SSH key attached. Since the tests
never seem to create any they never should have passed, yet somehow they
did. To solve this the Spinach tests in question now ensure at least 1
SSH key is present.
</pre>
</div>
</content>
</entry>
<entry>
<title>Improve award emoji test reliability by checking that the emoji is displayed</title>
<updated>2016-03-18T00:34:15+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2016-03-17T23:25:21+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=0901d5172429630c8d1ea6d8e91be71a2e690043'/>
<id>0901d5172429630c8d1ea6d8e91be71a2e690043</id>
<content type='text'>
before the search field is focused
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
before the search field is focused
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove redundant integration tests</title>
<updated>2016-03-07T20:33:26+00:00</updated>
<author>
<name>Robert Speicher</name>
<email>rspeicher@gmail.com</email>
</author>
<published>2016-03-07T20:24:27+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=56c4f22c80b0555d5d7cfbc7f443122a8b70072c'/>
<id>56c4f22c80b0555d5d7cfbc7f443122a8b70072c</id>
<content type='text'>
These three tests were essentially checking that adding a note to
something updated its `noteable`'s `updated_at` attribute.

This is well-tested Rails behavior and we shouldn't feel the need to
write an integration test to verify it. At most we should be ensuring
that the association definition adds the `touch: true` option, which we
now do in Note's unit test.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
These three tests were essentially checking that adding a note to
something updated its `noteable`'s `updated_at` attribute.

This is well-tested Rails behavior and we shouldn't feel the need to
write an integration test to verify it. At most we should be ensuring
that the association definition adds the `touch: true` option, which we
now do in Note's unit test.
</pre>
</div>
</content>
</entry>
</feed>
