delta/gitlab/gitlab-ce.git/doc/development/code_review.md, branch lib-differences gitlab.com: gitlab-org/gitlab-ce.git Add a section of examples 2019-07-25T14:02:10+00:00 Kerri Miller kerrizor@kerrizor.com 2019-07-25T14:02:10+00:00 cd2a503db06861595f537bee017fa84ce8f91558 We have a fairly good guide to Code Reviews, but can be improved by adding a few examples of what a good code review looks like at GitLab, specifically ones where there is a bit of back and forth, "nit-picking," etc. This would: + help set expectations of newly hired engineers around what our process looks like when it is functioning what level of scrutiny their code will be under + how we have technical conversations + show by example how after you're done crafting a solution, there can still be extra work done either tidying up code and/or managing the communication and conversations about your proposed MR 
We have a fairly good guide to Code Reviews, but can be improved
by adding a few examples of what a good code review looks like
at GitLab, specifically ones where there is a bit of back and
forth, "nit-picking," etc. This would:

+ help set expectations of newly hired engineers around what our
process looks like when it is functioning what level of scrutiny
their code will be under

+ how we have technical conversations

+ show by example how after you're done crafting a solution, there
can still be extra work done either tidying up code and/or managing
the communication and conversations about your proposed MR
Document database review process 2019-07-19T17:33:48+00:00 Toon Claes toon@gitlab.com 2019-07-19T17:33:48+00:00 34a5f77e770765f278ade00a33ef846e2e1ce3d3 See https://gitlab.com/gitlab-com/gl-infra/infrastructure/issues/6069 
See https://gitlab.com/gitlab-com/gl-infra/infrastructure/issues/6069
Update numbered lists for docs standards 2019-07-19T02:20:32+00:00 Marcel Amirault mamirault@gitlab.com 2019-07-19T02:20:32+00:00 7da80b2d36adc30964423042e956ef880a2650f9 Ensure that all numbered lists use only 1. and no other numbers. Also ensure that numbered lists use proper spacing. 
Ensure that all numbered lists use only 1. and no other numbers.
Also ensure that numbered lists use proper spacing.
Fix unordered list spacing 2019-07-18T01:15:58+00:00 Marcel Amirault mamirault@gitlab.com 2019-07-18T01:15:58+00:00 746f54787799ee5ea8595a8730d363bfd250ffab Correct the spacing of unordered markdown lists in docs, to maintain standards of documentation. 
Correct the spacing of unordered markdown lists
in docs, to maintain standards of documentation.
Rename "discussions" to "threads" in docs 2019-07-15T06:10:32+00:00 Michel Engelen michel@nomorejs.net 2019-07-15T06:10:32+00:00 24a5fe6b1497308832329ff0c1f31b309b3b0f96 






Update the installation link
2019-07-08T22:24:54+00:00

Cindy Pallares
cindy@gitlab.com

2019-07-08T22:24:54+00:00

00780264a7f8eaaf304c22aaa481e1942ced05cd

The installation link has changed from /installation/ to /install/. This
commit will update all the remaining links that are missing.





The installation link has changed from /installation/ to /install/. This
commit will update all the remaining links that are missing.







Require database reviews for migrations
2019-06-24T16:53:16+00:00

Andreas Brandl
abrandl@gitlab.com

2019-06-24T16:53:16+00:00

942b38d5af047bfcbf10f42a4e553caf8d305bc2












Use relative URLs in development docs
2019-05-27T15:13:40+00:00

Achilleas Pipinellis
axil@gitlab.com

2019-05-19T23:27:22+00:00

8ec7ecf0bc176c04e8f051fd4097f234037dcc79

This is part of https://gitlab.com/gitlab-org/gitlab-ce/issues/61945





This is part of https://gitlab.com/gitlab-org/gitlab-ce/issues/61945







Give reviewer roulette its own header in the docs
2019-04-30T09:03:53+00:00

Sean McGivern
sean@gitlab.com

2019-04-30T09:03:53+00:00

c009e23a1693ac365cdbe5024cfd7debcadc0751












Refer to guidelines on when to assign MRs close to the freeze
2019-04-16T16:44:39+00:00

Douwe Maan
douwe@selenight.nl

2019-04-16T16:44:39+00:00

95dbc34e29876b9c6f2eaecfd45f9c4ac9824ca7