<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/danger, branch test-script-watch</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Don't fail the pipeline when a colon-emoji is used</title>
<updated>2019-06-06T18:14:08+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2019-06-06T18:14:08+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=1b2de25deeab172cabd8d74ad7fc60a4db39cbe5'/>
<id>1b2de25deeab172cabd8d74ad7fc60a4db39cbe5</id>
<content type='text'>
A colon-emoji like :100: can be valid in the case where we're talking
about the GitLab feature that processes these into emojis. It's fine to
warn about those, but failing the pipeline is too restrictive.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
A colon-emoji like :100: can be valid in the case where we're talking
about the GitLab feature that processes these into emojis. It's fine to
warn about those, but failing the pipeline is too restrictive.
</pre>
</div>
</content>
</entry>
<entry>
<title>Show Test Automation Engineer for spec/feature as</title>
<updated>2019-06-06T13:11:57+00:00</updated>
<author>
<name>Lin Jen-Shin</name>
<email>godfat@godfat.org</email>
</author>
<published>2019-05-23T18:07:59+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=74399a90989e5caade1de1833a7f65cfbc070bcd'/>
<id>74399a90989e5caade1de1833a7f65cfbc070bcd</id>
<content type='text'>
reviewers.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
reviewers.
</pre>
</div>
</content>
</entry>
<entry>
<title>Use roulette for single codebase roulette</title>
<updated>2019-05-30T11:24:28+00:00</updated>
<author>
<name>Lin Jen-Shin</name>
<email>godfat@godfat.org</email>
</author>
<published>2019-05-29T15:15:09+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=ceb0636cbe600a27a9ce8e5d66c796647af3c84b'/>
<id>ceb0636cbe600a27a9ce8e5d66c796647af3c84b</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Extract roulette to its own module</title>
<updated>2019-05-30T11:24:28+00:00</updated>
<author>
<name>Lin Jen-Shin</name>
<email>godfat@godfat.org</email>
</author>
<published>2019-05-29T14:38:26+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=c90ba127bf8cdd4ccac9692b6c96fa746314cd55'/>
<id>c90ba127bf8cdd4ccac9692b6c96fa746314cd55</id>
<content type='text'>
So it's more modular and extensible
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
So it's more modular and extensible
</pre>
</div>
</content>
</entry>
<entry>
<title>Run rubocop -a on CE files</title>
<updated>2019-05-05T10:24:28+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2019-05-05T10:19:14+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=f93b2e02a56a3b1f3041119e8302d43aeafc8284'/>
<id>f93b2e02a56a3b1f3041119e8302d43aeafc8284</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix reviewer roulette when no-one is in a category</title>
<updated>2019-04-30T12:31:52+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2019-04-30T12:31:52+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=60525148e7532934913b56586ccdd4c37b74a637'/>
<id>60525148e7532934913b56586ccdd4c37b74a637</id>
<content type='text'>
This would return `people.size` before, when it should return `nil`.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This would return `people.size` before, when it should return `nil`.
</pre>
</div>
</content>
</entry>
<entry>
<title>Exclude reviewers with OOO in status</title>
<updated>2019-04-29T18:49:28+00:00</updated>
<author>
<name>Michael Kozono</name>
<email>mkozono@gmail.com</email>
</author>
<published>2019-04-26T00:23:30+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=dfc9d0b6940022b82a526e642ed89a9d5422d494'/>
<id>dfc9d0b6940022b82a526e642ed89a9d5422d494</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add Danger rule for EE/CE templates</title>
<updated>2019-04-24T12:08:33+00:00</updated>
<author>
<name>Nathan Friend</name>
<email>nathan@gitlab.com</email>
</author>
<published>2019-04-24T12:08:33+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=c3268a6af542921d67c044976a0336f66ce38832'/>
<id>c3268a6af542921d67c044976a0336f66ce38832</id>
<content type='text'>
This commit adds a rule to Danger that warns the developer when their MR
includes changes to a CE .vue file that has a counterpart in the
EE repo or vice-versa.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This commit adds a rule to Danger that warns the developer when their MR
includes changes to a CE .vue file that has a counterpart in the
EE repo or vice-versa.
</pre>
</div>
</content>
</entry>
<entry>
<title>Pick reviewers based on branch name</title>
<updated>2019-04-08T10:56:17+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2019-04-08T10:44:57+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=28531ab43666b5fdf37e0a70db3bcbf7d3f92183'/>
<id>28531ab43666b5fdf37e0a70db3bcbf7d3f92183</id>
<content type='text'>
Change reviewer roulette to always pick the same reviewers for the same
branch name. We do this by:

1. Making the branch name 'canonical' across CE and EE by stripping a
   leading 'ce-' or 'ee-' and a trailing '-ce' or '-ee'. If people are
   following our branch naming guidelines, this should give the same
   branch name in both repos.
2. Converting the branch name to a stable integer by taking the integer
   form of its MD5.
3. Passing that integer as a seed to Ruby's `Random` class, which 'may
   be used to ensure repeatable sequences of pseudo-random numbers
   between different runs of the program' (from the Ruby documentation).

The upshot is that the same branch name (in CE and EE) should always
pick the same reviewers, and those should be evenly distributed across
the set of possible reviewers due to the use of MD5.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change reviewer roulette to always pick the same reviewers for the same
branch name. We do this by:

1. Making the branch name 'canonical' across CE and EE by stripping a
   leading 'ce-' or 'ee-' and a trailing '-ce' or '-ee'. If people are
   following our branch naming guidelines, this should give the same
   branch name in both repos.
2. Converting the branch name to a stable integer by taking the integer
   form of its MD5.
3. Passing that integer as a seed to Ruby's `Random` class, which 'may
   be used to ensure repeatable sequences of pseudo-random numbers
   between different runs of the program' (from the Ruby documentation).

The upshot is that the same branch name (in CE and EE) should always
pick the same reviewers, and those should be evenly distributed across
the set of possible reviewers due to the use of MD5.
</pre>
</div>
</content>
</entry>
<entry>
<title>Add issue links to Danger roulette comments</title>
<updated>2019-04-08T10:56:17+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2019-04-08T09:50:39+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=575ec3af131e9c101edfc50ee563381b37c8076e'/>
<id>575ec3af131e9c101edfc50ee563381b37c8076e</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
