<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/danger, branch docs-pages-force-https</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>When using suggestions, squash must be enabled</title>
<updated>2019-06-19T14:17:10+00:00</updated>
<author>
<name>Achilleas Pipinellis</name>
<email>axil@gitlab.com</email>
</author>
<published>2019-06-19T14:17:10+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=f10c8481b3c44e955c086cb841e9391574c68308'/>
<id>f10c8481b3c44e955c086cb841e9391574c68308</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Backport the EE schema and migrations to CE</title>
<updated>2019-06-17T15:09:05+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2019-04-29T12:16:03+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=8469f59d786be6762908f62d642625790999cb9b'/>
<id>8469f59d786be6762908f62d642625790999cb9b</id>
<content type='text'>
This backports all EE schema changes to CE, including EE migrations,
ensuring both use the same schema.

== Updated tests

A spec related to ghost and support bot users had to be modified to make
it pass. The spec in question assumes that the "support_bot" column
exists when defining the spec. In the single codebase setup this is not
the case, as the column is backported in a later migration. Any attempt
to use a different schema version or use of "around" blocks to
conditionally disable specs won't help, as reverting the backport
migration would also drop the "support_bot" column. Removing the
"support_bot" tests entirely appears to be the only solution.

We also need to update some foreign key tests now that we have
backported the EE columns. Fortunately, these changes are very minor.

== Backporting migrations

This commit moves EE specific migrations (except those for the Geo
tracking database) and related files to CE, and also removes any traces
of the ee/db directory.

Some migrations had to be modified or removed, as they no longer work
with the schema being backported. These migrations were all quite old,
so we opted for removing them where modifying them would take too much
time and effort.

Some old migrations were modified in EE, while also existing in CE. In
these cases we took the EE code, and in one case removed them entirely.
It's not worth spending time trying to merge these changes somehow as we
plan to remove old migrations around the release of 12.0, see
https://gitlab.com/gitlab-org/gitlab-ce/issues/59177 for more details.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This backports all EE schema changes to CE, including EE migrations,
ensuring both use the same schema.

== Updated tests

A spec related to ghost and support bot users had to be modified to make
it pass. The spec in question assumes that the "support_bot" column
exists when defining the spec. In the single codebase setup this is not
the case, as the column is backported in a later migration. Any attempt
to use a different schema version or use of "around" blocks to
conditionally disable specs won't help, as reverting the backport
migration would also drop the "support_bot" column. Removing the
"support_bot" tests entirely appears to be the only solution.

We also need to update some foreign key tests now that we have
backported the EE columns. Fortunately, these changes are very minor.

== Backporting migrations

This commit moves EE specific migrations (except those for the Geo
tracking database) and related files to CE, and also removes any traces
of the ee/db directory.

Some migrations had to be modified or removed, as they no longer work
with the schema being backported. These migrations were all quite old,
so we opted for removing them where modifying them would take too much
time and effort.

Some old migrations were modified in EE, while also existing in CE. In
these cases we took the EE code, and in one case removed them entirely.
It's not worth spending time trying to merge these changes somehow as we
plan to remove old migrations around the release of 12.0, see
https://gitlab.com/gitlab-org/gitlab-ce/issues/59177 for more details.
</pre>
</div>
</content>
</entry>
<entry>
<title>Excludes MR author from Review roulette</title>
<updated>2019-06-12T19:32:35+00:00</updated>
<author>
<name>Jacopo</name>
<email>beschi.jacopo@gmail.com</email>
</author>
<published>2019-05-30T10:50:40+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=cef127e10778a21756c00c4226592f32f15a6c1f'/>
<id>cef127e10778a21756c00c4226592f32f15a6c1f</id>
<content type='text'>
Excludes MR author from gitlab_ui and single_codebase Review roulette
results.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Excludes MR author from gitlab_ui and single_codebase Review roulette
results.
</pre>
</div>
</content>
</entry>
<entry>
<title>Don't fail the pipeline when a colon-emoji is used</title>
<updated>2019-06-06T18:14:08+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2019-06-06T18:14:08+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=1b2de25deeab172cabd8d74ad7fc60a4db39cbe5'/>
<id>1b2de25deeab172cabd8d74ad7fc60a4db39cbe5</id>
<content type='text'>
A colon-emoji like :100: can be valid in the case where we're talking
about the GitLab feature that processes these into emojis. It's fine to
warn about those, but failing the pipeline is too restrictive.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
A colon-emoji like :100: can be valid in the case where we're talking
about the GitLab feature that processes these into emojis. It's fine to
warn about those, but failing the pipeline is too restrictive.
</pre>
</div>
</content>
</entry>
<entry>
<title>Show Test Automation Engineer for spec/feature as</title>
<updated>2019-06-06T13:11:57+00:00</updated>
<author>
<name>Lin Jen-Shin</name>
<email>godfat@godfat.org</email>
</author>
<published>2019-05-23T18:07:59+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=74399a90989e5caade1de1833a7f65cfbc070bcd'/>
<id>74399a90989e5caade1de1833a7f65cfbc070bcd</id>
<content type='text'>
reviewers.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
reviewers.
</pre>
</div>
</content>
</entry>
<entry>
<title>Use roulette for single codebase roulette</title>
<updated>2019-05-30T11:24:28+00:00</updated>
<author>
<name>Lin Jen-Shin</name>
<email>godfat@godfat.org</email>
</author>
<published>2019-05-29T15:15:09+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=ceb0636cbe600a27a9ce8e5d66c796647af3c84b'/>
<id>ceb0636cbe600a27a9ce8e5d66c796647af3c84b</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Extract roulette to its own module</title>
<updated>2019-05-30T11:24:28+00:00</updated>
<author>
<name>Lin Jen-Shin</name>
<email>godfat@godfat.org</email>
</author>
<published>2019-05-29T14:38:26+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=c90ba127bf8cdd4ccac9692b6c96fa746314cd55'/>
<id>c90ba127bf8cdd4ccac9692b6c96fa746314cd55</id>
<content type='text'>
So it's more modular and extensible
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
So it's more modular and extensible
</pre>
</div>
</content>
</entry>
<entry>
<title>Run rubocop -a on CE files</title>
<updated>2019-05-05T10:24:28+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2019-05-05T10:19:14+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=f93b2e02a56a3b1f3041119e8302d43aeafc8284'/>
<id>f93b2e02a56a3b1f3041119e8302d43aeafc8284</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix reviewer roulette when no-one is in a category</title>
<updated>2019-04-30T12:31:52+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2019-04-30T12:31:52+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=60525148e7532934913b56586ccdd4c37b74a637'/>
<id>60525148e7532934913b56586ccdd4c37b74a637</id>
<content type='text'>
This would return `people.size` before, when it should return `nil`.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This would return `people.size` before, when it should return `nil`.
</pre>
</div>
</content>
</entry>
<entry>
<title>Exclude reviewers with OOO in status</title>
<updated>2019-04-29T18:49:28+00:00</updated>
<author>
<name>Michael Kozono</name>
<email>mkozono@gmail.com</email>
</author>
<published>2019-04-26T00:23:30+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=dfc9d0b6940022b82a526e642ed89a9d5422d494'/>
<id>dfc9d0b6940022b82a526e642ed89a9d5422d494</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
