<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/danger/roulette, branch scripts-differences</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Document database review process</title>
<updated>2019-07-19T17:33:48+00:00</updated>
<author>
<name>Toon Claes</name>
<email>toon@gitlab.com</email>
</author>
<published>2019-07-19T17:33:48+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=34a5f77e770765f278ade00a33ef846e2e1ce3d3'/>
<id>34a5f77e770765f278ade00a33ef846e2e1ce3d3</id>
<content type='text'>
See https://gitlab.com/gitlab-com/gl-infra/infrastructure/issues/6069
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
See https://gitlab.com/gitlab-com/gl-infra/infrastructure/issues/6069
</pre>
</div>
</content>
</entry>
<entry>
<title>Excludes MR author from Review roulette</title>
<updated>2019-06-12T19:32:35+00:00</updated>
<author>
<name>Jacopo</name>
<email>beschi.jacopo@gmail.com</email>
</author>
<published>2019-05-30T10:50:40+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=cef127e10778a21756c00c4226592f32f15a6c1f'/>
<id>cef127e10778a21756c00c4226592f32f15a6c1f</id>
<content type='text'>
Excludes MR author from gitlab_ui and single_codebase Review roulette
results.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Excludes MR author from gitlab_ui and single_codebase Review roulette
results.
</pre>
</div>
</content>
</entry>
<entry>
<title>Show Test Automation Engineer for spec/feature as</title>
<updated>2019-06-06T13:11:57+00:00</updated>
<author>
<name>Lin Jen-Shin</name>
<email>godfat@godfat.org</email>
</author>
<published>2019-05-23T18:07:59+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=74399a90989e5caade1de1833a7f65cfbc070bcd'/>
<id>74399a90989e5caade1de1833a7f65cfbc070bcd</id>
<content type='text'>
reviewers.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
reviewers.
</pre>
</div>
</content>
</entry>
<entry>
<title>Extract roulette to its own module</title>
<updated>2019-05-30T11:24:28+00:00</updated>
<author>
<name>Lin Jen-Shin</name>
<email>godfat@godfat.org</email>
</author>
<published>2019-05-29T14:38:26+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=c90ba127bf8cdd4ccac9692b6c96fa746314cd55'/>
<id>c90ba127bf8cdd4ccac9692b6c96fa746314cd55</id>
<content type='text'>
So it's more modular and extensible
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
So it's more modular and extensible
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix reviewer roulette when no-one is in a category</title>
<updated>2019-04-30T12:31:52+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2019-04-30T12:31:52+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=60525148e7532934913b56586ccdd4c37b74a637'/>
<id>60525148e7532934913b56586ccdd4c37b74a637</id>
<content type='text'>
This would return `people.size` before, when it should return `nil`.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This would return `people.size` before, when it should return `nil`.
</pre>
</div>
</content>
</entry>
<entry>
<title>Exclude reviewers with OOO in status</title>
<updated>2019-04-29T18:49:28+00:00</updated>
<author>
<name>Michael Kozono</name>
<email>mkozono@gmail.com</email>
</author>
<published>2019-04-26T00:23:30+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=dfc9d0b6940022b82a526e642ed89a9d5422d494'/>
<id>dfc9d0b6940022b82a526e642ed89a9d5422d494</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Pick reviewers based on branch name</title>
<updated>2019-04-08T10:56:17+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2019-04-08T10:44:57+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=28531ab43666b5fdf37e0a70db3bcbf7d3f92183'/>
<id>28531ab43666b5fdf37e0a70db3bcbf7d3f92183</id>
<content type='text'>
Change reviewer roulette to always pick the same reviewers for the same
branch name. We do this by:

1. Making the branch name 'canonical' across CE and EE by stripping a
   leading 'ce-' or 'ee-' and a trailing '-ce' or '-ee'. If people are
   following our branch naming guidelines, this should give the same
   branch name in both repos.
2. Converting the branch name to a stable integer by taking the integer
   form of its MD5.
3. Passing that integer as a seed to Ruby's `Random` class, which 'may
   be used to ensure repeatable sequences of pseudo-random numbers
   between different runs of the program' (from the Ruby documentation).

The upshot is that the same branch name (in CE and EE) should always
pick the same reviewers, and those should be evenly distributed across
the set of possible reviewers due to the use of MD5.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change reviewer roulette to always pick the same reviewers for the same
branch name. We do this by:

1. Making the branch name 'canonical' across CE and EE by stripping a
   leading 'ce-' or 'ee-' and a trailing '-ce' or '-ee'. If people are
   following our branch naming guidelines, this should give the same
   branch name in both repos.
2. Converting the branch name to a stable integer by taking the integer
   form of its MD5.
3. Passing that integer as a seed to Ruby's `Random` class, which 'may
   be used to ensure repeatable sequences of pseudo-random numbers
   between different runs of the program' (from the Ruby documentation).

The upshot is that the same branch name (in CE and EE) should always
pick the same reviewers, and those should be evenly distributed across
the set of possible reviewers due to the use of MD5.
</pre>
</div>
</content>
</entry>
<entry>
<title>Add issue links to Danger roulette comments</title>
<updated>2019-04-08T10:56:17+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2019-04-08T09:50:39+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=575ec3af131e9c101edfc50ee563381b37c8076e'/>
<id>575ec3af131e9c101edfc50ee563381b37c8076e</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Make trainee maintainers three times as likely to be picked</title>
<updated>2019-04-05T10:20:44+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2019-04-05T10:20:44+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=dea11717249b98383e4c5435b885287230680616'/>
<id>dea11717249b98383e4c5435b885287230680616</id>
<content type='text'>
Trainee maintainers count as reviewers, but should get more reviews than
most reviewers, as they need practice to become a maintainer. This makes
them three times as likely to be picked (compared to another reviewer;
compared to before, it's roughly twice as likely at the current numbers
for each).

Also, switch to `Array#sample` because I think it looks nicer.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Trainee maintainers count as reviewers, but should get more reviews than
most reviewers, as they need practice to become a maintainer. This makes
them three times as likely to be picked (compared to another reviewer;
compared to before, it's roughly twice as likely at the current numbers
for each).

Also, switch to `Array#sample` because I think it looks nicer.
</pre>
</div>
</content>
</entry>
<entry>
<title>Set specific reviewers for the GitLab UI WG effort</title>
<updated>2019-03-29T11:56:18+00:00</updated>
<author>
<name>Filipa Lacerda</name>
<email>filipa@gitlab.com</email>
</author>
<published>2019-03-29T10:51:25+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=072489e36df3ef6824ba0f9b90e7a6f87f9ee4f4'/>
<id>072489e36df3ef6824ba0f9b90e7a6f87f9ee4f4</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
