delta/gitlab/gitlab-ce.git/danger/eslint, branch scripts-differences gitlab.com: gitlab-org/gitlab-ce.git Create helper to get all changed files 2018-10-22T09:04:55+00:00 Lukas Eipert leipert@gitlab.com 2018-10-16T13:56:03+00:00 253e1818aa3efafb05d9994aab0f778d339e26ac Danger apparently has three different objects which could contain files you often want to check: - git.added_files - git.modified_files - git.renamed_files The problem: If a file is renamed, `modified_files` contains the file path before the rename. In some Danger checks we use `added_files` + `modified_files`, which might contain the deleted paths of renamed files, but missing the new paths of renamed files. So we need to consider `renamed_files` as well. 
Danger apparently has three different objects which could contain files
you often want to check:

 - git.added_files
 - git.modified_files
 - git.renamed_files

The problem: If a file is renamed, `modified_files` contains the file
path before the rename. In some Danger checks we use `added_files` +
`modified_files`, which might contain the deleted paths of renamed
files, but missing the new paths of renamed files.

So we need to consider `renamed_files` as well.
Danger check for ignored eslint rules 2018-09-29T06:22:12+00:00 Lukas Eipert leipert@gitlab.com 2018-09-21T16:26:48+00:00 685d579472018c968e785d7d49ec7f84f7438e97 We disabled a lot of eslint rules on a per-file basis. This checks touched files for those and reminds you to re-enable the rules and fix them. 
We disabled a lot of eslint rules on a per-file basis. This checks
touched files for those and reminds you to re-enable the rules and fix
them.