<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/config/initializers, branch winh-notes-service-toggleResolveNote</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Limit user information to RackAttack throttles</title>
<updated>2019-07-09T03:58:49+00:00</updated>
<author>
<name>Mayra Cabrera</name>
<email>mcabrera@gitlab.com</email>
</author>
<published>2019-07-09T03:58:49+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=bcd813c0958b10a9b87e162a85a434255002e027'/>
<id>bcd813c0958b10a9b87e162a85a434255002e027</id>
<content type='text'>
rack.attack.match_discriminator is only return on
throttle_authenticated_api or throttle_authenticated_web requests, so
we're avoiding logging user_id on blacklist requests

Follow up of https://gitlab.com/gitlab-org/gitlab-ce/issues/62756
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
rack.attack.match_discriminator is only return on
throttle_authenticated_api or throttle_authenticated_web requests, so
we're avoiding logging user_id on blacklist requests

Follow up of https://gitlab.com/gitlab-org/gitlab-ce/issues/62756
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix race in forbid_sidekiq_in_transactions.rb</title>
<updated>2019-07-04T15:13:06+00:00</updated>
<author>
<name>Kamil Trzciński</name>
<email>ayufan@ayufan.eu</email>
</author>
<published>2019-07-04T13:46:46+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=133b9f41088288a53d0b7cca0e9d5bab4a633567'/>
<id>133b9f41088288a53d0b7cca0e9d5bab4a633567</id>
<content type='text'>
Current code uses module attribute which stores value
global instead of locally (thread locally). This results
in concurrent accesses to overwrite the each other values
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Current code uses module attribute which stores value
global instead of locally (thread locally). This results
in concurrent accesses to overwrite the each other values
</pre>
</div>
</content>
</entry>
<entry>
<title>Only save Peek session in Redis when Peek is enabled</title>
<updated>2019-07-03T14:02:42+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2019-07-03T14:02:03+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=eaf58debac14474dc7ad5e5a6a6fc88da0af1370'/>
<id>eaf58debac14474dc7ad5e5a6a6fc88da0af1370</id>
<content type='text'>
Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch '63869-store-prometheus-metrics-in-separate-dirs-in-test-and-prod' into 'master'</title>
<updated>2019-07-02T20:52:12+00:00</updated>
<author>
<name>Kamil Trzciński</name>
<email>ayufan@ayufan.eu</email>
</author>
<published>2019-07-02T20:52:12+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=a0c98f70708a2bb1d867cbac6310cd60307fee04'/>
<id>a0c98f70708a2bb1d867cbac6310cd60307fee04</id>
<content type='text'>
Use separate Prometheus metrics dirs in dev/test

Closes #63869

See merge request gitlab-org/gitlab-ce!30253</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Use separate Prometheus metrics dirs in dev/test

Closes #63869

See merge request gitlab-org/gitlab-ce!30253</pre>
</div>
</content>
</entry>
<entry>
<title>Include user id and username in auth log</title>
<updated>2019-07-02T19:48:06+00:00</updated>
<author>
<name>Mayra Cabrera</name>
<email>mcabrera@gitlab.com</email>
</author>
<published>2019-07-02T19:48:06+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=fc85b07a27a5e1cc77105235562e7be151a266a8'/>
<id>fc85b07a27a5e1cc77105235562e7be151a266a8</id>
<content type='text'>
Fetches user based on the value of 'rack.attack.match_discriminator'

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/62756
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fetches user based on the value of 'rack.attack.match_discriminator'

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/62756
</pre>
</div>
</content>
</entry>
<entry>
<title>Start UnicornSampler in master process</title>
<updated>2019-07-02T17:05:56+00:00</updated>
<author>
<name>Jan Provaznik</name>
<email>jprovaznik@gitlab.com</email>
</author>
<published>2019-07-02T17:05:56+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=3c883759c6ea9c1c60e69fd3e65fbf56b9e7af30'/>
<id>3c883759c6ea9c1c60e69fd3e65fbf56b9e7af30</id>
<content type='text'>
Using `on_master_start` assures that the sampler is started in
master process and not in worker processes.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Using `on_master_start` assures that the sampler is started in
master process and not in worker processes.
</pre>
</div>
</content>
</entry>
<entry>
<title>Use separate Prometheus metrics dirs in dev/test</title>
<updated>2019-07-02T15:42:01+00:00</updated>
<author>
<name>Aleksei Lipniagov</name>
<email>alipniagov@gitlab.com</email>
</author>
<published>2019-07-02T07:36:33+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=57ae2f7e2d56a38140ae66915885567d361e240a'/>
<id>57ae2f7e2d56a38140ae66915885567d361e240a</id>
<content type='text'>
Store Sidekiq and Web server metrics from Prometheus in separate
directories in `development` and `test` environments.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Store Sidekiq and Web server metrics from Prometheus in separate
directories in `development` and `test` environments.
</pre>
</div>
</content>
</entry>
<entry>
<title>Includes logic to persist namespace statistics</title>
<updated>2019-07-02T14:44:39+00:00</updated>
<author>
<name>Mayra Cabrera</name>
<email>mcabrera@gitlab.com</email>
</author>
<published>2019-07-02T14:44:39+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=dfdfa913ba9cb74beb7adad0352c5efadec84494'/>
<id>dfdfa913ba9cb74beb7adad0352c5efadec84494</id>
<content type='text'>
- Add two new ActiveRecord models:
  - RootNamespaceStoragestatistics will persist root namespace statistics
  - NamespaceAggregationSchedule will save information when a new update
to the namespace statistics needs to be scheduled
- Inject into UpdateProjectStatistics concern a new callback that will
call an async job to insert a new row onto NamespaceAggregationSchedule
table
- When a new row is inserted a new job is scheduled. This job will
update call an specific service to update the statistics and after that
it will delete thee aggregated scheduled row
- The RefresherServices makes heavy use of arel to build composable
queries to update Namespace::RootStorageStatistics attributes.
- Add an extra worker to traverse pending rows on
NAmespace::AggregationSchedule table and schedule a worker for each one
of this rows.
- Add an extra worker to traverse pending rows on
NAmespace::AggregationSchedule table and schedule a worker for each one
of this rows
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- Add two new ActiveRecord models:
  - RootNamespaceStoragestatistics will persist root namespace statistics
  - NamespaceAggregationSchedule will save information when a new update
to the namespace statistics needs to be scheduled
- Inject into UpdateProjectStatistics concern a new callback that will
call an async job to insert a new row onto NamespaceAggregationSchedule
table
- When a new row is inserted a new job is scheduled. This job will
update call an specific service to update the statistics and after that
it will delete thee aggregated scheduled row
- The RefresherServices makes heavy use of arel to build composable
queries to update Namespace::RootStorageStatistics attributes.
- Add an extra worker to traverse pending rows on
NAmespace::AggregationSchedule table and schedule a worker for each one
of this rows.
- Add an extra worker to traverse pending rows on
NAmespace::AggregationSchedule table and schedule a worker for each one
of this rows
</pre>
</div>
</content>
</entry>
<entry>
<title>Add a memory cache local to the thread to reduce Redis load</title>
<updated>2019-07-02T05:23:01+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2019-07-01T19:17:37+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=978647c6cb0f81c3695c4d20e98619c2025532c5'/>
<id>978647c6cb0f81c3695c4d20e98619c2025532c5</id>
<content type='text'>
Loading `ApplicationSetting` from Redis was responsible for at least 50%
of the CPU load of the Redis cluster on GitLab.com. Since these values
generally don't change very much, we can load this from the database and
cache it in memory, skipping Redis altogther. We use
`ActiveSupport::Cache::MemoryStore` as a drop-in replacement for
`RedisCacheStore` even though we probably don't need synchronized access
within `Thread.current`.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/63977
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Loading `ApplicationSetting` from Redis was responsible for at least 50%
of the CPU load of the Redis cluster on GitLab.com. Since these values
generally don't change very much, we can load this from the database and
cache it in memory, skipping Redis altogther. We use
`ActiveSupport::Cache::MemoryStore` as a drop-in replacement for
`RedisCacheStore` even though we probably don't need synchronized access
within `Thread.current`.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/63977
</pre>
</div>
</content>
</entry>
<entry>
<title>Run do_master_restart callback on server start</title>
<updated>2019-07-01T15:32:19+00:00</updated>
<author>
<name>Jan Provaznik</name>
<email>jprovaznik@gitlab.com</email>
</author>
<published>2019-07-01T15:32:19+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=606261e8e7d6d7879a2b88c3c217df08b063c9fc'/>
<id>606261e8e7d6d7879a2b88c3c217df08b063c9fc</id>
<content type='text'>
We want to call master_restart callback on start too - this callback
is used for cleaning up prometheus files. It has been added to
Omnibus already:
https://gitlab.com/gitlab-org/omnibus-gitlab/merge_requests/3350

So make sure that Unicorn example configs are up-to-date and that
the same callback is called for Puma too.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We want to call master_restart callback on start too - this callback
is used for cleaning up prometheus files. It has been added to
Omnibus already:
https://gitlab.com/gitlab-org/omnibus-gitlab/merge_requests/3350

So make sure that Unicorn example configs are up-to-date and that
the same callback is called for Puma too.
</pre>
</div>
</content>
</entry>
</feed>
