<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/config/initializers, branch lib-differences</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Merge branch 'sh-support-csp-nonce' into 'master'</title>
<updated>2019-08-07T05:03:05+00:00</updated>
<author>
<name>Ash McKenzie</name>
<email>amckenzie@gitlab.com</email>
</author>
<published>2019-08-07T05:03:05+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=6cafa7002738f33c212b9f72d9b0f66b386c6faf'/>
<id>6cafa7002738f33c212b9f72d9b0f66b386c6faf</id>
<content type='text'>
Add support for Content-Security-Policy

Closes #65330

See merge request gitlab-org/gitlab-ce!31402</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Add support for Content-Security-Policy

Closes #65330

See merge request gitlab-org/gitlab-ce!31402</pre>
</div>
</content>
</entry>
<entry>
<title>Add support for Content-Security-Policy</title>
<updated>2019-08-07T02:37:31+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2019-08-06T06:14:32+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=5fbbd3dd6e965f76ecf1767373bddd236a78a4be'/>
<id>5fbbd3dd6e965f76ecf1767373bddd236a78a4be</id>
<content type='text'>
A nonce-based Content-Security-Policy thwarts XSS attacks by allowing
inline JavaScript to execute if the script nonce matches the header
value. Rails 5.2 supports nonce-based Content-Security-Policy headers,
so provide configuration to enable this and make it work.

To support this, we need to change all `:javascript` HAML filters to the
following form:

```
= javascript_tag nonce: true do
  :plain
    ...
```

We use `%script` throughout our HAML to store JSON and other text, but
since this doesn't execute, browsers don't appear to block this content
from being used and require the nonce value to be present.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
A nonce-based Content-Security-Policy thwarts XSS attacks by allowing
inline JavaScript to execute if the script nonce matches the header
value. Rails 5.2 supports nonce-based Content-Security-Policy headers,
so provide configuration to enable this and make it work.

To support this, we need to change all `:javascript` HAML filters to the
following form:

```
= javascript_tag nonce: true do
  :plain
    ...
```

We use `%script` throughout our HAML to store JSON and other text, but
since this doesn't execute, browsers don't appear to block this content
from being used and require the nonce value to be present.
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove GC metrics from performance bar</title>
<updated>2019-08-06T19:42:46+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2019-08-06T18:05:47+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=66963aad70abba7a87512070047244eefefeb563'/>
<id>66963aad70abba7a87512070047244eefefeb563</id>
<content type='text'>
These were disabled in production mode, but that also broke the rest of
the performance bar. As they were only enabled in development mode, we
can just remove them for now.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
These were disabled in production mode, but that also broke the rest of
the performance bar. As they were only enabled in development mode, we
can just remove them for now.
</pre>
</div>
</content>
</entry>
<entry>
<title>Revert "Merge branch 'backport-fix-remaining-prepend-lines' into 'master'"</title>
<updated>2019-08-05T04:02:08+00:00</updated>
<author>
<name>Mark Lapierre</name>
<email>mlapierre@gitlab.com</email>
</author>
<published>2019-08-05T04:02:08+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=8ff68917b8b78dbf34785bda370692ac8b97c414'/>
<id>8ff68917b8b78dbf34785bda370692ac8b97c414</id>
<content type='text'>
This reverts merge request !31379</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This reverts merge request !31379</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'backport-fix-remaining-prepend-lines' into 'master'</title>
<updated>2019-08-02T16:25:30+00:00</updated>
<author>
<name>Robert Speicher</name>
<email>rspeicher@gmail.com</email>
</author>
<published>2019-08-02T16:25:30+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=8374dd565d44e5f97c179dcb4cf03c7d3ea69363'/>
<id>8374dd565d44e5f97c179dcb4cf03c7d3ea69363</id>
<content type='text'>
Support X_if_ee methods for QA tests

See merge request gitlab-org/gitlab-ce!31379</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Support X_if_ee methods for QA tests

See merge request gitlab-org/gitlab-ce!31379</pre>
</div>
</content>
</entry>
<entry>
<title>Call `GC::Profiler.clear` only in one place</title>
<updated>2019-08-02T09:04:32+00:00</updated>
<author>
<name>Aleksei Lipniagov</name>
<email>alipniagov@gitlab.com</email>
</author>
<published>2019-08-02T09:04:32+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=1f9edb7c4a393a6ebe78e6f98e46515ad655cece'/>
<id>1f9edb7c4a393a6ebe78e6f98e46515ad655cece</id>
<content type='text'>
Previously, both InfluxSampler and RubySampler were relying on the
`GC::Profiler.total_time` data which is the sum over the list
of captured GC events. Also, both samplers asynchronously called
`GC::Profiler.clear` which led to incorrect metric data because
each sampler has the wrong assumption it is the only object who calls
`GC::Profiler.clear` and thus could rely on the gathered results between
such calls.

We should ensure that `GC::Profiler.total_time` is called only in one
place making it possible to rely on accumulated data between such wipes.

Also, we need to track the amount of profiler reports we lost.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Previously, both InfluxSampler and RubySampler were relying on the
`GC::Profiler.total_time` data which is the sum over the list
of captured GC events. Also, both samplers asynchronously called
`GC::Profiler.clear` which led to incorrect metric data because
each sampler has the wrong assumption it is the only object who calls
`GC::Profiler.clear` and thus could rely on the gathered results between
such calls.

We should ensure that `GC::Profiler.total_time` is called only in one
place making it possible to rely on accumulated data between such wipes.

Also, we need to track the amount of profiler reports we lost.
</pre>
</div>
</content>
</entry>
<entry>
<title>Backport of https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/3809</title>
<updated>2019-08-01T17:38:07+00:00</updated>
<author>
<name>Valery Sizov</name>
<email>valery@gitlab.com</email>
</author>
<published>2019-08-01T12:03:08+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=f519a4b72f81a1e3c81e5e684d236bbe30e0dd2d'/>
<id>f519a4b72f81a1e3c81e5e684d236bbe30e0dd2d</id>
<content type='text'>
Introducing Docker Registry replication
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Introducing Docker Registry replication
</pre>
</div>
</content>
</entry>
<entry>
<title>Support X_if_ee methods for QA tests</title>
<updated>2019-08-01T14:10:05+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2019-08-01T12:41:37+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=27194e08525fa2ef43aa9f3dbfda378a7b1258bd'/>
<id>27194e08525fa2ef43aa9f3dbfda378a7b1258bd</id>
<content type='text'>
For the QA tests to use the new injection methods, we must require the
initializer and ensure that the "constantize" method is available.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
For the QA tests to use the new injection methods, we must require the
initializer and ensure that the "constantize" method is available.
</pre>
</div>
</content>
</entry>
<entry>
<title>Add methods for injecting EE modules</title>
<updated>2019-07-30T12:52:54+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2019-07-23T14:51:13+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=916183a7fd63f772a8493c9ac782b465503f9d13'/>
<id>916183a7fd63f772a8493c9ac782b465503f9d13</id>
<content type='text'>
This adds the methods prepend_if_ee, extend_if_ee, and include_if_ee
that can be used to inject EE specific modules in EE.

These methods are exposed as an initializer that is loaded as soon as
possible. For tests that use fast_spec_helper.rb we must load this
initializer manually, as the Rails environment is not loaded. This is
not the most pretty setup, but unfortunately there is no alternative
that we can use.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This adds the methods prepend_if_ee, extend_if_ee, and include_if_ee
that can be used to inject EE specific modules in EE.

These methods are exposed as an initializer that is loaded as soon as
possible. For tests that use fast_spec_helper.rb we must load this
initializer manually, as the Rails environment is not loaded. This is
not the most pretty setup, but unfortunately there is no alternative
that we can use.
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove line profiler from performance bar</title>
<updated>2019-07-30T09:00:52+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2019-07-24T11:37:05+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=18cdc5ba6ce1810c19982475eca89fd385fe31e2'/>
<id>18cdc5ba6ce1810c19982475eca89fd385fe31e2</id>
<content type='text'>
1. The output isn't great. It can be hard to find hotspots and, even
   when you do find them, to find why those are hotspots.
2. It uses some jQuery-specific frontend code which we can remove now
   that we don't have this any more.
3. It's only possible to profile the initial request, not any subsequent
   AJAX requests.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
1. The output isn't great. It can be hard to find hotspots and, even
   when you do find them, to find why those are hotspots.
2. It uses some jQuery-specific frontend code which we can remove now
   that we don't have this any more.
3. It's only possible to profile the initial request, not any subsequent
   AJAX requests.
</pre>
</div>
</content>
</entry>
</feed>
