<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/config/initializers/metrics.rb, branch commit-description-border</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Add metric initializer spec</title>
<updated>2017-01-24T14:42:57+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2017-01-23T14:41:32+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=a96765e6274b9b6886ee6172d25d47a9d36f18c6'/>
<id>a96765e6274b9b6886ee6172d25d47a9d36f18c6</id>
<content type='text'>
An empty file in one of the instrumented directories will cause the app
to fail to start when metrics are enabled. Metrics aren't enabled by
default in development or test.

We could handle the empty file case explicitly, but a file could still
not define the constant it is expected to, so instead run the
initializer manually in a spec and check that it succeeds.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
An empty file in one of the instrumented directories will cause the app
to fail to start when metrics are enabled. Metrics aren't enabled by
default in development or test.

We could handle the empty file case explicitly, but a file could still
not define the constant it is expected to, so instead run the
initializer manually in a spec and check that it succeeds.
</pre>
</div>
</content>
</entry>
<entry>
<title>Add instrumentation to conflict classes</title>
<updated>2016-10-13T19:16:34+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2016-09-01T10:39:37+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=5c5259335f8bcc4de117c1e36648a269911281fb'/>
<id>5c5259335f8bcc4de117c1e36648a269911281fb</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Gitlab::Checks is now instrumented</title>
<updated>2016-09-13T09:58:08+00:00</updated>
<author>
<name>Paco Guzman</name>
<email>pacoguzmanp@gmail.com</email>
</author>
<published>2016-09-13T09:58:08+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=41c08c93bca20c4e25797d61d697fdac71881600'/>
<id>41c08c93bca20c4e25797d61d697fdac71881600</id>
<content type='text'>
So we have a detailed view of what checks perform bad</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
So we have a detailed view of what checks perform bad</pre>
</div>
</content>
</entry>
<entry>
<title>Instrument Project.visible_to_user</title>
<updated>2016-08-12T14:43:10+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2016-08-12T14:43:10+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=e0fc43ebe2d174c97062e79de36161914dafbb66'/>
<id>e0fc43ebe2d174c97062e79de36161914dafbb66</id>
<content type='text'>
Because this method is a Rails scope we have to instrument it manually
as regular the instrumentation methods only instrument methods defined
directly on a Class or Module.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Because this method is a Rails scope we have to instrument it manually
as regular the instrumentation methods only instrument methods defined
directly on a Class or Module.
</pre>
</div>
</content>
</entry>
<entry>
<title>Instrument Gitlab::Highlight</title>
<updated>2016-08-03T15:08:41+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2016-08-03T15:08:41+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=9a934e25011baa7b68239ce6fdbe010ab88cf86f'/>
<id>9a934e25011baa7b68239ce6fdbe010ab88cf86f</id>
<content type='text'>
This class does quite a few interesting things so let's instrument it so
we can see how much time is being spent in this class.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This class does quite a few interesting things so let's instrument it so
we can see how much time is being spent in this class.
</pre>
</div>
</content>
</entry>
<entry>
<title>Instrument the Repository class</title>
<updated>2016-08-02T11:30:13+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2016-08-02T11:29:43+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=946d3b132e6f8e95b7d8b95e32fd8231b835137d'/>
<id>946d3b132e6f8e95b7d8b95e32fd8231b835137d</id>
<content type='text'>
Since this isn't an ActiveRecord::Base descendant it wasn't
instrumented.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Since this isn't an ActiveRecord::Base descendant it wasn't
instrumented.
</pre>
</div>
</content>
</entry>
<entry>
<title>Instrument Nokogiri parsing methods</title>
<updated>2016-07-25T13:45:42+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2016-07-25T13:45:04+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=67012f4ae0c914473162d3d84d62e96dad2b3fc4'/>
<id>67012f4ae0c914473162d3d84d62e96dad2b3fc4</id>
<content type='text'>
This allows us to see how much time is being spent in just parsing
HTML/XML documents.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This allows us to see how much time is being spent in just parsing
HTML/XML documents.
</pre>
</div>
</content>
</entry>
<entry>
<title>Instrument Rinku usage</title>
<updated>2016-07-04T10:20:57+00:00</updated>
<author>
<name>Paco Guzman</name>
<email>pacoguzmanp@gmail.com</email>
</author>
<published>2016-07-04T10:20:57+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=90dc6f1211ab1a9d10c6799d90310dde79581d62'/>
<id>90dc6f1211ab1a9d10c6799d90310dde79581d62</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Metrics for Rouge::Plugins::Redcarpet and Rouge::Formatters::HTMLGitlab</title>
<updated>2016-07-01T10:34:28+00:00</updated>
<author>
<name>Paco Guzman</name>
<email>pacoguzmanp@gmail.com</email>
</author>
<published>2016-07-01T09:16:48+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=521454831ee9e899e046ed288596865df55e8832'/>
<id>521454831ee9e899e046ed288596865df55e8832</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Support for rendering/redacting multiple documents</title>
<updated>2016-06-24T09:46:39+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2016-06-21T11:35:09+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d470f3d1954a33d2ea6069fadcbb9810267b024f'/>
<id>d470f3d1954a33d2ea6069fadcbb9810267b024f</id>
<content type='text'>
This commit changes the way certain documents are rendered (currently
only Notes) and how documents are redacted. Previously both rendering
and redacting would run on a per document basis. The result of this was
that for every document we'd have to run countless queries just to
figure out if we could display a set of links or not.

This commit changes things around so that redacting Markdown documents
is no longer tied into the html-pipeline Gem. This in turn allows it to
redact multiple documents in a single pass, thus reducing the number of
queries needed.

In turn rendering issue/merge request notes has been adjusted to take
advantage of this new setup. Instead of rendering Markdown somewhere
deep down in a view the Markdown is rendered and redacted in the
controller (taking the current user and all that into account). This has
been done in such a way that the "markdown()" helper method can still be
used on its own.

This particular commit also paves the way for caching rendered HTML on
object level. Right now there's an accessor method Note#note_html which
is used for setting/getting the rendered HTML. Once we cache HTML on row
level we can simply change this field to be a column and call a "save"
whenever needed and we're pretty much done.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This commit changes the way certain documents are rendered (currently
only Notes) and how documents are redacted. Previously both rendering
and redacting would run on a per document basis. The result of this was
that for every document we'd have to run countless queries just to
figure out if we could display a set of links or not.

This commit changes things around so that redacting Markdown documents
is no longer tied into the html-pipeline Gem. This in turn allows it to
redact multiple documents in a single pass, thus reducing the number of
queries needed.

In turn rendering issue/merge request notes has been adjusted to take
advantage of this new setup. Instead of rendering Markdown somewhere
deep down in a view the Markdown is rendered and redacted in the
controller (taking the current user and all that into account). This has
been done in such a way that the "markdown()" helper method can still be
used on its own.

This particular commit also paves the way for caching rendered HTML on
object level. Right now there's an accessor method Note#note_html which
is used for setting/getting the rendered HTML. Once we cache HTML on row
level we can simply change this field to be a column and call a "save"
whenever needed and we're pretty much done.
</pre>
</div>
</content>
</entry>
</feed>
