<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/config/initializers/lograge.rb, branch document-lambda-deploy</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Add Gitaly and Rugged call timing in Sidekiq logs</title>
<updated>2019-08-09T08:08:32+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2019-08-09T04:33:20+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=a74396dcc5e372c0b6a23fd47db22ebbeb8386d7'/>
<id>a74396dcc5e372c0b6a23fd47db22ebbeb8386d7</id>
<content type='text'>
This will help identify Sidekiq jobs that invoke excessive number of
filesystem access.

The timing data is stored in `RequestStore`, but this is only active
within the middleware and is not directly accessible to the Sidekiq
logger. However, it is possible for the middleware to modify the job
hash to pass this data along to the logger.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This will help identify Sidekiq jobs that invoke excessive number of
filesystem access.

The timing data is stored in `RequestStore`, but this is only active
within the middleware and is not directly accessible to the Sidekiq
logger. However, it is possible for the middleware to modify the job
hash to pass this data along to the logger.
</pre>
</div>
</content>
</entry>
<entry>
<title>Add Rugged calls and duration to API and Rails logs</title>
<updated>2019-07-18T13:53:39+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2019-07-17T23:34:27+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=1136c0c8e98d4f0d3fb4f50219657cabe0d45c99'/>
<id>1136c0c8e98d4f0d3fb4f50219657cabe0d45c99</id>
<content type='text'>
This adds `rugged_duration_ms` and `rugged_calls` fields to
`api_json.log` and `production_json.log`. This will make it easier to
identify performance issues caused by excessive I/O.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/64676
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This adds `rugged_duration_ms` and `rugged_calls` fields to
`api_json.log` and `production_json.log`. This will make it easier to
identify performance issues caused by excessive I/O.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/64676
</pre>
</div>
</content>
</entry>
<entry>
<title>Upgrade to Rails 5.2</title>
<updated>2019-07-12T02:15:31+00:00</updated>
<author>
<name>Heinrich Lee Yu</name>
<email>heinrich@gitlab.com</email>
</author>
<published>2019-06-25T17:54:42+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=aeb67dd489b1ccc7f0ab1d702725729ab9cc3e27'/>
<id>aeb67dd489b1ccc7f0ab1d702725729ab9cc3e27</id>
<content type='text'>
Updates changed method names and fixes spec failures
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Updates changed method names and fixes spec failures
</pre>
</div>
</content>
</entry>
<entry>
<title>Migrate correlation and tracing code to LabKit</title>
<updated>2019-04-18T07:57:16+00:00</updated>
<author>
<name>Andrew Newdigate</name>
<email>andrew@gitlab.com</email>
</author>
<published>2019-02-18T20:57:22+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=4f4de36cacbcd137e9db2a7b1449bb803bf1f395'/>
<id>4f4de36cacbcd137e9db2a7b1449bb803bf1f395</id>
<content type='text'>
This change is a fairly straightforward refactor to extract the tracing
and correlation-id code from the gitlab rails codebase into the new
LabKit-Ruby project.

The corresponding import into LabKit-Ruby was in
https://gitlab.com/gitlab-org/labkit-ruby/merge_requests/1

The code itself remains very similar for now.

Extracting it allows us to reuse it in other projects, such as
Gitaly-Ruby. This will give us the advantages of correlation-ids and
distributed tracing in that project too.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This change is a fairly straightforward refactor to extract the tracing
and correlation-id code from the gitlab rails codebase into the new
LabKit-Ruby project.

The corresponding import into LabKit-Ruby was in
https://gitlab.com/gitlab-org/labkit-ruby/merge_requests/1

The code itself remains very similar for now.

Extracting it allows us to reuse it in other projects, such as
Gitaly-Ruby. This will give us the advantages of correlation-ids and
distributed tracing in that project too.
</pre>
</div>
</content>
</entry>
<entry>
<title>Log Gitaly RPC duration to api_json.log and production_json.log</title>
<updated>2019-03-27T11:01:21+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2019-03-27T10:56:36+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=74ff33a3fdb83cd03c41436b4ae10ca48075f0e9'/>
<id>74ff33a3fdb83cd03c41436b4ae10ca48075f0e9</id>
<content type='text'>
This makes it easier to debug Gitaly performance issues in the field.

This commit also makes the tracking of query time thread-safe via
RequestStore.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This makes it easier to debug Gitaly performance issues in the field.

This commit also makes the tracking of query time thread-safe via
RequestStore.
</pre>
</div>
</content>
</entry>
<entry>
<title>Log queue duration in production_json.log</title>
<updated>2019-02-12T14:58:55+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2019-02-11T00:43:44+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=51ca79228bc2d22b12d47ba177610d228793dc94'/>
<id>51ca79228bc2d22b12d47ba177610d228793dc94</id>
<content type='text'>
`queue_duration` is a useful metric that is currently in api_json.log
but not in production_json.log. We should add it because it tells us how
long the request sat in Workhorse before Unicorn processed it. Having
this field enables the support team to better troubleshoot when delays
began to happen.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
`queue_duration` is a useful metric that is currently in api_json.log
but not in production_json.log. We should add it because it tells us how
long the request sat in Workhorse before Unicorn processed it. Having
this field enables the support team to better troubleshoot when delays
began to happen.
</pre>
</div>
</content>
</entry>
<entry>
<title>Log and pass correlation-id between Unicorn, Sidekiq and Gitaly</title>
<updated>2018-12-06T19:46:14+00:00</updated>
<author>
<name>Kamil Trzciński</name>
<email>ayufan@ayufan.eu</email>
</author>
<published>2018-12-05T20:54:40+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=39c1731a53d1014eab7c876d70632b1abf738712'/>
<id>39c1731a53d1014eab7c876d70632b1abf738712</id>
<content type='text'>
The Correlation ID is taken or generated from received X-Request-ID.
Then it is being passed to all executed services (sidekiq workers
or gitaly calls).

The Correlation ID is logged in all structured logs as `correlation_id`.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The Correlation ID is taken or generated from received X-Request-ID.
Then it is being passed to all executed services (sidekiq workers
or gitaly calls).

The Correlation ID is logged in all structured logs as `correlation_id`.
</pre>
</div>
</content>
</entry>
<entry>
<title>Add User-Agent to production_json.log</title>
<updated>2018-09-05T21:43:09+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2018-09-05T21:40:36+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=93005b4e811a41da2c845b7c1ab558625c338a72'/>
<id>93005b4e811a41da2c845b7c1ab558625c338a72</id>
<content type='text'>
This will help production gain more visibility which browsers may be
having issues.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This will help production gain more visibility which browsers may be
having issues.
</pre>
</div>
</content>
</entry>
<entry>
<title>Log response body to production_json.log when a controller responds with a 422 status</title>
<updated>2018-06-06T20:16:15+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2018-06-06T07:47:53+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=5d3abdf9a7c0260c708a46e2fd232b0490940f80'/>
<id>5d3abdf9a7c0260c708a46e2fd232b0490940f80</id>
<content type='text'>
We have a number of import errors occurring with 422 errors, and
it's hard to determine why they are happening. This change will
surface the errors in the log lines.

Relates to #47365
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We have a number of import errors occurring with 422 errors, and
it's hard to determine why they are happening. This change will
surface the errors in the log lines.

Relates to #47365
</pre>
</div>
</content>
</entry>
<entry>
<title>Bump lograge to 0.10.0 and remove monkey patch</title>
<updated>2018-04-23T20:00:02+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2018-04-23T19:57:40+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=69246ec8d2bcbffeeb5265d16be85a158f767a4e'/>
<id>69246ec8d2bcbffeeb5265d16be85a158f767a4e</id>
<content type='text'>
lograge 0.10.0 contains the `Location` query string fix in
https://github.com/roidrage/lograge/pull/241 among other minor changes:
https://github.com/roidrage/lograge/blob/master/CHANGELOG.md
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
lograge 0.10.0 contains the `Location` query string fix in
https://github.com/roidrage/lograge/pull/241 among other minor changes:
https://github.com/roidrage/lograge/blob/master/CHANGELOG.md
</pre>
</div>
</content>
</entry>
</feed>
