<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/config.ru, branch implement-feature-flags-plugin</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Clean Sidekiq metrics from multiproc dir on start</title>
<updated>2019-08-19T12:52:07+00:00</updated>
<author>
<name>Aleksei Lipniagov</name>
<email>alipniagov@gitlab.com</email>
</author>
<published>2019-08-19T12:52:07+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=dcfaf49550866a291c316f2901e4274d587e7d37'/>
<id>dcfaf49550866a291c316f2901e4274d587e7d37</id>
<content type='text'>
After moving the multiproc dir cleanup into `config.ru`:`warmup`, we
stopped cleaning Sidekiq metrics dir which is not correct.
This MR intended to fix that. More details:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31668
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
After moving the multiproc dir cleanup into `config.ru`:`warmup`, we
stopped cleaning Sidekiq metrics dir which is not correct.
This MR intended to fix that. More details:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31668
</pre>
</div>
</content>
</entry>
<entry>
<title>Clean prometheus dir only for master process</title>
<updated>2019-08-12T10:52:15+00:00</updated>
<author>
<name>Aleksei Lipniagov</name>
<email>alipniagov@gitlab.com</email>
</author>
<published>2019-08-12T09:49:01+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=c90effd84a2ed93c356b25f80b708f4df33472b0'/>
<id>c90effd84a2ed93c356b25f80b708f4df33472b0</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove extra blank line</title>
<updated>2019-08-12T10:52:15+00:00</updated>
<author>
<name>Aleksei Lipniagov</name>
<email>alipniagov@gitlab.com</email>
</author>
<published>2019-08-09T13:25:03+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=debc497dbb97f2850f559b7053151419c72c4781'/>
<id>debc497dbb97f2850f559b7053151419c72c4781</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix metric files being wiped after the app starts</title>
<updated>2019-08-12T10:52:15+00:00</updated>
<author>
<name>Aleksei Lipniagov</name>
<email>alipniagov@gitlab.com</email>
</author>
<published>2019-08-09T11:56:22+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=3f9815865c38aeec0007b4ef3c636be51967b661'/>
<id>3f9815865c38aeec0007b4ef3c636be51967b661</id>
<content type='text'>
When we hit our app with the initial request, in `warmup`,
some metrics already being created as well as corresponding files.
If we do `multiproc_file_dir` cleanup after that, we delete the files
from the dir while keeping them in memory which leads to the incorrect
behavior: the metric is being updated in in-memory, while is not present
in the db, not sent to Prometheus as the result.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When we hit our app with the initial request, in `warmup`,
some metrics already being created as well as corresponding files.
If we do `multiproc_file_dir` cleanup after that, we delete the files
from the dir while keeping them in memory which leads to the incorrect
behavior: the metric is being updated in in-memory, while is not present
in the db, not sent to Prometheus as the result.
</pre>
</div>
</content>
</entry>
<entry>
<title>Bump rack gem to 2.0.7</title>
<updated>2019-04-05T05:01:01+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2019-04-05T04:56:52+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=617dcfd5e4fef79feeaf24fde3e9478ca598bd69'/>
<id>617dcfd5e4fef79feeaf24fde3e9478ca598bd69</id>
<content type='text'>
This update has two important fixes:

1. It reverts the monkey patch introduced in
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/23385 since
https://github.com/rack/rack/pull/1201 is now part of the release.

2. Preserve forwarded IP address for trusted proxy chains
(https://github.com/rack/rack/pull/1343).
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This update has two important fixes:

1. It reverts the monkey patch introduced in
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/23385 since
https://github.com/rack/rack/pull/1201 is now part of the release.

2. Preserve forwarded IP address for trusted proxy chains
(https://github.com/rack/rack/pull/1343).
</pre>
</div>
</content>
</entry>
<entry>
<title>Enable the Layout/ExtraSpacing cop</title>
<updated>2019-01-24T12:05:45+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2019-01-16T12:09:29+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=3a2abc1d50b419a353edb7f7cf68f3894dfdeeef'/>
<id>3a2abc1d50b419a353edb7f7cf68f3894dfdeeef</id>
<content type='text'>
Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Add monkey patch to unicorn to fix eof? problem</title>
<updated>2018-11-28T16:34:32+00:00</updated>
<author>
<name>Kamil Trzciński</name>
<email>ayufan@ayufan.eu</email>
</author>
<published>2018-11-27T16:12:49+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=dc962788fa7589e948479f609a6feb29404d217b'/>
<id>dc962788fa7589e948479f609a6feb29404d217b</id>
<content type='text'>
Rack with Unicorn is unable to handle chunked requests due to private `eof?` method.
This exposes `eof?` not changing `rack` behavior.

Issue: https://gitlab.com/gitlab-org/gitlab-ee/issues/8539
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Rack with Unicorn is unable to handle chunked requests due to private `eof?` method.
This exposes `eof?` not changing `rack` behavior.

Issue: https://gitlab.com/gitlab-org/gitlab-ee/issues/8539
</pre>
</div>
</content>
</entry>
<entry>
<title>Increase the memory limits used in the unicorn killer</title>
<updated>2018-03-23T00:21:10+00:00</updated>
<author>
<name>DJ Mountney</name>
<email>david@twkie.net</email>
</author>
<published>2018-03-22T23:49:13+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=f4218f277adf59a76da43ca534037feff024614d'/>
<id>f4218f277adf59a76da43ca534037feff024614d</id>
<content type='text'>
These limits were updated in our docs, and in omnibus some time ago. But
the defaults in the source-install were missed.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
These limits were updated in our docs, and in omnibus some time ago. But
the defaults in the source-install were missed.
</pre>
</div>
</content>
</entry>
<entry>
<title>Release the entire env</title>
<updated>2018-02-07T14:56:07+00:00</updated>
<author>
<name>Lin Jen-Shin</name>
<email>godfat@godfat.org</email>
</author>
<published>2018-02-07T14:44:05+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=31f1ec59a7cf7517cd5935ef3af540aceba07bb3'/>
<id>31f1ec59a7cf7517cd5935ef3af540aceba07bb3</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Try not to hold env and release the controller</title>
<updated>2018-02-07T14:45:02+00:00</updated>
<author>
<name>Lin Jen-Shin</name>
<email>godfat@godfat.org</email>
</author>
<published>2018-02-01T10:48:32+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d4d564c8e7d2cbc3e6742475a793ba0f630167e3'/>
<id>d4d564c8e7d2cbc3e6742475a793ba0f630167e3</id>
<content type='text'>
after the request. This way, we could release the
project referred from the controller, which potentially
referred a repository which potentially allocated a lot of
memories.

Before this change, we could hold the last request data
and cannot release the memory. After this change, the
largest request data should be able to be collected from GC.

This might not impact the instances having heavy load,
as the last request should be changing all the time,
and GC won't kick in for each request anyway.

However it could still potentially allow us to free more
memories for each GC runs, because now we could free one
more request anyway.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
after the request. This way, we could release the
project referred from the controller, which potentially
referred a repository which potentially allocated a lot of
memories.

Before this change, we could hold the last request data
and cannot release the memory. After this change, the
largest request data should be able to be collected from GC.

This might not impact the instances having heavy load,
as the last request should be changing all the time,
and GC won't kick in for each request anyway.

However it could still potentially allow us to free more
memories for each GC runs, because now we could free one
more request anyway.
</pre>
</div>
</content>
</entry>
</feed>
