delta/gitlab/gitlab-ce.git/app, branch temporary-skip-diff-specs

Merge branch 'akismet-submittable' into 'master'

2016-08-15T22:59:47+00:00


Submit to Akismet Part 1 (Issues)

Related to #5932 #5573 gitlab-com/infrastructure#14

See merge request !5538

Further refactor and syntax fixes.

2016-08-15T22:20:57+00:00

Merge branch 'frank-west-iii/gitlab-ce-fwiii-5857-web-editor-overwrites-commits'

2016-08-15T21:54:49+00:00

Restore `Largest repository` sort option on admin projects page

2016-08-15T21:01:23+00:00

Merge branch 'feature/test-coverage-badge' into 'master'

2016-08-15T19:48:05+00:00


Add test coverage badge

## What does this MR do?

This MR adds a test coverage badge.

Test coverage badge will be a SVG image you can embed in README.md or on your website that will be created dynamically by GitLab, to show information about how much of the code is being covered by tests. In addition to coverage-regexp feature we currently have, this feature will make it possible to use the coverage data obtained from the build log. We will support both - pipeline coverage, or test coverage for particular job in the pipeline. 

![coverage_badges](/uploads/dfa307339eb58c8138e551b42c0d8756/coverage_badges.png)

![coverage_badge](/uploads/30406e4bdcf979b2900ffe8996728c97/coverage_badge.png)

## What are the relevant issue numbers?

Closes #3714

## Screenshots (if relevant)

## Does this MR meet the acceptance criteria?

- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] ~~API support added~~
- Tests
  - [x] Added for this feature/bug
  - [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

See merge request !5708

Refactored AkismetHelper into AkismetService and cleaned up `Spammable`

2016-08-15T18:18:15+00:00

- Refactored SpamCheckService into SpamService

Allow `Issue` to be submitted as spam

2016-08-15T18:18:15+00:00

- Added controller actions as reusable concerns
- Added controller tests

Allow `SpamLog` to be submitted as ham

2016-08-15T18:18:15+00:00

- Added `submitted_as_ham` to `SpamLog` to mark which logs have been submitted to Akismet.
- Added routes and controller action.

Refactored spam related code even further

2016-08-15T18:18:15+00:00

- Removed unnecessary column from `SpamLog`
- Moved creation of SpamLogs out of its own service and into SpamCheckService
- Simplified code in SpamCheckService.
- Moved move spam related code into Spammable concern

Complete refactor of the `Spammable` concern and tests:

2016-08-15T18:18:15+00:00

- Merged `AkismetSubmittable` into `Spammable`
- Clean up `SpamCheckService`
- Added tests for `Spammable`
- Added submit (ham or spam) options to `AkismetHelper`