delta/gitlab/gitlab-ce.git/app/workers, branch scroll-code-blocks

Fix bug where destroying a namespace would not always destroy projects

2016-08-11T22:36:35+00:00

There is a race condition in DestroyGroupService now that projects are deleted asynchronously:

1. User attempts to delete group
2. DestroyGroupService iterates through all projects and schedules a Sidekiq job to delete each Project
3. DestroyGroupService destroys the Group, leaving all its projects without a namespace
4. Projects::DestroyService runs later but the can?(current_user,
   :remove_project) is `false` because the user no longer has permission to
   destroy projects with no namespace.
5. This leaves the project in pending_delete state with no namespace/group.

Projects without a namespace or group also adds another problem: it's not possible to destroy the container
registry tags, since container_registry_path_with_namespace is the wrong value.

The fix is to destroy the group asynchronously and to run execute directly on Projects::DestroyService.

Closes #17893

Merge branch 'decode-log-postreceive-args' into 'master'

2016-08-08T17:39:48+00:00


Log base64-decoded PostReceive arguments

The change to base64-encoding the third argument to PostReceive in
gitlab-shell made our Sidekiq ArgumentsLogger a little less useful.
This change adds decoded data to the log statement.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/20381


See merge request !5547

Log base64-decoded PostReceive arguments

2016-08-05T13:00:12+00:00

The change to base64-encoding the third argument to PostReceive in
gitlab-shell made our Sidekiq ArgumentsLogger a little less useful.
This change adds a log statement for the decoded data.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/20381

Merge branch 'fix/ha-mode-import-issue' into 'master'

2016-08-04T12:21:53+00:00


Fix Import/Export not working in HA mode

Use a shared path instead of `Tempfile` default `/tmp` so the import file is accessible by any GitLab instance.

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/20506

- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- Tests
  - [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

See merge request !5618

using shared path for project import uploads and refactored gitlab remove export worker

2016-08-04T10:51:55+00:00

Fix skip_repo parameter being ignored when destroying a namespace

2016-08-04T00:07:38+00:00

When destroying a namespace, the `skip_repo` parameter is supposed
to prevent the repository directory from being destroyed and allow
the namespace after_destroy hook to run. If the namespace fails
to be deleted for some reason, we could be left with repositories
that are deleted with existing projects.

Use commit deltas when counting files in IrkerWorker

2016-08-03T17:26:10+00:00

switch from diff_file_collection to diffs

2016-08-03T05:00:20+00:00

So we have raw_diffs too

Introduce Compare model in the codebase.

2016-08-03T05:00:20+00:00

This object will manage Gitlab::Git::Compare instances

Move to Gitlab::Diff::FileCollection

2016-08-03T05:00:20+00:00

Instead calling diff_collection.count use diff_collection.size which is cache on the diff_collection