<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/app/views, branch add-docker-debugging-docs</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Merge branch 'issue_20063_2' into 'master'</title>
<updated>2016-08-01T15:57:35+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2016-08-01T15:57:35+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=a0788fc34e868e8d4e378db4a181e109f22603cb'/>
<id>a0788fc34e868e8d4e378db4a181e109f22603cb</id>
<content type='text'>

Fix search results for notes without commits

part of #20063   

![deleted_commit](/uploads/5d99b9aedaf4f728425d95f7a9734d98/deleted_commit.png)

See merge request !5571</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Fix search results for notes without commits

part of #20063   

![deleted_commit](/uploads/5d99b9aedaf4f728425d95f7a9734d98/deleted_commit.png)

See merge request !5571</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'admin-builds' into 'master'</title>
<updated>2016-08-01T15:22:50+00:00</updated>
<author>
<name>Fatih Acet</name>
<email>acetfatih@gmail.com</email>
</author>
<published>2016-08-01T15:22:50+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=6c61f244dd8bc49b95780885e467aba64d28af8a'/>
<id>6c61f244dd8bc49b95780885e467aba64d28af8a</id>
<content type='text'>

Pipelines/Builds updates

## What does this MR do?
Adds branch/tag icons in admin view; increase min-width of builds tables

## What are the relevant issue numbers?
#20139

## Screenshots (if relevant)
Branch icons:    
![Screen_Shot_2016-07-27_at_1.29.57_PM](/uploads/2fceddfed5ed1a28d9b7d5e2427cba93/Screen_Shot_2016-07-27_at_1.29.57_PM.png)

Reduce `icon-container` width, before:
![Screen_Shot_2016-07-27_at_5.29.32_PM](/uploads/e3fe38edc262f6460572e20102ef9b6d/Screen_Shot_2016-07-27_at_5.29.32_PM.png)
Reduce `icon-container` width, after:
![Screen_Shot_2016-07-27_at_5.29.03_PM](/uploads/58b82e2c1491672c95dfe35911891891/Screen_Shot_2016-07-27_at_5.29.03_PM.png)

See merge request !5527</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Pipelines/Builds updates

## What does this MR do?
Adds branch/tag icons in admin view; increase min-width of builds tables

## What are the relevant issue numbers?
#20139

## Screenshots (if relevant)
Branch icons:    
![Screen_Shot_2016-07-27_at_1.29.57_PM](/uploads/2fceddfed5ed1a28d9b7d5e2427cba93/Screen_Shot_2016-07-27_at_1.29.57_PM.png)

Reduce `icon-container` width, before:
![Screen_Shot_2016-07-27_at_5.29.32_PM](/uploads/e3fe38edc262f6460572e20102ef9b6d/Screen_Shot_2016-07-27_at_5.29.32_PM.png)
Reduce `icon-container` width, after:
![Screen_Shot_2016-07-27_at_5.29.03_PM](/uploads/58b82e2c1491672c95dfe35911891891/Screen_Shot_2016-07-27_at_5.29.03_PM.png)

See merge request !5527</pre>
</div>
</content>
</entry>
<entry>
<title>Fix search results for notes without commits</title>
<updated>2016-08-01T14:53:12+00:00</updated>
<author>
<name>Felipe Artur</name>
<email>felipefac@gmail.com</email>
</author>
<published>2016-07-29T19:20:00+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=9845079950da010b8a4c07777f984aaf02642ad0'/>
<id>9845079950da010b8a4c07777f984aaf02642ad0</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch '14202-avoid-line-code-position-calculations' into 'master'</title>
<updated>2016-08-01T12:12:53+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2016-08-01T12:12:53+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=8c6b85eca5e19ca676eaef156876614526176821'/>
<id>8c6b85eca5e19ca676eaef156876614526176821</id>
<content type='text'>

Avoid line_code and position calculation on line partial for plain view

See merge request !5591</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Avoid line_code and position calculation on line partial for plain view

See merge request !5591</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch '15064_issuable_default_sort_order' into 'master'</title>
<updated>2016-08-01T12:02:47+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2016-08-01T12:02:47+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=e570b823c17ad405914b7b37e4df85c21edda2d1'/>
<id>e570b823c17ad405914b7b37e4df85c21edda2d1</id>
<content type='text'>

Sensible state specific default sort order for issues and merge requests

## What does this MR do?

It provides more sensible default sort order for issues and merge requests based on the following table:

    | type           | state  | default sort order |
    |----------------|--------|--------------------|
    | issues         | open   | last created       |
    | issues         | closed | last updated       |
    | issues         | all    | last created       |
    | merge requests | open   | last created       |
    | merge requests | merged | last updated       |
    | merge requests | closed | last updated       |
    | merge requests | all    | last created       |

## Are there points in the code the reviewer needs to double check?

All the bits where `id_desc` was changed to `created_desc`.
 
I hope it's okay, It makes more sense in my opinion.

## Why was this MR needed?

Prior to this MR the issues and merge request were sorted based on `id_desc` by default. 

This MR aims to make the interface more user-friendly by providing state specific sorting defaults most users would expect. 

## What are the relevant issue numbers?

See #15064 

See merge request !5453</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Sensible state specific default sort order for issues and merge requests

## What does this MR do?

It provides more sensible default sort order for issues and merge requests based on the following table:

    | type           | state  | default sort order |
    |----------------|--------|--------------------|
    | issues         | open   | last created       |
    | issues         | closed | last updated       |
    | issues         | all    | last created       |
    | merge requests | open   | last created       |
    | merge requests | merged | last updated       |
    | merge requests | closed | last updated       |
    | merge requests | all    | last created       |

## Are there points in the code the reviewer needs to double check?

All the bits where `id_desc` was changed to `created_desc`.
 
I hope it's okay, It makes more sense in my opinion.

## Why was this MR needed?

Prior to this MR the issues and merge request were sorted based on `id_desc` by default. 

This MR aims to make the interface more user-friendly by providing state specific sorting defaults most users would expect. 

## What are the relevant issue numbers?

See #15064 

See merge request !5453</pre>
</div>
</content>
</entry>
<entry>
<title>Avoid line_code and position calculation on line partial for plain view</title>
<updated>2016-08-01T10:38:16+00:00</updated>
<author>
<name>Paco Guzman</name>
<email>pacoguzmanp@gmail.com</email>
</author>
<published>2016-08-01T10:29:40+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=44eec823fb68238705eb932dd14aa211b730a316'/>
<id>44eec823fb68238705eb932dd14aa211b730a316</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>State specific default sort order for issuables</title>
<updated>2016-08-01T09:28:56+00:00</updated>
<author>
<name>zs</name>
<email>baloghzsof@gmail.com</email>
</author>
<published>2016-07-23T23:28:12+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=84a3225b0cde0ed2e343864583e7b79d7118e05c'/>
<id>84a3225b0cde0ed2e343864583e7b79d7118e05c</id>
<content type='text'>
Provide more sensible default sort order for issues and merge requests
based on the following table:

| type           | state  | default sort order |
|----------------|--------|--------------------|
| issues         | open   | last created       |
| issues         | closed | last updated       |
| issues         | all    | last created       |
| merge requests | open   | last created       |
| merge requests | merged | last updated       |
| merge requests | closed | last updated       |
| merge requests | all    | last created       |
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Provide more sensible default sort order for issues and merge requests
based on the following table:

| type           | state  | default sort order |
|----------------|--------|--------------------|
| issues         | open   | last created       |
| issues         | closed | last updated       |
| issues         | all    | last created       |
| merge requests | open   | last created       |
| merge requests | merged | last updated       |
| merge requests | closed | last updated       |
| merge requests | all    | last created       |
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'zj-env-external-url' into 'master'</title>
<updated>2016-08-01T09:04:09+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2016-08-01T09:04:09+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=f46d5f5813f5c0fe9c88435c8bda9af08447ef16'/>
<id>f46d5f5813f5c0fe9c88435c8bda9af08447ef16</id>
<content type='text'>

Add an URL field to Enviroments

## What does this MR do?

Adds a field to the `enviroments` table to expose later in other features. Now I see the task list below, I noticed I forgot some minor things, but Ill adress those after the first review. 

## Are there points in the code the reviewer needs to double check?

The field is a string on the database, thus limited to 255 chars, which seems more than enough.

## What are the relevant issue numbers?

Closes #19527

## Screenshots (if relevant)

![Screen_Shot_2016-07-25_at_15.22.16](/uploads/5c3f39466f8e2114195270006aed20c0/Screen_Shot_2016-07-25_at_15.22.16.png)![Screen_Shot_2016-07-25_at_15.22.53](/uploads/408cf86610137dd4a861d15dcd677a2c/Screen_Shot_2016-07-25_at_15.22.53.png)![Screen_Shot_2016-07-25_at_15.23.10](/uploads/927c506931f4e0338cdbbc58678bd308/Screen_Shot_2016-07-25_at_15.23.10.png)

## Does this MR meet the acceptance criteria?

- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [x] API support added
- Tests
  - [x] Added for this feature/bug
  - [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

See merge request !5469</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Add an URL field to Enviroments

## What does this MR do?

Adds a field to the `enviroments` table to expose later in other features. Now I see the task list below, I noticed I forgot some minor things, but Ill adress those after the first review. 

## Are there points in the code the reviewer needs to double check?

The field is a string on the database, thus limited to 255 chars, which seems more than enough.

## What are the relevant issue numbers?

Closes #19527

## Screenshots (if relevant)

![Screen_Shot_2016-07-25_at_15.22.16](/uploads/5c3f39466f8e2114195270006aed20c0/Screen_Shot_2016-07-25_at_15.22.16.png)![Screen_Shot_2016-07-25_at_15.22.53](/uploads/408cf86610137dd4a861d15dcd677a2c/Screen_Shot_2016-07-25_at_15.22.53.png)![Screen_Shot_2016-07-25_at_15.23.10](/uploads/927c506931f4e0338cdbbc58678bd308/Screen_Shot_2016-07-25_at_15.23.10.png)

## Does this MR meet the acceptance criteria?

- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [x] API support added
- Tests
  - [x] Added for this feature/bug
  - [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

See merge request !5469</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'new-issue-button-outline' into 'master'</title>
<updated>2016-08-01T08:11:47+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2016-08-01T08:11:47+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=7a0ed87b2ccde084f71e7466ded761e9ef19cb5a'/>
<id>7a0ed87b2ccde084f71e7466ded761e9ef19cb5a</id>
<content type='text'>

Make "New issue" button in Issue page less obtrusive

## What does this MR do?

Replace green background of "New issue" button on issue page by green border and text.

## Why was this MR needed?

Every issue page has two green buttons&amp;mdash;Comment and New Issue.

- New Issue is not directly content related and less likely to be used.
- [UI Guide] says

&gt; Use green or blue button for primary action. Primary button should be only one.

[UI Guide]: https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/ui_guide.md

## What are the relevant issue numbers?

fixes #20186

## Screenshots

### Before

![before](/uploads/53ab065edb87b3e3c2f25d828b2fcc42/before.png)

### After

![after](/uploads/a9b4254d563a93098fa2f1cecb78f96f/after.png)


See merge request !5457</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Make "New issue" button in Issue page less obtrusive

## What does this MR do?

Replace green background of "New issue" button on issue page by green border and text.

## Why was this MR needed?

Every issue page has two green buttons&amp;mdash;Comment and New Issue.

- New Issue is not directly content related and less likely to be used.
- [UI Guide] says

&gt; Use green or blue button for primary action. Primary button should be only one.

[UI Guide]: https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/ui_guide.md

## What are the relevant issue numbers?

fixes #20186

## Screenshots

### Before

![before](/uploads/53ab065edb87b3e3c2f25d828b2fcc42/before.png)

### After

![after](/uploads/a9b4254d563a93098fa2f1cecb78f96f/after.png)


See merge request !5457</pre>
</div>
</content>
</entry>
<entry>
<title>Improve diff performance by eliminating redundant checks for text blobs</title>
<updated>2016-07-30T04:06:50+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2016-07-30T04:04:04+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=48ff40a047103bf09d4ac53fdbc984d73bc464cb'/>
<id>48ff40a047103bf09d4ac53fdbc984d73bc464cb</id>
<content type='text'>
On a merge request with over 1000 changed files, there were redundant
calls to blob_text_viewable?, which incurred about 7% of the time.

Improves #14775
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
On a merge request with over 1000 changed files, there were redundant
calls to blob_text_viewable?, which incurred about 7% of the time.

Improves #14775
</pre>
</div>
</content>
</entry>
</feed>
