<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/app/views/notify/note_commit_email.text.erb, branch cache-refactor</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Address review comments</title>
<updated>2017-04-05T16:44:14+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@selenight.nl</email>
</author>
<published>2017-03-31T03:06:09+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=21e10888c3fc0fe545c0443cf0e23f593df847a4'/>
<id>21e10888c3fc0fe545c0443cf0e23f593df847a4</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Better notification emails for notes and (diff) discussions</title>
<updated>2017-04-05T16:44:14+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@selenight.nl</email>
</author>
<published>2017-03-16T00:14:58+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=f6f6aaf593dc40c79b8e3536f5e2821c96b9dcd3'/>
<id>f6f6aaf593dc40c79b8e3536f5e2821c96b9dcd3</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Tidy up text emails</title>
<updated>2016-11-28T19:40:48+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2016-11-17T22:22:39+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=854fbbfb07b84394cc952d0ae20b7f29957e6555'/>
<id>854fbbfb07b84394cc952d0ae20b7f29957e6555</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add keyword arguments to truncated_diff method</title>
<updated>2016-11-25T15:23:49+00:00</updated>
<author>
<name>hhoopes</name>
<email>heidih@gmail.com</email>
</author>
<published>2016-08-31T16:18:26+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=a761c59a6bfc4d66649910d01e4c8412bb0b40ec'/>
<id>a761c59a6bfc4d66649910d01e4c8412bb0b40ec</id>
<content type='text'>
* Added keyword arguments to truncated_diff_lines method to allow for using highlighting or not (html templates vs. text)
* Tweaked templates for consistency and format appropriateness
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* Added keyword arguments to truncated_diff_lines method to allow for using highlighting or not (html templates vs. text)
* Tweaked templates for consistency and format appropriateness
</pre>
</div>
</content>
</entry>
<entry>
<title>Change diff highlight/truncate for reusability</title>
<updated>2016-11-25T15:23:49+00:00</updated>
<author>
<name>hhoopes</name>
<email>heidih@gmail.com</email>
</author>
<published>2016-08-25T16:38:07+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=f928dba99b0550cefa7534d7fd5bd1ea16609274'/>
<id>f928dba99b0550cefa7534d7fd5bd1ea16609274</id>
<content type='text'>
Previously the `truncated_diff_lines` method for outputting a discussion diff took in already highlighted lines, which meant it wasn't reuseable for truncating ANY lines. In the way it was used, it also meant that for any email truncation, the whole diff was being highlighted before being truncated, meaning wasted time highlighting lines that wouldn't even be used (granted, they were being memoized, so perhaps this wasn't that great of an issue). I refactored truncation away from highlighting, in order to truncate formatted diffs for text templates in email, using `&gt;`s to designate each line, but otherwise retaining the parsing already done to create `diff_lines`.

Additionally, while notes on merge requests or commits had already been tested, there was no existing test for notes on a diff on an MR or commit. Added mailer tests for such, and a unit test for truncating diff lines.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Previously the `truncated_diff_lines` method for outputting a discussion diff took in already highlighted lines, which meant it wasn't reuseable for truncating ANY lines. In the way it was used, it also meant that for any email truncation, the whole diff was being highlighted before being truncated, meaning wasted time highlighting lines that wouldn't even be used (granted, they were being memoized, so perhaps this wasn't that great of an issue). I refactored truncation away from highlighting, in order to truncate formatted diffs for text templates in email, using `&gt;`s to designate each line, but otherwise retaining the parsing already done to create `diff_lines`.

Additionally, while notes on merge requests or commits had already been tested, there was no existing test for notes on a diff on an MR or commit. Added mailer tests for such, and a unit test for truncating diff lines.
</pre>
</div>
</content>
</entry>
<entry>
<title>Add new template to handle both commit &amp; mr notes</title>
<updated>2016-11-25T15:23:49+00:00</updated>
<author>
<name>hhoopes</name>
<email>heidih@gmail.com</email>
</author>
<published>2016-08-23T05:36:30+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=24070bac45134c915c13d3e94723a44f59ab4e3a'/>
<id>24070bac45134c915c13d3e94723a44f59ab4e3a</id>
<content type='text'>
Currently comments on commits and merge requests do not require merge request- or commit-specific information, but can use the same template. Rather than change the method which calls the template, I opted to keep the templates separate and create a new template to highlight their identicality, while preserving the option to distinguish them from each other in the future.

Also removed some of the inconsistencies between text and html email versions.

Still needed is a text-only version of git diffs and testing.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Currently comments on commits and merge requests do not require merge request- or commit-specific information, but can use the same template. Rather than change the method which calls the template, I opted to keep the templates separate and create a new template to highlight their identicality, while preserving the option to distinguish them from each other in the future.

Also removed some of the inconsistencies between text and html email versions.

Still needed is a text-only version of git diffs and testing.
</pre>
</div>
</content>
</entry>
<entry>
<title>Upgrade to Rails 4.1.9</title>
<updated>2015-02-14T18:09:23+00:00</updated>
<author>
<name>Vinnie Okada</name>
<email>vokada@mrvinn.com</email>
</author>
<published>2015-01-24T18:02:58+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=76aad9b76ed756ca9ba2cbcdb399c815e542b3ae'/>
<id>76aad9b76ed756ca9ba2cbcdb399c815e542b3ae</id>
<content type='text'>
Make the following changes to deal with new behavior in Rails 4.1.2:

* Use nested resources to avoid slashes in arguments to path helpers.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Make the following changes to deal with new behavior in Rails 4.1.2:

* Use nested resources to avoid slashes in arguments to path helpers.
</pre>
</div>
</content>
</entry>
<entry>
<title>added text-templates for mail notification</title>
<updated>2013-02-28T14:39:58+00:00</updated>
<author>
<name>Thomas Berger</name>
<email>tbe@boreus.de</email>
</author>
<published>2013-01-11T16:53:30+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=7ed08786542ebb62ca9d1f7943d148c0290032a7'/>
<id>7ed08786542ebb62ca9d1f7943d148c0290032a7</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
