<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/app/views/doorkeeper, branch diff-notes-refactor</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>HAMLLint: Fix `UnnecessaryInterpolation` offences</title>
<updated>2017-01-24T18:09:28+00:00</updated>
<author>
<name>Kushal Pandya</name>
<email>kushal@gitlab.com</email>
</author>
<published>2017-01-13T16:07:21+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=fa21471af626d1bfdb738e1a77e0d5b7fc3d85a3'/>
<id>fa21471af626d1bfdb738e1a77e0d5b7fc3d85a3</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>HAMLLint: Fix `SpaceInsideHashAttributes` offences</title>
<updated>2016-12-31T06:28:36+00:00</updated>
<author>
<name>Kushal Pandya</name>
<email>kushal@gitlab.com</email>
</author>
<published>2016-12-26T10:47:16+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=fb3e365412954b5d23a048518d70c15894cb9686'/>
<id>fb3e365412954b5d23a048518d70c15894cb9686</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>HAMLLint: Fix `TrailingWhitespace` offences</title>
<updated>2016-12-31T06:18:42+00:00</updated>
<author>
<name>Kushal Pandya</name>
<email>kushal@gitlab.com</email>
</author>
<published>2016-12-23T11:50:31+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=97f3c8f3c9480f92375aa3fbb09138bdf43792c6'/>
<id>97f3c8f3c9480f92375aa3fbb09138bdf43792c6</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>HAMLLint: Fix `ImplicitDiv` offences</title>
<updated>2016-12-31T06:13:08+00:00</updated>
<author>
<name>Kushal Pandya</name>
<email>kushal@gitlab.com</email>
</author>
<published>2016-12-23T09:37:12+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=dd5ffd9ca648dba4c0b58be2172cd14c428fa654'/>
<id>dd5ffd9ca648dba4c0b58be2172cd14c428fa654</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>View-related (and other minor) changes to !5951 based on @rymai's review.</title>
<updated>2016-12-16T10:59:32+00:00</updated>
<author>
<name>Timothy Andrew</name>
<email>mail@timothyandrew.net</email>
</author>
<published>2016-12-05T04:19:51+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=f706a973c26f9de9a1f1599d532b33e9e66a80bb'/>
<id>f706a973c26f9de9a1f1599d532b33e9e66a80bb</id>
<content type='text'>
- The `scopes_form` partial can be used in the `admin/applications` view
  as well

- Don't allow partials to access instance variables directly. Instead, pass
  in the instance variables as local variables, and use `local_assigns.fetch`
  to assert that the variables are passed in as expected.

- Change a few instances of `render :partial` to `render`

- Remove an instance of `required: false` in a view, since this is the default

- Inline many instances of a local variable (`ip = 'ip'`) in `auth_spec`
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- The `scopes_form` partial can be used in the `admin/applications` view
  as well

- Don't allow partials to access instance variables directly. Instead, pass
  in the instance variables as local variables, and use `local_assigns.fetch`
  to assert that the variables are passed in as expected.

- Change a few instances of `render :partial` to `render`

- Remove an instance of `required: false` in a view, since this is the default

- Inline many instances of a local variable (`ip = 'ip'`) in `auth_spec`
</pre>
</div>
</content>
</entry>
<entry>
<title>Move the scopes form/list view into a partial.</title>
<updated>2016-12-16T10:59:31+00:00</updated>
<author>
<name>Timothy Andrew</name>
<email>mail@timothyandrew.net</email>
</author>
<published>2016-11-24T08:52:03+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=990ae6b8e5f2797a6c168f9c16a725a159570058'/>
<id>990ae6b8e5f2797a6c168f9c16a725a159570058</id>
<content type='text'>
- The list of scopes that's displayed while creating a personal access
  token is identical to the list that's displayed while creating an OAuth
  application. Extract these into a partial.

- The list of scopes that's displayed while in the show page for an OAuth token
  in the profile settings and admin settings are identical. Extract these into
  a partial.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- The list of scopes that's displayed while creating a personal access
  token is identical to the list that's displayed while creating an OAuth
  application. Extract these into a partial.

- The list of scopes that's displayed while in the show page for an OAuth token
  in the profile settings and admin settings are identical. Extract these into
  a partial.
</pre>
</div>
</content>
</entry>
<entry>
<title>Implement minor changes from @dbalexandre's review.</title>
<updated>2016-12-16T10:59:31+00:00</updated>
<author>
<name>Timothy Andrew</name>
<email>mail@timothyandrew.net</email>
</author>
<published>2016-11-24T07:37:22+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=4d6da770de94f4bf140507cdf43461b67269ce28'/>
<id>4d6da770de94f4bf140507cdf43461b67269ce28</id>
<content type='text'>
- Mainly whitespace changes.

- Require the migration adding the `scope` column to the
  `personal_access_tokens` table to have downtime, since API calls will
  fail if the new code is in place, but the migration hasn't run.

- Minor refactoring - load `@scopes` in a `before_action`, since we're
  doing it in three different places.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- Mainly whitespace changes.

- Require the migration adding the `scope` column to the
  `personal_access_tokens` table to have downtime, since API calls will
  fail if the new code is in place, but the migration hasn't run.

- Minor refactoring - load `@scopes` in a `before_action`, since we're
  doing it in three different places.
</pre>
</div>
</content>
</entry>
<entry>
<title>Allow creating personal access tokens / OAuth applications with scopes.</title>
<updated>2016-12-16T09:38:10+00:00</updated>
<author>
<name>Timothy Andrew</name>
<email>mail@timothyandrew.net</email>
</author>
<published>2016-11-22T08:57:31+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=6c809dfae84e702f7a49d3fac5725745264e0ff9'/>
<id>6c809dfae84e702f7a49d3fac5725745264e0ff9</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Removes class 'btn-link' of Revoke button</title>
<updated>2016-09-26T11:13:45+00:00</updated>
<author>
<name>Filipa Lacerda</name>
<email>filipa@gitlab.com</email>
</author>
<published>2016-09-26T11:13:45+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=b24d053493ec2faf4053268beeb72862a024476c'/>
<id>b24d053493ec2faf4053268beeb72862a024476c</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix grammar and wording in text on various pages.</title>
<updated>2016-05-22T16:41:30+00:00</updated>
<author>
<name>Connor Shea</name>
<email>connor.james.shea@gmail.com</email>
</author>
<published>2016-05-22T16:41:30+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=1a85f80b789ec966742fd58f21e8c347d2ac0a06'/>
<id>1a85f80b789ec966742fd58f21e8c347d2ac0a06</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
