delta/gitlab/gitlab-ce.git/app/validators, branch remove-trigger-variables-related-code gitlab.com: gitlab-org/gitlab-ce.git Fix Bitbucket import 2019-03-14T10:05:17+00:00 Francisco Javier López fjlopez@gitlab.com 2019-03-14T10:05:17+00:00 150f7c1e9c8d4a9d8134664d00a6385ac21a1939 In https://gitlab.com/gitlab-org/gitlab-ce/commit/ebf16ada856efb85424a98848c141f21e609886a we introduced a SHA validator, to ensure that the data provided in merge request diffs, was legit. Nevertheless, the validator assumed that the SHA should be 40 chars long. When we import a project from BitBucket, the retrieved SHA is shorter (12 chars long). Therefore, this validator prevented to create a valid MergeRequestDiff for ever MergeRequest (triggering an exception). 
In https://gitlab.com/gitlab-org/gitlab-ce/commit/ebf16ada856efb85424a98848c141f21e609886a
we introduced a SHA validator, to ensure that the data provided in
merge request diffs, was legit. Nevertheless, the validator
assumed that the SHA should be 40 chars long.

When we import a project from BitBucket, the retrieved SHA is
shorter (12 chars long). Therefore, this validator prevented to
create a valid MergeRequestDiff for ever MergeRequest (triggering
an exception).
Merge branch 'fix/email_validator' into 'master' 2019-03-09T00:05:59+00:00 Stan Hu stanhu@gmail.com 2019-03-09T00:05:59+00:00 6908c5f70eb4d5d7e8ef28b43d73d71da9b2a0c3 Align EmailValidator to validate_email gem implementation. Closes #57352 See merge request gitlab-org/gitlab-ce!24971 
Align EmailValidator to validate_email gem implementation.

Closes #57352

See merge request gitlab-org/gitlab-ce!24971
 Align EmailValidator to validate_email gem implementation. 2019-03-05T19:56:01+00:00 Horatiu Eugen Vlad horatiu@vlad.eu 2018-10-26T22:39:00+00:00 c8c0ea6c52d46ce63d838d1e739355d4deace434 Renamed EmailValidator to DeviseEmailValidator to avoid 'email:' naming collision with ActiveModel::Validations::EmailValidator in 'validates' statement. Make use of the options attribute of the parent class ActiveModel::EachValidator. Add more options: regex. 
Renamed EmailValidator to DeviseEmailValidator to avoid 'email:' naming collision with ActiveModel::Validations::EmailValidator in 'validates' statement.
Make use of the options attribute of the parent class ActiveModel::EachValidator.
Add more options: regex.
Arbitrary file read via MergeRequestDiff 2019-03-04T18:36:34+00:00 Francisco Javier López fjlopez@gitlab.com 2019-03-04T18:36:34+00:00 ebf16ada856efb85424a98848c141f21e609886a 






Comment why we can't use Gitlab::CurrentSettings
2019-02-19T21:50:58+00:00

Thong Kuah
tkuah@gitlab.com

2019-02-19T21:50:58+00:00

89f7bac3ba980019e6a75f869dec69da5d7a69ab

See https://gitlab.com/gitlab-org/gitlab-ee/issues/9833





See https://gitlab.com/gitlab-org/gitlab-ee/issues/9833







Revert "Merge branch 'use_gitlab_current_settings' into 'master'"
2019-02-19T12:58:05+00:00

Bob Van Landuyt
bob@gitlab.com

2019-02-19T12:58:05+00:00

7e55a227a53feaf4c8af9585a395f189402fcbc3

This reverts merge request !25370




This reverts merge request !25370






Use Gitlab::CurrentSettings in UrlValidator
2019-02-19T09:04:08+00:00

Thong Kuah
tkuah@gitlab.com

2019-02-18T21:55:13+00:00

8a1b6041c8af7007c80de87221e20512810be26d

Gitlab::CurrentSettings will create ApplicationSetting.current if not
present which means we don't have to use `&.`. We can also more easily
use stub_application_setting in specs





Gitlab::CurrentSettings will create ApplicationSetting.current if not
present which means we don't have to use `&.`. We can also more easily
use stub_application_setting in specs







Add table and model for error tracking settings
2019-01-07T17:55:21+00:00

Reuben Pereira
rpereira@gitlab.com

2019-01-07T17:55:21+00:00

f40b5860d76a8ea5d964260834a6e83516b0f1fd












Merge branch 'ce-jej/group-saml-sso-button-link-description' into 'master'
2018-12-08T03:02:18+00:00

Clement Ho
clemmakesapps@gmail.com

2018-12-08T03:02:18+00:00

a89b5269502a0250c7507f3bb1350a7ba602822b

[CE] Backport SAML unlink changes: UrlBlocker#ascii_only

See merge request gitlab-org/gitlab-ce!23627




[CE] Backport SAML unlink changes: UrlBlocker#ascii_only

See merge request gitlab-org/gitlab-ce!23627






Allow URLs to be validated as ascii_only
2018-12-06T15:18:18+00:00

James Edwards-Jones
jedwardsjones@gitlab.com

2018-12-05T20:14:09+00:00

72c00594070dfd1a778c2e03ff400b478e6c3774

Restricts unicode characters and IDNA deviations
which could be used in a phishing attack





Restricts unicode characters and IDNA deviations
which could be used in a phishing attack