delta/gitlab/gitlab-ce.git/app/uploaders, branch gitlab-selenium-proxy-visual-regression-testing

Merge branch 'feature/customizable-favicon' into 'master'

2018-06-07T16:54:41+00:00

Customizable favicon

Closes #15661

See merge request gitlab-org/gitlab-ce!14497

hint the allowed image formats on favicon upload

2018-06-06T09:28:13+00:00

allow only png, ico for favicon uploads

2018-06-05T14:20:24+00:00

the related omnibus graphicsmagick package only supports those formats.

see https://gitlab.com/gitlab-org/omnibus-gitlab/merge_requests/1975

create favicon overlay on the client

2018-06-05T14:20:21+00:00

the initial reason for this change was that graphicsmagick does not
support writing to ico files. this fact lead to a chain of changes:

1. use png instead of ico (browser support is good enough)
2. render the overlays on the client using the canvas API. this way we
   only need to store the original favion and generate the overlay versions
   dynamically.
   this change also enables (next step) to simplify the handling of the
   stock favicons as well, as we don't need to generate all the versions
   upfront.

call Gitlab::Favicon.status in serializer

2018-06-05T14:20:21+00:00

this ways we can keep the `lib/gitlab/ci/status/*` classes to return the
bare favicon name as it was before.

also the favicon uploader versions are now have the same names as the
stock favicons (+ `favicon_` prefix), which makes working with the
status names easier.

whitelist allowed file types for custom favicons

2018-06-05T14:20:20+00:00

send ico files with inline disposition

2018-06-05T14:20:20+00:00

sort status icon names by name

2018-06-05T14:20:19+00:00

fix carrierwave suffix for different format

2018-06-05T14:20:18+00:00

when versions have a different file format from the original file
carrierwave constructs a wrong url (with the original file suffix).

favicon uploader generating ci status favicons

2018-06-05T14:20:06+00:00