<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/app/services/todos/destroy, branch document-lambda-deploy</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Delete unauthorized Todos when project is private</title>
<updated>2019-06-05T13:51:52+00:00</updated>
<author>
<name>Felipe Artur</name>
<email>felipefac@gmail.com</email>
</author>
<published>2019-05-21T19:20:27+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=be339468192c656bf9de0bb77d7e487f338902bf'/>
<id>be339468192c656bf9de0bb77d7e487f338902bf</id>
<content type='text'>
Delete Todos for guest users when project visibility
level is updated to private.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Delete Todos for guest users when project visibility
level is updated to private.
</pre>
</div>
</content>
</entry>
<entry>
<title>Stop serialising project when removing todos</title>
<updated>2019-04-29T14:31:29+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2019-04-29T13:42:16+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=9bc3dfea4f365d5dc0b93a5fef0418dfad971361'/>
<id>9bc3dfea4f365d5dc0b93a5fef0418dfad971361</id>
<content type='text'>
`Todos::Destroy::EntityLeaveService#project_ids` was returning
ActiveRecord objects with IDs, not simply IDs. That means we were
serialising more than we needed to in Sidekiq.

We can simply rename this method to `#projects` as this class doesn't
use any of the superclass methods that would use `#project_ids`.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
`Todos::Destroy::EntityLeaveService#project_ids` was returning
ActiveRecord objects with IDs, not simply IDs. That means we were
serialising more than we needed to in Sidekiq.

We can simply rename this method to `#projects` as this class doesn't
use any of the superclass methods that would use `#project_ids`.
</pre>
</div>
</content>
</entry>
<entry>
<title>Rails5: Passing a class as a value in an Active Record query is deprecated</title>
<updated>2018-11-17T15:14:36+00:00</updated>
<author>
<name>Jasper Maes</name>
<email>jaspermaes.jm@gmail.com</email>
</author>
<published>2018-11-17T15:14:36+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=5d5481519deb304243ed1c09171ccf8a45052d46'/>
<id>5d5481519deb304243ed1c09171ccf8a45052d46</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Disable existing offenses for the CodeReuse cops</title>
<updated>2018-09-11T15:32:00+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2018-08-27T15:31:01+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=2039c8280db1646845c33d6c5a74e5f23ca6f4de'/>
<id>2039c8280db1646845c33d6c5a74e5f23ca6f4de</id>
<content type='text'>
This whitelists all existing offenses for the various CodeReuse cops, of
which most are triggered by the CodeReuse/ActiveRecord cop.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This whitelists all existing offenses for the various CodeReuse cops, of
which most are triggered by the CodeReuse/ActiveRecord cop.
</pre>
</div>
</content>
</entry>
<entry>
<title>Enable frozen string in vestigial app files</title>
<updated>2018-08-12T18:07:35+00:00</updated>
<author>
<name>gfyoung</name>
<email>gfyoung17@gmail.com</email>
</author>
<published>2018-08-11T07:00:39+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=2ad1688be9bfed122e61d4e10ed64faf8395c26e'/>
<id>2ad1688be9bfed122e61d4e10ed64faf8395c26e</id>
<content type='text'>
Partially addresses #47424.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Partially addresses #47424.
</pre>
</div>
</content>
</entry>
<entry>
<title>Add changes from the EE</title>
<updated>2018-08-06T12:18:21+00:00</updated>
<author>
<name>Jarka Kadlecová</name>
<email>jarka@gitlab.com</email>
</author>
<published>2018-08-06T09:05:44+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=6dc7490789237a84b66baaaf4c6deea5ec3bf2de'/>
<id>6dc7490789237a84b66baaaf4c6deea5ec3bf2de</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix removing todos for users without access</title>
<updated>2018-08-06T08:42:51+00:00</updated>
<author>
<name>Jarka Kadlecová</name>
<email>jarka@gitlab.com</email>
</author>
<published>2018-08-06T08:42:51+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=02b077925dedca390be3e8c4c7960d89ea8d4c6e'/>
<id>02b077925dedca390be3e8c4c7960d89ea8d4c6e</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove group todos when a users looses access</title>
<updated>2018-08-02T14:16:58+00:00</updated>
<author>
<name>Jarka Kadlecová</name>
<email>jarka@gitlab.com</email>
</author>
<published>2018-08-02T14:16:58+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=4d4b8f8bbedbfadb49e12df2b123b3528cda4c08'/>
<id>4d4b8f8bbedbfadb49e12df2b123b3528cda4c08</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove todos when project feature visibility changes</title>
<updated>2018-07-31T10:32:08+00:00</updated>
<author>
<name>Jarka Kadlecová</name>
<email>jarka@gitlab.com</email>
</author>
<published>2018-07-27T09:28:17+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=bdc8396e25e6eba6edcf2896daa49bb49695ef8c'/>
<id>bdc8396e25e6eba6edcf2896daa49bb49695ef8c</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix removing todos for confidential issues</title>
<updated>2018-07-30T11:29:18+00:00</updated>
<author>
<name>Jarka Kadlecová</name>
<email>jarka@gitlab.com</email>
</author>
<published>2018-07-26T14:53:50+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=7934b91311a70d994c6700201979c6673160fd01'/>
<id>7934b91311a70d994c6700201979c6673160fd01</id>
<content type='text'>
- dont remove todos for authos &amp; assignees
- remove todos for project guests
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- dont remove todos for authos &amp; assignees
- remove todos for project guests
</pre>
</div>
</content>
</entry>
</feed>
