<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/app/services/test_hooks, branch 51470-webide-default-commit</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Added list_pages method to avoid loading all wiki pages content</title>
<updated>2019-04-25T04:19:07+00:00</updated>
<author>
<name>Francisco Javier López</name>
<email>fjlopez@gitlab.com</email>
</author>
<published>2019-04-25T04:19:07+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=dde69bfb2a595956c54ddb9c776759c11b3f2a3b'/>
<id>dde69bfb2a595956c54ddb9c776759c11b3f2a3b</id>
<content type='text'>
Inside a wiki, when we show the sidebar or browse to the `pages`,
all page contents are retrieved from Gitaly and that is a waste
of resources, since no content from that pages are going to be
showed.

This MR introduces the method `ProjectWiki#list_pages`,
which uses new wiki_list_pages RPC call to retrieve
pages without content

Also in the `WikisController` we're using the method to show
pages in the sidebar and also on the `pages` page.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Inside a wiki, when we show the sidebar or browse to the `pages`,
all page contents are retrieved from Gitaly and that is a waste
of resources, since no content from that pages are going to be
showed.

This MR introduces the method `ProjectWiki#list_pages`,
which uses new wiki_list_pages RPC call to retrieve
pages without content

Also in the `WikisController` we're using the method to show
pages in the sidebar and also on the `pages` page.
</pre>
</div>
</content>
</entry>
<entry>
<title>Externalize strings detected by rubocop-i18n</title>
<updated>2019-04-15T12:25:48+00:00</updated>
<author>
<name>Martin Wortschack</name>
<email>mwortschack@gitlab.com</email>
</author>
<published>2019-04-15T12:25:48+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=5770b6544d3476e27d77a0ab11f162c941aa0cae'/>
<id>5770b6544d3476e27d77a0ab11f162c941aa0cae</id>
<content type='text'>
- Externalize strings in milestones_helper
- Externalize strings in app/services
- Update PO file
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- Externalize strings in milestones_helper
- Externalize strings in app/services
- Update PO file
</pre>
</div>
</content>
</entry>
<entry>
<title>Rename project's pipelines relation</title>
<updated>2018-12-05T14:39:15+00:00</updated>
<author>
<name>Francisco Javier López</name>
<email>fjlopez@gitlab.com</email>
</author>
<published>2018-12-05T14:39:15+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=a6778fc647d83c8fbdca69e1bb2d38b490853ba8'/>
<id>a6778fc647d83c8fbdca69e1bb2d38b490853ba8</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Enable more frozen string in app/services/**/*.rb</title>
<updated>2018-07-18T21:07:50+00:00</updated>
<author>
<name>gfyoung</name>
<email>gfyoung17@gmail.com</email>
</author>
<published>2018-07-18T16:03:33+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=0cf45debb45cc7a412fd1b290c215280aaca6a45'/>
<id>0cf45debb45cc7a412fd1b290c215280aaca6a45</id>
<content type='text'>
Partially addresses #47424.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Partially addresses #47424.
</pre>
</div>
</content>
</entry>
<entry>
<title>Backport changes in app/services/test_hooks/project_service.rb</title>
<updated>2018-06-03T00:44:31+00:00</updated>
<author>
<name>Mario de la Ossa</name>
<email>mariodelaossa@gmail.com</email>
</author>
<published>2018-05-22T02:24:37+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=caadfcdee31237bbfbcfb304346fc4a5994295dd'/>
<id>caadfcdee31237bbfbcfb304346fc4a5994295dd</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Resolve "Make a Rubocop that forbids returning from a block"</title>
<updated>2018-04-18T09:19:40+00:00</updated>
<author>
<name>🙈  jacopo beschi 🙉</name>
<email>intrip@gmail.com</email>
</author>
<published>2018-04-18T09:19:40+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=c6b1043e9d1b7fe9912c330b6e7d4342f2a9694e'/>
<id>c6b1043e9d1b7fe9912c330b6e7d4342f2a9694e</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>use class reader instead of dynamic constant</title>
<updated>2018-01-17T08:55:00+00:00</updated>
<author>
<name>Alexis Reigel</name>
<email>alexis.reigel.ext@siemens.com</email>
</author>
<published>2017-12-08T13:17:15+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=faadd9e0e4edcb332b41aceabd6c03a796e11978'/>
<id>faadd9e0e4edcb332b41aceabd6c03a796e11978</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>test hook for system merge request hook</title>
<updated>2018-01-04T08:33:41+00:00</updated>
<author>
<name>Alexis Reigel</name>
<email>mail@koffeinfrei.org</email>
</author>
<published>2017-09-20T08:41:43+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d71d8ad7f8363d7ffa55d52e1dcbc6bfadaf070e'/>
<id>d71d8ad7f8363d7ffa55d52e1dcbc6bfadaf070e</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix a wrong `X-Gitlab-Event` header when testing webhooks</title>
<updated>2017-09-07T15:40:32+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2017-09-07T11:29:12+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=9e2015752848c908d99a26daf3c0e6e968b95f68'/>
<id>9e2015752848c908d99a26daf3c0e6e968b95f68</id>
<content type='text'>
Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Simplify system hook testing and guarantee test will fire</title>
<updated>2017-08-27T22:50:20+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2017-08-27T21:43:42+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=1e53f40c25a87a285ce6f35b5ae1717fe87477ae'/>
<id>1e53f40c25a87a285ce6f35b5ae1717fe87477ae</id>
<content type='text'>
The change in !11728 would cause an arbitrary project to be chosen to test
system hooks, and it's likely that the project would not have any commits or
relevant commits to test the hook. This would prevent admins from verifying
that the hook fired. Instead of trying to create a representative hook
dynamically, just send static data to guarantee the hook will actually be
tested.

Closes #37067
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The change in !11728 would cause an arbitrary project to be chosen to test
system hooks, and it's likely that the project would not have any commits or
relevant commits to test the hook. This would prevent admins from verifying
that the hook fired. Instead of trying to create a representative hook
dynamically, just send static data to guarantee the hook will actually be
tested.

Closes #37067
</pre>
</div>
</content>
</entry>
</feed>
