delta/gitlab/gitlab-ce.git/app/services/notes, branch tests-for-diff-notes gitlab.com: gitlab-org/gitlab-ce.git Merge branch 'master' into 4273-slash-commands 2016-08-16T22:49:53+00:00 Douwe Maan douwe@selenight.nl 2016-08-16T22:49:53+00:00 e07c27fee427195d8d89f6278d0fc12dfeec3588 # Conflicts: # app/services/issues/create_service.rb 
# Conflicts:
#	app/services/issues/create_service.rb
Fixed specs and fixes based on failing specs 2016-08-16T22:42:34+00:00 Douwe Maan douwe@selenight.nl 2016-08-13T16:58:51+00:00 029b7d2e9266246feff2f165a10b16be1d7fe88e 






Force notes poll after commands have been executed
2016-08-13T01:20:51+00:00

Douwe Maan
douwe@selenight.nl

2016-08-13T01:20:51+00:00

463ae8f570f986d9f50ae42067715d6db0dc1541












Refactor slash command definition
2016-08-13T01:17:18+00:00

Douwe Maan
douwe@selenight.nl

2016-08-13T01:17:18+00:00

5a07b760dff04660d9c7da84852c710b1fc2f786












Simplify the slash commands DSL to store action blocks instead of creating methods
2016-08-12T22:36:47+00:00

Rémy Coutable
remy@rymai.me

2016-08-12T09:19:29+00:00

f393f2dde016edf63b5168eb63405f15d65803eb

Other improvements:
- Ensure slash commands autocomplete doesn't break when noteable_type is not given
- Slash commands: improve autocomplete behavior and /due command
- We don't display slash commands for note edit forms.
- Add tests for reply by email with slash commands
- Be sure to execute slash commands after the note creation in Notes::CreateService

Signed-off-by: Rémy Coutable <remy@rymai.me>





Other improvements:
- Ensure slash commands autocomplete doesn't break when noteable_type is not given
- Slash commands: improve autocomplete behavior and /due command
- We don't display slash commands for note edit forms.
- Add tests for reply by email with slash commands
- Be sure to execute slash commands after the note creation in Notes::CreateService

Signed-off-by: Rémy Coutable <remy@rymai.me>







New Notes::SlashCommandsService service
2016-08-12T22:06:11+00:00

Rémy Coutable
remy@rymai.me

2016-08-09T17:26:45+00:00

7cc4ab14b8a2f1d7d374a320b79374764527659f

Check for update_issuable permission in Notes::SlashCommandsService

Signed-off-by: Rémy Coutable <remy@rymai.me>





Check for update_issuable permission in Notes::SlashCommandsService

Signed-off-by: Rémy Coutable <remy@rymai.me>







Support slash commands in noteable description and notes
2016-08-12T22:05:57+00:00

Rémy Coutable
remy@rymai.me

2016-06-30T15:34:19+00:00

0eea8c885743575b0e93a98846b3663e9903aa66

Some important things to note:

- commands are removed from noteable.description / note.note
- commands are translated to params so that they are treated as normal
  params in noteable Creation services
- the logic is not in the models but in the Creation services, which is
  the right place for advanced logic that has nothing to do with what
  models should be responsible of!
- UI/JS needs to be updated to handle notes which consist of commands
  only
- the `/merge` command is not handled yet

Other improvements:

- Don't process commands in commit notes and display a flash is note is only commands
- Add autocomplete for slash commands
- Add description and params to slash command DSL methods
- Ensure replying by email with a commands-only note works
- Use :subscription_event instead of calling noteable.subscribe
- Support :todo_event in IssuableBaseService

Signed-off-by: Rémy Coutable <remy@rymai.me>





Some important things to note:

- commands are removed from noteable.description / note.note
- commands are translated to params so that they are treated as normal
  params in noteable Creation services
- the logic is not in the models but in the Creation services, which is
  the right place for advanced logic that has nothing to do with what
  models should be responsible of!
- UI/JS needs to be updated to handle notes which consist of commands
  only
- the `/merge` command is not handled yet

Other improvements:

- Don't process commands in commit notes and display a flash is note is only commands
- Add autocomplete for slash commands
- Add description and params to slash command DSL methods
- Ensure replying by email with a commands-only note works
- Use :subscription_event instead of calling noteable.subscribe
- Support :todo_event in IssuableBaseService

Signed-off-by: Rémy Coutable <remy@rymai.me>







Simplify the name for data builder, feedback:
2016-08-12T08:09:29+00:00

Lin Jen-Shin
godfat@godfat.org

2016-08-12T08:09:29+00:00

d5264e8804bca70e613c418a9d346f5787c6fc7a

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5620#note_13671791





https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5620#note_13671791







Move those builders to their own namespace, feedback:
2016-08-04T15:44:27+00:00

Lin Jen-Shin
godfat@godfat.org

2016-08-04T15:44:27+00:00

984367f957c8f8d02fa82b08817e2f2f318c6bff

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5620#note_13540099





https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5620#note_13540099







Fix not normalized emoji paths
2016-07-14T06:51:00+00:00

dixpac
dino.onex@gmail.com

2016-07-03T14:04:22+00:00

e21492b810bf9cd30f0e60836c056a72e830f427

* There where path where +1 was stored as +1 not as thumbsup
  that was causing problems such as showing thumbsup icon 2 time.
  I fixed this to always normalize and store +1 as tumbsup





* There where path where +1 was stored as +1 not as thumbsup
  that was causing problems such as showing thumbsup icon 2 time.
  I fixed this to always normalize and store +1 as tumbsup