<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/app/services/labels, branch docs-pages-force-https</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Check if labels are available for target issuable</title>
<updated>2019-03-28T11:06:31+00:00</updated>
<author>
<name>Jarka Košanová</name>
<email>jarka@gitlab.com</email>
</author>
<published>2019-02-12T08:35:34+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=96153f2055dc0bcd2ee8b34a36f33529f6ccc50e'/>
<id>96153f2055dc0bcd2ee8b34a36f33529f6ccc50e</id>
<content type='text'>
- labels have to be in the same project/group
as an issuable
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- labels have to be in the same project/group
as an issuable
</pre>
</div>
</content>
</entry>
<entry>
<title>Incorporate feedback from Nick</title>
<updated>2019-01-31T12:49:50+00:00</updated>
<author>
<name>Robert Schilling</name>
<email>rschilling@student.tugraz.at</email>
</author>
<published>2018-09-08T08:36:45+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=82f09a91dd3abae48b74010f541ea50e0190276a'/>
<id>82f09a91dd3abae48b74010f541ea50e0190276a</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Enable the Layout/ExtraSpacing cop</title>
<updated>2019-01-24T12:05:45+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2019-01-16T12:09:29+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=3a2abc1d50b419a353edb7f7cf68f3894dfdeeef'/>
<id>3a2abc1d50b419a353edb7f7cf68f3894dfdeeef</id>
<content type='text'>
Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix several ActionController::Parameters deprecations</title>
<updated>2019-01-11T20:19:01+00:00</updated>
<author>
<name>Jasper Maes</name>
<email>jaspermaes.jm@gmail.com</email>
</author>
<published>2019-01-02T20:06:55+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=30e2a8f08cbd70c4f296a4abe0689defc73713c9'/>
<id>30e2a8f08cbd70c4f296a4abe0689defc73713c9</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix deprecation: Passing ActiveRecord::Base objects to sanitize_sql_hash_for_assignment</title>
<updated>2018-12-13T20:48:43+00:00</updated>
<author>
<name>Jasper Maes</name>
<email>jaspermaes.jm@gmail.com</email>
</author>
<published>2018-12-13T20:45:40+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=c8d1ca7a5a923f78b048da8b4abbac379d944bfc'/>
<id>c8d1ca7a5a923f78b048da8b4abbac379d944bfc</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Replace deprecated uniq on a Relation with distinct</title>
<updated>2018-10-26T16:19:28+00:00</updated>
<author>
<name>Jasper Maes</name>
<email>jaspermaes.jm@gmail.com</email>
</author>
<published>2018-10-26T16:19:28+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=db80db793f43f9b4367730fc9b95c1925807f999'/>
<id>db80db793f43f9b4367730fc9b95c1925807f999</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Added FromUnion to easily select from a UNION</title>
<updated>2018-09-17T10:39:43+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2018-09-11T15:31:34+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=8a72f5c427426a3f90a14b2711ee1ecec4e8ca40'/>
<id>8a72f5c427426a3f90a14b2711ee1ecec4e8ca40</id>
<content type='text'>
This commit adds the module `FromUnion`, which provides the class method
`from_union`. This simplifies the process of selecting data from the
result of a UNION, and reduces the likelihood of making mistakes. As a
result, instead of this:

    union = Gitlab::SQL::Union.new([foo, bar])

    Foo.from("(#{union.to_sql}) #{Foo.table_name}")

We can now write this instead:

    Foo.from_union([foo, bar])

This commit also includes some changes to make this new setup work
properly. For example, a bug in Rails 4
(https://github.com/rails/rails/issues/24193) would break the use of
`from("sub-query-here").includes(:relation)` in certain cases. There was
also a CI query which appeared to repeat a lot of conditions from an
outer query on an inner query, which isn't necessary.

Finally, we include a RuboCop cop to ensure developers use this new
module, instead of using Gitlab::SQL::Union directly.

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/51307
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This commit adds the module `FromUnion`, which provides the class method
`from_union`. This simplifies the process of selecting data from the
result of a UNION, and reduces the likelihood of making mistakes. As a
result, instead of this:

    union = Gitlab::SQL::Union.new([foo, bar])

    Foo.from("(#{union.to_sql}) #{Foo.table_name}")

We can now write this instead:

    Foo.from_union([foo, bar])

This commit also includes some changes to make this new setup work
properly. For example, a bug in Rails 4
(https://github.com/rails/rails/issues/24193) would break the use of
`from("sub-query-here").includes(:relation)` in certain cases. There was
also a CI query which appeared to repeat a lot of conditions from an
outer query on an inner query, which isn't necessary.

Finally, we include a RuboCop cop to ensure developers use this new
module, instead of using Gitlab::SQL::Union directly.

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/51307
</pre>
</div>
</content>
</entry>
<entry>
<title>Disable existing offenses for the CodeReuse cops</title>
<updated>2018-09-11T15:32:00+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2018-08-27T15:31:01+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=2039c8280db1646845c33d6c5a74e5f23ca6f4de'/>
<id>2039c8280db1646845c33d6c5a74e5f23ca6f4de</id>
<content type='text'>
This whitelists all existing offenses for the various CodeReuse cops, of
which most are triggered by the CodeReuse/ActiveRecord cop.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This whitelists all existing offenses for the various CodeReuse cops, of
which most are triggered by the CodeReuse/ActiveRecord cop.
</pre>
</div>
</content>
</entry>
<entry>
<title>Use ResourceLabelEvent for tracking label changes</title>
<updated>2018-09-07T13:39:20+00:00</updated>
<author>
<name>Jan Provaznik</name>
<email>jprovaznik@gitlab.com</email>
</author>
<published>2018-09-07T13:39:20+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d95c1f0335f7309114fcbb0d5413b28e1701a640'/>
<id>d95c1f0335f7309114fcbb0d5413b28e1701a640</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Whitelist existing destroy_all offenses</title>
<updated>2018-08-16T15:29:37+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2018-08-16T12:46:40+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=9606dbbb033567de9831a8cdea0e56236e7d2eb2'/>
<id>9606dbbb033567de9831a8cdea0e56236e7d2eb2</id>
<content type='text'>
This whitelists all existing places where we use "destroy_all".
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This whitelists all existing places where we use "destroy_all".
</pre>
</div>
</content>
</entry>
</feed>
