<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/app/services/issues, branch backport-gitlab-database</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Enable frozen string in apps/services/**/*.rb</title>
<updated>2018-07-16T19:36:41+00:00</updated>
<author>
<name>gfyoung</name>
<email>gfyoung17@gmail.com</email>
</author>
<published>2018-07-16T16:31:01+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=265478ad74172ed14794c26f75c3ad45908f36a2'/>
<id>265478ad74172ed14794c26f75c3ad45908f36a2</id>
<content type='text'>
For directories application_settings --&gt; labels.

Partially addresses #47424.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
For directories application_settings --&gt; labels.

Partially addresses #47424.
</pre>
</div>
</content>
</entry>
<entry>
<title>Make Issues::BaseService match EE</title>
<updated>2018-07-05T11:34:42+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2018-07-05T11:34:42+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=3ac7203db9f532f0de62c48f6bd9690b54d3b9d8'/>
<id>3ac7203db9f532f0de62c48f6bd9690b54d3b9d8</id>
<content type='text'>
We have `#allows_multiple_assignees?` defined in CE too, and `take(1)` appears
to be equivalent to `[0, 1]`.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We have `#allows_multiple_assignees?` defined in CE too, and `take(1)` appears
to be equivalent to `[0, 1]`.
</pre>
</div>
</content>
</entry>
<entry>
<title>Keep label on issue when moving</title>
<updated>2018-06-27T16:06:43+00:00</updated>
<author>
<name>Chantal Rollison</name>
<email>crollison@gitlab.com</email>
</author>
<published>2018-06-20T14:41:23+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=6a3f9ceff009c2bb93c005e9bfbf641aa45c1cb3'/>
<id>6a3f9ceff009c2bb93c005e9bfbf641aa45c1cb3</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Move NotificationService calls to Sidekiq</title>
<updated>2018-04-25T11:48:14+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2018-04-20T17:37:38+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=b5042e5301e86ec7822221ee29679b0fbf5c71ca'/>
<id>b5042e5301e86ec7822221ee29679b0fbf5c71ca</id>
<content type='text'>
The NotificationService has to do quite a lot of work to calculate the
recipients for an email. Where possible, we should try to avoid doing this in an
HTTP request, because the mail are sent by Sidekiq anyway, so there's no need to
schedule those emails immediately.

This commit creates a generic Sidekiq worker that uses Global ID to serialise
and deserialise its arguments, then forwards them to the NotificationService.
The NotificationService gains an `#async` method, so you can replace:

    notification_service.new_issue(issue, current_user)

With:

    notification_service.async.new_issue(issue, current_user)

And have everything else work as normal, except that calculating the recipients
will be done by Sidekiq, which will then schedule further Sidekiq jobs to send
each email.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The NotificationService has to do quite a lot of work to calculate the
recipients for an email. Where possible, we should try to avoid doing this in an
HTTP request, because the mail are sent by Sidekiq anyway, so there's no need to
schedule those emails immediately.

This commit creates a generic Sidekiq worker that uses Global ID to serialise
and deserialise its arguments, then forwards them to the NotificationService.
The NotificationService gains an `#async` method, so you can replace:

    notification_service.new_issue(issue, current_user)

With:

    notification_service.async.new_issue(issue, current_user)

And have everything else work as normal, except that calculating the recipients
will be done by Sidekiq, which will then schedule further Sidekiq jobs to send
each email.
</pre>
</div>
</content>
</entry>
<entry>
<title>Improve specs and docs</title>
<updated>2018-04-05T18:14:04+00:00</updated>
<author>
<name>Felipe Artur</name>
<email>felipefac@gmail.com</email>
</author>
<published>2018-04-05T18:14:04+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=b9c0cf1318d663edc3af593f88521e86e0614824'/>
<id>b9c0cf1318d663edc3af593f88521e86e0614824</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'issue_44551' into 'master'</title>
<updated>2018-04-05T08:19:15+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@mcgivern.me.uk</email>
</author>
<published>2018-04-05T08:19:15+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=7412ad2e3680b7f7a18d89dd8e30f01b28c19326'/>
<id>7412ad2e3680b7f7a18d89dd8e30f01b28c19326</id>
<content type='text'>
Fix 404 in group boards when moving issue between lists

Closes #44551

See merge request gitlab-org/gitlab-ce!18064</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fix 404 in group boards when moving issue between lists

Closes #44551

See merge request gitlab-org/gitlab-ce!18064</pre>
</div>
</content>
</entry>
<entry>
<title>Fix 404 in group boards when moving issue between lists</title>
<updated>2018-04-03T18:51:10+00:00</updated>
<author>
<name>Felipe Artur</name>
<email>felipefac@gmail.com</email>
</author>
<published>2018-03-28T19:12:56+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=7481fc5aa8e7d6cee3e03480a6b7dd7a7d19307e'/>
<id>7481fc5aa8e7d6cee3e03480a6b7dd7a7d19307e</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>changed the way of nullifying colums</title>
<updated>2018-03-05T14:27:53+00:00</updated>
<author>
<name>haseeb</name>
<email>haseebeqx@yahoo.com</email>
</author>
<published>2018-03-05T14:27:53+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=f0859cc937f7c4251062b12957253c4832bd1263'/>
<id>f0859cc937f7c4251062b12957253c4832bd1263</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>nullify closed by on reopenning issue</title>
<updated>2018-03-03T10:21:18+00:00</updated>
<author>
<name>haseeb</name>
<email>haseebeqx@yahoo.com</email>
</author>
<published>2018-03-03T10:21:18+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=8f319bf73730b2b1b3f7138f921188fe84198ec6'/>
<id>8f319bf73730b2b1b3f7138f921188fe84198ec6</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>closed by field added</title>
<updated>2018-02-28T13:55:24+00:00</updated>
<author>
<name>haseeb</name>
<email>haseebeqx@yahoo.com</email>
</author>
<published>2018-02-09T18:23:55+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=f211e47eb20959fdebc5ae0aabf66267ea521ee7'/>
<id>f211e47eb20959fdebc5ae0aabf66267ea521ee7</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
