<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/app/services/issues/reopen_service.rb, branch remove-commit-tree</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Refresh open Issue and Merge Request project counter caches when re-opening</title>
<updated>2017-10-30T16:20:29+00:00</updated>
<author>
<name>Rob Ede</name>
<email>robjtede@icloud.com</email>
</author>
<published>2017-10-30T16:20:29+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=e80f056712be9013262981ad1bfb1978f7ffbbde'/>
<id>e80f056712be9013262981ad1bfb1978f7ffbbde</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge issuable "reopened" state into "opened"</title>
<updated>2017-07-28T11:31:51+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2017-07-19T14:03:50+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=6ef87a20832d1a2581cb85e60eda46f999c55a81'/>
<id>6ef87a20832d1a2581cb85e60eda46f999c55a81</id>
<content type='text'>
Having two states that essentially mean the same thing is very much like
having a boolean "true" and boolean "mostly-true": it's rather silly.
This commit merges the "reopened" state into the "opened" state while
taking care of system notes still showing messages along the lines of
"Alice reopened this issue".

A big benefit from having only two states (opened and closed) is that
indexing and querying becomes simpler and more performant. For example,
to get all the opened queries we no longer have to query both states:

    SELECT *
    FROM issues
    WHERE project_id = 2
    AND state IN ('opened', 'reopened');

Instead we can query a single state directly, which can be much faster:

    SELECT *
    FROM issues
    WHERE project_id = 2
    AND state = 'opened';

Further, only having two states makes indexing easier as we will only
ever filter (and thus scan an index) using a single value. Partial
indexes could help but aren't supported on MySQL, complicating the
development process and not being helpful for MySQL.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Having two states that essentially mean the same thing is very much like
having a boolean "true" and boolean "mostly-true": it's rather silly.
This commit merges the "reopened" state into the "opened" state while
taking care of system notes still showing messages along the lines of
"Alice reopened this issue".

A big benefit from having only two states (opened and closed) is that
indexing and querying becomes simpler and more performant. For example,
to get all the opened queries we no longer have to query both states:

    SELECT *
    FROM issues
    WHERE project_id = 2
    AND state IN ('opened', 'reopened');

Instead we can query a single state directly, which can be much faster:

    SELECT *
    FROM issues
    WHERE project_id = 2
    AND state = 'opened';

Further, only having two states makes indexing easier as we will only
ever filter (and thus scan an index) using a single value. Partial
indexes could help but aren't supported on MySQL, complicating the
development process and not being helpful for MySQL.
</pre>
</div>
</content>
</entry>
<entry>
<title>Clear issuable counter caches on update</title>
<updated>2017-07-19T09:21:20+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2017-07-11T16:12:33+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=0e488ef70ab2608847423201e957693745f1e3b1'/>
<id>0e488ef70ab2608847423201e957693745f1e3b1</id>
<content type='text'>
When an issuable's state changes, or one is created, we should clear the cache
counts for a user's assigned issuables, and also the project-wide caches for
this user type.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When an issuable's state changes, or one is created, we should clear the cache
counts for a user's assigned issuables, and also the project-wide caches for
this user type.
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix counters cache invalidation for Issues and Merge Requests</title>
<updated>2017-05-26T14:43:51+00:00</updated>
<author>
<name>Valery Sizov</name>
<email>valery@gitlab.com</email>
</author>
<published>2017-05-26T13:29:42+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=33687db01d399b6b1e6b6a120995d84f833baac4'/>
<id>33687db01d399b6b1e6b6a120995d84f833baac4</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Enforce permissions in `{Issues,MergeRequests}::{Close,Reopen}Service`</title>
<updated>2016-08-12T22:06:11+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2016-08-09T15:51:40+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=a54fdc384fee9daeab1b9fb638dae5dce4e4be15'/>
<id>a54fdc384fee9daeab1b9fb638dae5dce4e4be15</id>
<content type='text'>
Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Update SystemNoteService method naming conventions</title>
<updated>2015-05-11T04:01:15+00:00</updated>
<author>
<name>Robert Speicher</name>
<email>rspeicher@gmail.com</email>
</author>
<published>2015-05-09T22:18:50+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=686f6855c25ecfc09fdf199cb7e3fb7dd787ed28'/>
<id>686f6855c25ecfc09fdf199cb7e3fb7dd787ed28</id>
<content type='text'>
Now the verb comes first, and there is no restriction on
singular/plural.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Now the verb comes first, and there is no restriction on
singular/plural.
</pre>
</div>
</content>
</entry>
<entry>
<title>Add a SystemNoteService class</title>
<updated>2015-05-11T04:01:01+00:00</updated>
<author>
<name>Robert Speicher</name>
<email>rspeicher@gmail.com</email>
</author>
<published>2015-05-01T03:16:19+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=48e6fb532a6655b98319403c5e8699f7daf0305e'/>
<id>48e6fb532a6655b98319403c5e8699f7daf0305e</id>
<content type='text'>
There's a lot of code in the Note model that only deals with creating
system notes, so we're going to split that into its own class.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
There's a lot of code in the Note model that only deals with creating
system notes, so we're going to split that into its own class.
</pre>
</div>
</content>
</entry>
<entry>
<title>Notification for reopened issue.</title>
<updated>2014-07-03T10:51:24+00:00</updated>
<author>
<name>Marin Jankovski</name>
<email>marin@gitlab.com</email>
</author>
<published>2014-07-03T10:51:24+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=1208c6caa81ab4e03301f965ec67d12e2b038358'/>
<id>1208c6caa81ab4e03301f965ec67d12e2b038358</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Return a little more information in Issue webhook</title>
<updated>2014-06-13T10:14:43+00:00</updated>
<author>
<name>Jeroen van Baarsen</name>
<email>jeroenvanbaarsen@gmail.com</email>
</author>
<published>2014-05-23T13:16:03+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=45e1941fb3acf8fdc0544842ce503de007e3c706'/>
<id>45e1941fb3acf8fdc0544842ce503de007e3c706</id>
<content type='text'>
When a webhook for issues is triggered, it should also return the
resource URL, and the action that was performed (ie: Was it reopened,
updated, opened or closed)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When a webhook for issues is triggered, it should also return the
resource URL, and the action that was performed (ie: Was it reopened,
updated, opened or closed)
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix tests</title>
<updated>2014-04-02T16:55:23+00:00</updated>
<author>
<name>Dmitriy Zaporozhets</name>
<email>dmitriy.zaporozhets@gmail.com</email>
</author>
<published>2014-04-02T16:55:23+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=49f977d675b44b6aae0f491fbbf86dd1ee05eb64'/>
<id>49f977d675b44b6aae0f491fbbf86dd1ee05eb64</id>
<content type='text'>
Signed-off-by: Dmitriy Zaporozhets &lt;dmitriy.zaporozhets@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Dmitriy Zaporozhets &lt;dmitriy.zaporozhets@gmail.com&gt;
</pre>
</div>
</content>
</entry>
</feed>
