delta/gitlab/gitlab-ce.git/app/services/groups, branch remove-require-context-users-bundle

Fix a number of race conditions that can occur during namespace deletion

2017-02-16T07:56:40+00:00

There are two problems in the current implementation:

1. If a project is marked for deletion via the `pending_delete` flag
and then the namespace was quickly deleted, it's possible that the
namespace skips over that project and leaves that project in
an orphaned state.

2. Before namespace deletion, the namespace attempts to clean up
all the relevant storage paths. However, if all projects have been
removed synchronously, then the namespace will not be able to clean anything.
To prevent this, we should load the paths to be deleted before
actually destroying projects.

The specs were missing this second case due to a permission issue
that caused project removal never to happen.

Fix inconsistent naming for services that delete things

2017-02-08T08:16:43+00:00

* Changed name of delete_user_service and worker to destroy
* Move and change delete_group_service to Groups::DestroyService
* Rename Notes::DeleteService to Notes::DestroyService

Refactor nested group related code

2016-12-29T17:18:05+00:00

* Simplify code around group parent access check
* Rename 'Nested groups' to 'Subgroups' tab at group#show page

Signed-off-by: Dmitriy Zaporozhets

Add nested groups support to the Groups::CreateService

2016-12-26T09:56:19+00:00

Signed-off-by: Dmitriy Zaporozhets

Fix error 500 renaming group. Also added specs and changelog.

2016-12-20T16:52:27+00:00

Enable Style/MultilineOperationIndentation in Rubocop, fixes #25741

2016-12-16T18:37:22+00:00

Address feedback

2016-03-21T23:09:20+00:00

Fix specs

2016-03-20T22:26:58+00:00

Tweaks, refactoring, and specs

2016-03-20T20:04:07+00:00

Improve group visibility level feature

2016-03-18T19:58:04+00:00