<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/app/services/auth, branch 35942_api_binary_encoding</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>`current_application_settings` belongs on `Gitlab::CurrentSettings`</title>
<updated>2017-08-31T12:38:33+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2017-08-31T09:47:03+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=5883ce95efcc4cc04f949f9b4e66d73fbede94e2'/>
<id>5883ce95efcc4cc04f949f9b4e66d73fbede94e2</id>
<content type='text'>
The initializers including this were doing so at the top level, so every object
loaded after them had a `current_application_settings` method. However, if
someone had rack-attack enabled (which was loaded before these initializers), it
would try to load the API, and fail, because `Gitlab::CurrentSettings` didn't
have that method.

To fix this:

1. Don't include `Gitlab::CurrentSettings` at the top level. We do not need
   `Object.new.current_application_settings` to work.
2. Make `Gitlab::CurrentSettings` explicitly `extend self`, as we already use it
   like that in several places.
3. Change the initializers to use that new form.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The initializers including this were doing so at the top level, so every object
loaded after them had a `current_application_settings` method. However, if
someone had rack-attack enabled (which was loaded before these initializers), it
would try to load the API, and fail, because `Gitlab::CurrentSettings` didn't
have that method.

To fix this:

1. Don't include `Gitlab::CurrentSettings` at the top level. We do not need
   `Object.new.current_application_settings` to work.
2. Make `Gitlab::CurrentSettings` explicitly `extend self`, as we already use it
   like that in several places.
3. Change the initializers to use that new form.
</pre>
</div>
</content>
</entry>
<entry>
<title>Rename user_can_admin? because it's more accurate</title>
<updated>2017-08-07T09:29:34+00:00</updated>
<author>
<name>Lin Jen-Shin</name>
<email>godfat@godfat.org</email>
</author>
<published>2017-08-07T09:29:34+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=64aa9e21b254e1f03e55d359e8fe9a349c660b43'/>
<id>64aa9e21b254e1f03e55d359e8fe9a349c660b43</id>
<content type='text'>
Also fix the test because we no longer have :empty_project,
just use :project is the same as before
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Also fix the test because we no longer have :empty_project,
just use :project is the same as before
</pre>
</div>
</content>
</entry>
<entry>
<title>fix typo and check</title>
<updated>2017-05-29T19:11:28+00:00</updated>
<author>
<name>Jean Praloran</name>
<email>jeanpralo@gmail.com</email>
</author>
<published>2017-03-17T03:40:57+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d890c6e81b696a5c02fe8138a76a4d113ee8ba93'/>
<id>d890c6e81b696a5c02fe8138a76a4d113ee8ba93</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>add test and rebase</title>
<updated>2017-05-29T19:11:28+00:00</updated>
<author>
<name>Jean Praloran</name>
<email>jeanpralo@gmail.com</email>
</author>
<published>2017-03-16T22:19:12+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=6c9da292418c606aefe34aab40923d5730ae9aa5'/>
<id>6c9da292418c606aefe34aab40923d5730ae9aa5</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>change ability requirement</title>
<updated>2017-05-29T19:11:28+00:00</updated>
<author>
<name>Jean Praloran</name>
<email>jeanpralo@gmail.com</email>
</author>
<published>2016-09-08T23:16:42+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=8ef46b9f46711145496da4b3e64b0b7ace80c2ad'/>
<id>8ef46b9f46711145496da4b3e64b0b7ace80c2ad</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>add star for action scope, in order to delete image from registry</title>
<updated>2017-05-29T19:11:28+00:00</updated>
<author>
<name>jean</name>
<email>jeanpralo@gmail.com</email>
</author>
<published>2016-08-01T03:38:16+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=fcca3e6edd4eb83875d77564e98d1fa6ef504332'/>
<id>fcca3e6edd4eb83875d77564e98d1fa6ef504332</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add test example for invalid registry access request</title>
<updated>2017-03-31T10:37:44+00:00</updated>
<author>
<name>Grzegorz Bizon</name>
<email>grzesiek.bizon@gmail.com</email>
</author>
<published>2017-03-31T10:37:44+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=4726ff9dbee74d00544c7eb1ea188ecdfe16d7e8'/>
<id>4726ff9dbee74d00544c7eb1ea188ecdfe16d7e8</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add specs for container repository factory method</title>
<updated>2017-03-31T10:27:05+00:00</updated>
<author>
<name>Grzegorz Bizon</name>
<email>grzesiek.bizon@gmail.com</email>
</author>
<published>2017-03-31T10:27:05+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=60cdd2bcc894cf9cce4892570bf6a146dc45e536'/>
<id>60cdd2bcc894cf9cce4892570bf6a146dc45e536</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Do not allow registry requests for invalid repositories</title>
<updated>2017-03-30T13:41:51+00:00</updated>
<author>
<name>Grzegorz Bizon</name>
<email>grzesiek.bizon@gmail.com</email>
</author>
<published>2017-03-30T13:41:51+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=cf042068b5f69b416640f9a4fcb21fbec1082268'/>
<id>cf042068b5f69b416640f9a4fcb21fbec1082268</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Create container repository on successful push auth</title>
<updated>2017-03-30T13:24:46+00:00</updated>
<author>
<name>Grzegorz Bizon</name>
<email>grzesiek.bizon@gmail.com</email>
</author>
<published>2017-03-30T13:24:46+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=7d3d1ec5a7b3ee13397af587c6ecb3a3fc297006'/>
<id>7d3d1ec5a7b3ee13397af587c6ecb3a3fc297006</id>
<content type='text'>
Because we do not have yet two way communication between container
registry and GitLab, we need to eagerly create a new container
repository objects in database. We now do that after user/build
successfully authenticates a push action using auth service.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Because we do not have yet two way communication between container
registry and GitLab, we need to eagerly create a new container
repository objects in database. We now do that after user/build
successfully authenticates a push action using auth service.
</pre>
</div>
</content>
</entry>
</feed>
