<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/app/serializers, branch instance_level_clusters</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Expose can_uninstall in cluster_status.json</title>
<updated>2019-04-30T05:55:11+00:00</updated>
<author>
<name>Thong Kuah</name>
<email>tkuah@gitlab.com</email>
</author>
<published>2019-04-12T05:42:48+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=44eec56834b7f524a2bf99d0f5e1571b52576d72'/>
<id>44eec56834b7f524a2bf99d0f5e1571b52576d72</id>
<content type='text'>
Only prometheus can be uninstalled atm, the rest will be dealt with
later.

Presumption is that new application types will have uninstallation
implmemented at the same time.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Only prometheus can be uninstalled atm, the rest will be dealt with
later.

Presumption is that new application types will have uninstallation
implmemented at the same time.
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix slow performance with compiling HAML templates</title>
<updated>2019-04-29T12:33:50+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2019-04-28T05:25:45+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=b02458ef52ac3e61d3c8b924e092e956375c15f7'/>
<id>b02458ef52ac3e61d3c8b924e092e956375c15f7</id>
<content type='text'>
In Rails 5, including `ActionView::Context` can have a significant and
hidden performance penalty because this module also includes
`ActionView::CompiledTemplates`. This means that any module that
includes ActionView::Context becomes a descendant of
`CompiledTemplates`.

When a partial is rendered for the first time, it runs
`ActionView::CompiledTemplates#module_eval`, which will evaluate a
string that defines a new method for that partial. For example, the
source of partial might be this string:

```
def _app_views_project_show_html_haml___12345(local_assigns, output)
  "hello world"
end
```

When this string is evaluated, the Ruby interpreter will define the
method and clear the global method cache for all descendants of
`ActionView::CompiledTemplates`. Previous to this change, we
inadvertently made a number of modules fall into this category:

* GroupChildEntity
* NoteUserEntity
* Notify
* MergeRequestUserEntity
* AnalyticsCommitEntity
* CommitEntity
* UserEntity
* Kaminari::Helpers::Paginator
* CurrentUserEntity
* ActionView::Base
* ActionDispatch::DebugExceptions::DebugView
* MarkupHelper
* MergeRequestPresenter

After this change:

* Kaminari::Helpers::Paginator
* ActionView::Base
* ActionDispatch::DebugExceptions::DebugView

Each time a partial is rendered for the first time, all methods for
those modules will have to be redefined. This can exact a significant
performance penalty.

How bad is this penalty? Using the following benchmark script, we can
use DTrace to sample the Ruby interpreter:

```
Benchmark.bm do |x|
  x.report do
    1000.times do
      ActionView::CompiledTemplates.module_eval("def testme\nend")
    end
  end
end
```

This revealed a 11x jump in the time spent in `core#define_method`
alone.

Rails 6 fixes this behavior by moving the `include CompiledTemplates`
into ActionView::Base so that including `ActionView::Context` doesn't
quietly affect other modules in this way.

Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/11198
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
In Rails 5, including `ActionView::Context` can have a significant and
hidden performance penalty because this module also includes
`ActionView::CompiledTemplates`. This means that any module that
includes ActionView::Context becomes a descendant of
`CompiledTemplates`.

When a partial is rendered for the first time, it runs
`ActionView::CompiledTemplates#module_eval`, which will evaluate a
string that defines a new method for that partial. For example, the
source of partial might be this string:

```
def _app_views_project_show_html_haml___12345(local_assigns, output)
  "hello world"
end
```

When this string is evaluated, the Ruby interpreter will define the
method and clear the global method cache for all descendants of
`ActionView::CompiledTemplates`. Previous to this change, we
inadvertently made a number of modules fall into this category:

* GroupChildEntity
* NoteUserEntity
* Notify
* MergeRequestUserEntity
* AnalyticsCommitEntity
* CommitEntity
* UserEntity
* Kaminari::Helpers::Paginator
* CurrentUserEntity
* ActionView::Base
* ActionDispatch::DebugExceptions::DebugView
* MarkupHelper
* MergeRequestPresenter

After this change:

* Kaminari::Helpers::Paginator
* ActionView::Base
* ActionDispatch::DebugExceptions::DebugView

Each time a partial is rendered for the first time, all methods for
those modules will have to be redefined. This can exact a significant
performance penalty.

How bad is this penalty? Using the following benchmark script, we can
use DTrace to sample the Ruby interpreter:

```
Benchmark.bm do |x|
  x.report do
    1000.times do
      ActionView::CompiledTemplates.module_eval("def testme\nend")
    end
  end
end
```

This revealed a 11x jump in the time spent in `core#define_method`
alone.

Rails 6 fixes this behavior by moving the `include CompiledTemplates`
into ActionView::Base so that including `ActionView::Context` doesn't
quietly affect other modules in this way.

Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/11198
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'nfriend-update-merge-request-widget-for-post-merge-pipelines' into 'master'</title>
<updated>2019-04-16T14:21:50+00:00</updated>
<author>
<name>Filipa Lacerda</name>
<email>filipa@gitlab.com</email>
</author>
<published>2019-04-16T14:21:50+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=cd509d991ec43b05994af1c157ef724af7f04e8f'/>
<id>cd509d991ec43b05994af1c157ef724af7f04e8f</id>
<content type='text'>
Update merge request widget to accommodate post-merge pipelines

See merge request gitlab-org/gitlab-ce!25983</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Update merge request widget to accommodate post-merge pipelines

See merge request gitlab-org/gitlab-ce!25983</pre>
</div>
</content>
</entry>
<entry>
<title>Add two warning messages to the MR widget</title>
<updated>2019-04-15T13:25:48+00:00</updated>
<author>
<name>Nathan Friend</name>
<email>nathan@gitlab.com</email>
</author>
<published>2019-04-15T13:25:48+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=12170f8320c3bbe5b6bbdbda83ac7a163826b34a'/>
<id>12170f8320c3bbe5b6bbdbda83ac7a163826b34a</id>
<content type='text'>
This commit adds two new warning messages to the MR widget that handle
cases involving merge request pipelines.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This commit adds two new warning messages to the MR widget that handle
cases involving merge request pipelines.
</pre>
</div>
</content>
</entry>
<entry>
<title>Add time tracking information to Issue Boards sidebar</title>
<updated>2019-04-12T09:59:26+00:00</updated>
<author>
<name>Kushal Pandya</name>
<email>kushalspandya@gmail.com</email>
</author>
<published>2019-04-09T10:39:42+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=5b28ee5f337a4b95273557553de9f500d7195fe6'/>
<id>5b28ee5f337a4b95273557553de9f500d7195fe6</id>
<content type='text'>
Add time tracking progress bar to Issue Boards sidebar.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Add time tracking progress bar to Issue Boards sidebar.
</pre>
</div>
</content>
</entry>
<entry>
<title>Add time tracking to issue board entities</title>
<updated>2019-04-10T11:00:41+00:00</updated>
<author>
<name>pataar</name>
<email>pietering1@gmail.com</email>
</author>
<published>2019-04-10T11:00:41+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=a2d34fbfbe0ba1772359d4c62b93cb90a4d752b4'/>
<id>a2d34fbfbe0ba1772359d4c62b93cb90a4d752b4</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch '6649-extract-ee-specific-files-lines-for-ci-cd-app-serializers' into 'master'</title>
<updated>2019-04-09T17:48:40+00:00</updated>
<author>
<name>Robert Speicher</name>
<email>rspeicher@gmail.com</email>
</author>
<published>2019-04-09T17:48:40+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=41e36b05def9ebf2b800a04d067367f7571bae9d'/>
<id>41e36b05def9ebf2b800a04d067367f7571bae9d</id>
<content type='text'>
Extract preloaded_relations

See merge request gitlab-org/gitlab-ce!27168</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Extract preloaded_relations

See merge request gitlab-org/gitlab-ce!27168</pre>
</div>
</content>
</entry>
<entry>
<title>Extract preloaded_relations into method</title>
<updated>2019-04-09T11:24:27+00:00</updated>
<author>
<name>Matija Čupić</name>
<email>matteeyah@gmail.com</email>
</author>
<published>2019-04-09T11:10:31+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=726f142dd233d82da6a7e60eaee30342ceecfbaf'/>
<id>726f142dd233d82da6a7e60eaee30342ceecfbaf</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>[CE] Support multiple assignees for merge requests</title>
<updated>2019-04-08T21:40:00+00:00</updated>
<author>
<name>Oswaldo Ferreira</name>
<email>oswaldo@gitlab.com</email>
</author>
<published>2019-04-07T18:35:16+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=ca884980ee8e6fe1269f5abdb803519d51aa09c0'/>
<id>ca884980ee8e6fe1269f5abdb803519d51aa09c0</id>
<content type='text'>
Backports https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/10161
(code out of ee/ folder).
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Backports https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/10161
(code out of ee/ folder).
</pre>
</div>
</content>
</entry>
<entry>
<title>Add Knative metrics to Prometheus</title>
<updated>2019-04-06T02:02:39+00:00</updated>
<author>
<name>Chris Baumbauer</name>
<email>cab@cabnetworks.net</email>
</author>
<published>2019-04-06T02:02:39+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=b77fe7db3e885edca14c862f362e2bbd43f0e498'/>
<id>b77fe7db3e885edca14c862f362e2bbd43f0e498</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
