<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/app/policies, branch 35942_api_binary_encoding</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>`current_application_settings` belongs on `Gitlab::CurrentSettings`</title>
<updated>2017-08-31T12:38:33+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2017-08-31T09:47:03+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=5883ce95efcc4cc04f949f9b4e66d73fbede94e2'/>
<id>5883ce95efcc4cc04f949f9b4e66d73fbede94e2</id>
<content type='text'>
The initializers including this were doing so at the top level, so every object
loaded after them had a `current_application_settings` method. However, if
someone had rack-attack enabled (which was loaded before these initializers), it
would try to load the API, and fail, because `Gitlab::CurrentSettings` didn't
have that method.

To fix this:

1. Don't include `Gitlab::CurrentSettings` at the top level. We do not need
   `Object.new.current_application_settings` to work.
2. Make `Gitlab::CurrentSettings` explicitly `extend self`, as we already use it
   like that in several places.
3. Change the initializers to use that new form.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The initializers including this were doing so at the top level, so every object
loaded after them had a `current_application_settings` method. However, if
someone had rack-attack enabled (which was loaded before these initializers), it
would try to load the API, and fail, because `Gitlab::CurrentSettings` didn't
have that method.

To fix this:

1. Don't include `Gitlab::CurrentSettings` at the top level. We do not need
   `Object.new.current_application_settings` to work.
2. Make `Gitlab::CurrentSettings` explicitly `extend self`, as we already use it
   like that in several places.
3. Change the initializers to use that new form.
</pre>
</div>
</content>
</entry>
<entry>
<title>replace `is_team_member?` with `team_member?`</title>
<updated>2017-08-29T08:14:42+00:00</updated>
<author>
<name>Maxim Rydkin</name>
<email>maks.rydkin@gmail.com</email>
</author>
<published>2017-08-24T17:06:04+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=eb0a17ba4bf05b7bcefb31755381d08fd689b818'/>
<id>eb0a17ba4bf05b7bcefb31755381d08fd689b818</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Improves subgroup creation permissions</title>
<updated>2017-08-21T14:40:22+00:00</updated>
<author>
<name>Tiago Botelho</name>
<email>tiagonbotelho@hotmail.com</email>
</author>
<published>2017-08-09T10:58:00+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=5bc9dedf401a10388b9505ccbc11d4802ff76a43'/>
<id>5bc9dedf401a10388b9505ccbc11d4802ff76a43</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Allow logged in users to read user list under public restriction</title>
<updated>2017-08-01T07:46:13+00:00</updated>
<author>
<name>Lin Jen-Shin (godfat)</name>
<email>godfat@godfat.org</email>
</author>
<published>2017-08-01T07:46:13+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=0d35b0818026e9a2528b44f9e72af76b98f1a162'/>
<id>0d35b0818026e9a2528b44f9e72af76b98f1a162</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch '30634-protected-pipeline' into 'master'</title>
<updated>2017-07-25T15:04:23+00:00</updated>
<author>
<name>Kamil Trzciński</name>
<email>ayufan@ayufan.eu</email>
</author>
<published>2017-07-25T15:04:23+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=ac948684fc9f4ded80a028ad2136cfbff90a4b45'/>
<id>ac948684fc9f4ded80a028ad2136cfbff90a4b45</id>
<content type='text'>
Implement "Block pipelines on protected branches"

Closes #30634, #34616, and #33130

See merge request !11910</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Implement "Block pipelines on protected branches"

Closes #30634, #34616, and #33130

See merge request !11910</pre>
</div>
</content>
</entry>
<entry>
<title>Allow admin to read_users_list even if it's restricted</title>
<updated>2017-07-25T08:49:26+00:00</updated>
<author>
<name>Lin Jen-Shin</name>
<email>godfat@godfat.org</email>
</author>
<published>2017-07-25T08:44:02+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=25e44edc30b5ca61267487248db9330da3e48a6c'/>
<id>25e44edc30b5ca61267487248db9330da3e48a6c</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Don't treat anonymous users as owners when group has pending invites</title>
<updated>2017-07-24T15:58:04+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2017-07-24T10:35:54+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=ccac2abeba419f16029c40f29063f1812c9e159c'/>
<id>ccac2abeba419f16029c40f29063f1812c9e159c</id>
<content type='text'>
The `members` table can have entries where `user_id: nil`, because people can
invite group members by email. We never want to include those as members,
because it might cause confusion with the anonymous (logged out) user.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The `members` table can have entries where `user_id: nil`, because people can
invite group members by email. We never want to include those as members,
because it might cause confusion with the anonymous (logged out) user.
</pre>
</div>
</content>
</entry>
<entry>
<title>Associate Issues tab only with internal issues tracker</title>
<updated>2017-07-24T06:10:14+00:00</updated>
<author>
<name>Jarka Kadlecova</name>
<email>jarka@gitlab.com</email>
</author>
<published>2017-06-13T08:25:25+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=2fa22a07296223c1239bfab94654487cca222097'/>
<id>2fa22a07296223c1239bfab94654487cca222097</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Rename :user_cannot_update to :protected_ref</title>
<updated>2017-07-18T14:13:57+00:00</updated>
<author>
<name>Lin Jen-Shin</name>
<email>godfat@godfat.org</email>
</author>
<published>2017-07-18T14:13:57+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=1ed6d1541c7973c08cdd4c1906ddcc0c3db893e3'/>
<id>1ed6d1541c7973c08cdd4c1906ddcc0c3db893e3</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Rename can_push_or_merge_to_branch? to can_update_branch?</title>
<updated>2017-07-18T13:56:28+00:00</updated>
<author>
<name>Lin Jen-Shin</name>
<email>godfat@godfat.org</email>
</author>
<published>2017-07-18T13:56:28+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=679789ee93b0e5db3863bfcd539e20074c140984'/>
<id>679789ee93b0e5db3863bfcd539e20074c140984</id>
<content type='text'>
Also make sure pipeline would also check against tag as well
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Also make sure pipeline would also check against tag as well
</pre>
</div>
</content>
</entry>
</feed>
