<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/app/models/user.rb, branch diff-notes-refactor</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Merge branch 'ee-1439-read-only-user' into 'master'</title>
<updated>2017-02-07T04:10:13+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@gitlab.com</email>
</author>
<published>2017-02-07T04:10:13+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=50f5960c72b4ff8b553bb0f7e8f649ac413f6ce0'/>
<id>50f5960c72b4ff8b553bb0f7e8f649ac413f6ce0</id>
<content type='text'>

Backport changes from gitlab-org/gitlab-ee!998

See merge request !8984</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Backport changes from gitlab-org/gitlab-ee!998

See merge request !8984</pre>
</div>
</content>
</entry>
<entry>
<title>Fix indentation</title>
<updated>2017-02-07T01:26:22+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@selenight.nl</email>
</author>
<published>2017-02-07T00:25:24+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=87cdb156ce51a1300f833c633b802b9be5c980d0'/>
<id>87cdb156ce51a1300f833c633b802b9be5c980d0</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Backport of the frontend view, including tests</title>
<updated>2017-02-06T22:17:46+00:00</updated>
<author>
<name>Jose Ivan Vargas</name>
<email>jvargas@gitlab.com</email>
</author>
<published>2017-02-06T21:38:08+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=426680def4bdeb7c6b37d8a0538fc73c39942495'/>
<id>426680def4bdeb7c6b37d8a0538fc73c39942495</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Don't delete assigned MRs/issues when user is deleted</title>
<updated>2017-02-06T19:45:41+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@selenight.nl</email>
</author>
<published>2017-01-18T23:13:28+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=08d4f0d654c757a4dc3018bf05959295beac882c'/>
<id>08d4f0d654c757a4dc3018bf05959295beac882c</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'dz-nested-groups-access-improvements' into 'master'</title>
<updated>2017-01-25T13:17:43+00:00</updated>
<author>
<name>Dmitriy Zaporozhets</name>
<email>dmitriy.zaporozhets@gmail.com</email>
</author>
<published>2017-01-25T13:17:43+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=8a9597fc737b9c848b8e1935551edb2f1d09aab0'/>
<id>8a9597fc737b9c848b8e1935551edb2f1d09aab0</id>
<content type='text'>

Nested groups feature improvemetns

See merge request !8448</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Nested groups feature improvemetns

See merge request !8448</pre>
</div>
</content>
</entry>
<entry>
<title>Add User#nested_groups and User#nested_projects methods</title>
<updated>2017-01-25T11:43:15+00:00</updated>
<author>
<name>Dmitriy Zaporozhets</name>
<email>dmitriy.zaporozhets@gmail.com</email>
</author>
<published>2017-01-05T17:20:12+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=52c5f9c97f20529b608f5b47a7c361383ccadb54'/>
<id>52c5f9c97f20529b608f5b47a7c361383ccadb54</id>
<content type='text'>
Signed-off-by: Dmitriy Zaporozhets &lt;dmitriy.zaporozhets@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Dmitriy Zaporozhets &lt;dmitriy.zaporozhets@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Fixing sort of Users so that users who never logged in will be displayed last</title>
<updated>2017-01-24T13:12:55+00:00</updated>
<author>
<name>Poornima M</name>
<email>poornima.malepati@gmail.com</email>
</author>
<published>2017-01-19T11:10:13+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=8354c76f39f5f922a23b294169f428ced87c75b5'/>
<id>8354c76f39f5f922a23b294169f428ced87c75b5</id>
<content type='text'>
Adding changelog entry
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Adding changelog entry
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove the project_authorizations.id column</title>
<updated>2017-01-08T12:56:50+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2017-01-06T17:26:06+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=de321fbbb55dab5bee8dc344d458230b74570d5d'/>
<id>de321fbbb55dab5bee8dc344d458230b74570d5d</id>
<content type='text'>
This column used to be a 32 bits integer, allowing for only a maximum of
2 147 483 647 rows. Given enough users one can hit this limit pretty
quickly, as was the case for GitLab.com.

Changing this type to bigint (= 64 bits) would give us more space, but
we'd eventually hit the same limit given enough users and projects. A
much more sustainable solution is to simply drop the "id" column.

There were only 2 lines of code depending on this column being present,
and neither truly required it to be present. Instead the code now uses
the "project_id" column combined with the "user_id" column. This means
that instead of something like this:

    DELETE FROM project_authorizations
    WHERE user_id = X
    AND id = Y;

We now run the following when removing rows:

    DELETE FROM project_authorizations
    WHERE user_id = X
    AND project_id = Y;

Since both user_id and project_id are indexed this should not slow down
the DELETE query.

This commit also removes the "dependent: destroy" clause from the
"project_authorizations" relation in the User and Project models.
Keeping this prevents Rails from being able to remove data as it relies
on an "id" column being present. Since the "project_authorizations"
table has proper foreign keys set up (with cascading removals) we don't
need to depend on any Rails logic.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This column used to be a 32 bits integer, allowing for only a maximum of
2 147 483 647 rows. Given enough users one can hit this limit pretty
quickly, as was the case for GitLab.com.

Changing this type to bigint (= 64 bits) would give us more space, but
we'd eventually hit the same limit given enough users and projects. A
much more sustainable solution is to simply drop the "id" column.

There were only 2 lines of code depending on this column being present,
and neither truly required it to be present. Instead the code now uses
the "project_id" column combined with the "user_id" column. This means
that instead of something like this:

    DELETE FROM project_authorizations
    WHERE user_id = X
    AND id = Y;

We now run the following when removing rows:

    DELETE FROM project_authorizations
    WHERE user_id = X
    AND project_id = Y;

Since both user_id and project_id are indexed this should not slow down
the DELETE query.

This commit also removes the "dependent: destroy" clause from the
"project_authorizations" relation in the User and Project models.
Keeping this prevents Rails from being able to remove data as it relies
on an "id" column being present. Since the "project_authorizations"
table has proper foreign keys set up (with cascading removals) we don't
need to depend on any Rails logic.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'add_email_password_confirmation' into 'master'</title>
<updated>2017-01-04T14:44:10+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@gitlab.com</email>
</author>
<published>2017-01-04T14:44:10+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=ce4258e991b6db0e400538bccf21ea10c4bc7b3a'/>
<id>ce4258e991b6db0e400538bccf21ea10c4bc7b3a</id>
<content type='text'>

Add email confirmation field to registration form

Closes #3053

See merge request !7432</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Add email confirmation field to registration form

Closes #3053

See merge request !7432</pre>
</div>
</content>
</entry>
<entry>
<title>Fix cross-project references copy to include the project reference</title>
<updated>2017-01-03T12:01:46+00:00</updated>
<author>
<name>James Lopez</name>
<email>james@jameslopez.es</email>
</author>
<published>2016-12-21T16:41:33+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=112f47057275312daa876bee5bd74d5464410bc5'/>
<id>112f47057275312daa876bee5bd74d5464410bc5</id>
<content type='text'>
Also added relevant specs and refactored to_references in a bunch of places to be more consistent.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Also added relevant specs and refactored to_references in a bunch of places to be more consistent.
</pre>
</div>
</content>
</entry>
</feed>
