<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/app/models/remote_mirror.rb, branch docs/fix-deploy-example</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Mark mirrors as failed 1 hour after they started</title>
<updated>2019-07-23T14:04:49+00:00</updated>
<author>
<name>Bob Van Landuyt</name>
<email>bob@vanlanduyt.co</email>
</author>
<published>2019-07-19T15:28:23+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=ab11eee1d6e3881399b671f0ebe857a085321371'/>
<id>ab11eee1d6e3881399b671f0ebe857a085321371</id>
<content type='text'>
We call `Project#mark_stuck_remote_mirrors_as_failed!` from the
`Git::BaseHooksService`. So that gets called every time we push tags
or branches.

Before this would only mark started mirrors as failed if they had
been started 24 hours ago. A push would never take 24 hours,
especially not when we run it so often.

Lowering that threshold 1 hour should at least allow us to retry
broken mirrors more often on pushes.

The timeout for the initial push is set somewhat longer to accommodate
for pushing large repos. Both numbers are currently picked arbitrarily.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We call `Project#mark_stuck_remote_mirrors_as_failed!` from the
`Git::BaseHooksService`. So that gets called every time we push tags
or branches.

Before this would only mark started mirrors as failed if they had
been started 24 hours ago. A push would never take 24 hours,
especially not when we run it so often.

Lowering that threshold 1 hour should at least allow us to retry
broken mirrors more often on pushes.

The timeout for the initial push is set somewhat longer to accommodate
for pushing large repos. Both numbers are currently picked arbitrarily.
</pre>
</div>
</content>
</entry>
<entry>
<title>Show disabled project repo mirrors</title>
<updated>2019-05-07T02:42:09+00:00</updated>
<author>
<name>Luke Bennett</name>
<email>lbennett@gitlab.com</email>
</author>
<published>2019-03-21T22:24:48+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=875338487343b092f670ab5e0323904ec5457a3a'/>
<id>875338487343b092f670ab5e0323904ec5457a3a</id>
<content type='text'>
Show disabled mirrors with a badge so that they
can be deleted by project owners.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Show disabled mirrors with a badge so that they
can be deleted by project owners.
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove deprecated uses of attribute_changed?</title>
<updated>2019-04-30T07:24:25+00:00</updated>
<author>
<name>Heinrich Lee Yu</name>
<email>heinrich@gitlab.com</email>
</author>
<published>2019-04-23T09:30:18+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=fc22626f453f64409ad5b2967cdec541dbcc041d'/>
<id>fc22626f453f64409ad5b2967cdec541dbcc041d</id>
<content type='text'>
Prepares us for upgrade to Rails 5.2
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Prepares us for upgrade to Rails 5.2
</pre>
</div>
</content>
</entry>
<entry>
<title>Upgrade Rails to 5.1.6.1</title>
<updated>2019-04-23T00:31:23+00:00</updated>
<author>
<name>Jasper Maes</name>
<email>jaspermaes.jm@gmail.com</email>
</author>
<published>2019-01-15T21:05:36+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=624a1cdab4da67c7b363602aa1178d0e6ff63475'/>
<id>624a1cdab4da67c7b363602aa1178d0e6ff63475</id>
<content type='text'>
Model.new.attributes now also returns encrypted attributes.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Model.new.attributes now also returns encrypted attributes.
</pre>
</div>
</content>
</entry>
<entry>
<title>Align UrlValidator to validate_url gem implementation.</title>
<updated>2019-04-11T06:29:07+00:00</updated>
<author>
<name>Thong Kuah</name>
<email>tkuah@gitlab.com</email>
</author>
<published>2019-04-11T06:29:07+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d119d3d1b25aac661e6251addf87b280bd37f0c5'/>
<id>d119d3d1b25aac661e6251addf87b280bd37f0c5</id>
<content type='text'>
Renamed UrlValidator to AddressableUrlValidator to avoid 'url:' naming collision with ActiveModel::Validations::UrlValidator in 'validates' statement.
Make use of the options attribute of the parent class ActiveModel::EachValidator.
Add more options: allow_nil, allow_blank, message.
Renamed 'protocols' option to 'schemes' to match the option naming from UrlValidator.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Renamed UrlValidator to AddressableUrlValidator to avoid 'url:' naming collision with ActiveModel::Validations::UrlValidator in 'validates' statement.
Make use of the options attribute of the parent class ActiveModel::EachValidator.
Add more options: allow_nil, allow_blank, message.
Renamed 'protocols' option to 'schemes' to match the option naming from UrlValidator.
</pre>
</div>
</content>
</entry>
<entry>
<title>Inherit from ApplicationRecord instead of ActiveRecord::Base</title>
<updated>2019-03-28T16:18:23+00:00</updated>
<author>
<name>Nick Thomas</name>
<email>nick@gitlab.com</email>
</author>
<published>2019-03-28T13:17:42+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=013f7cd24c4359d5d704b719d85b6df7ca1fdd55'/>
<id>013f7cd24c4359d5d704b719d85b6df7ca1fdd55</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Only send one notification for failed remote mirror</title>
<updated>2019-01-15T08:15:40+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2019-01-15T06:33:48+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=6fbbd4ab393f0d56b8636b407a38273b4c77b3db'/>
<id>6fbbd4ab393f0d56b8636b407a38273b4c77b3db</id>
<content type='text'>
Retries in Sidekiq and in the remote mirror scheduler can cause repeated
attempts in quick succession if the sync fails. Each failure will then
send an e-mail to all project maintainers, which can spam users
unnecessarily.

Modify the logic to send one notification the first time the mirror
fails by setting `error_notification_sent` to `true` and reset the
flag after a successful sync.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/56222
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Retries in Sidekiq and in the remote mirror scheduler can cause repeated
attempts in quick succession if the sync fails. Each failure will then
send an e-mail to all project maintainers, which can spam users
unnecessarily.

Modify the logic to send one notification the first time the mirror
fails by setting `error_notification_sent` to `true` and reset the
flag after a successful sync.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/56222
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'security-fix-ssrf-import-url-remote-mirror' into 'master'</title>
<updated>2019-01-01T20:38:37+00:00</updated>
<author>
<name>John Jarvis</name>
<email>jarv@gitlab.com</email>
</author>
<published>2019-01-01T20:38:37+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=e4dabec82a8f375389b9bb52b8fe6b1ac304d74e'/>
<id>e4dabec82a8f375389b9bb52b8fe6b1ac304d74e</id>
<content type='text'>
[master] SSRF - Scan Internal Ports and GCP/AWS endpoints

See merge request gitlab/gitlabhq!2689</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
[master] SSRF - Scan Internal Ports and GCP/AWS endpoints

See merge request gitlab/gitlabhq!2689</pre>
</div>
</content>
</entry>
<entry>
<title>Replaced UrlValidator with PublicUrlValidator for import_url and remote mirror urls</title>
<updated>2018-12-13T07:57:04+00:00</updated>
<author>
<name>Francisco Javier López</name>
<email>fjlopez@gitlab.com</email>
</author>
<published>2018-12-10T16:23:52+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=63c48f73803cf1c68d6c9af408f877ea61781118'/>
<id>63c48f73803cf1c68d6c9af408f877ea61781118</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Send a notification email on mirror update errors</title>
<updated>2018-12-12T02:08:17+00:00</updated>
<author>
<name>Alejandro Rodríguez</name>
<email>alejorro70@gmail.com</email>
</author>
<published>2018-12-05T15:22:52+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=b65cb237cee0b1a8dfdc21a09f2b181d0edf5bde'/>
<id>b65cb237cee0b1a8dfdc21a09f2b181d0edf5bde</id>
<content type='text'>
The email is sent to project maintainers containing the last mirror
update error. This will allow maintainers to set alarms and react
accordingly.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The email is sent to project maintainers containing the last mirror
update error. This will allow maintainers to set alarms and react
accordingly.
</pre>
</div>
</content>
</entry>
</feed>
