<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/app/models/project_services, branch commit-limits</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Revert "Merge branch 'issue_5854' into 'master'"</title>
<updated>2016-02-29T17:30:41+00:00</updated>
<author>
<name>Dmitriy Zaporozhets</name>
<email>dmitriy.zaporozhets@gmail.com</email>
</author>
<published>2016-02-29T17:30:41+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=e7364050b03593618da1e6a14784d63d6abc3849'/>
<id>e7364050b03593618da1e6a14784d63d6abc3849</id>
<content type='text'>
This reverts merge request !2992</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This reverts merge request !2992</pre>
</div>
</content>
</entry>
<entry>
<title>Add commit message to JIRA's notification payload.</title>
<updated>2016-02-27T01:11:34+00:00</updated>
<author>
<name>Rubén Dávila</name>
<email>rdavila84@gmail.com</email>
</author>
<published>2016-02-27T01:11:34+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=496b9c0761571da61cfa9245785446a27348e069'/>
<id>496b9c0761571da61cfa9245785446a27348e069</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Use project.web_url instead deprecated repository.homepage in PushoverService</title>
<updated>2016-02-16T12:03:00+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2016-02-16T12:03:00+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=1de95137906e1b262eeaf2d627469c9a1e47a536'/>
<id>1de95137906e1b262eeaf2d627469c9a1e47a536</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Greatly improve external_issue_tracker performance</title>
<updated>2016-01-19T13:03:20+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2016-01-19T12:48:07+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=b4ee6f57b9322401d1439eb21f9160ae2cb91d14'/>
<id>b4ee6f57b9322401d1439eb21f9160ae2cb91d14</id>
<content type='text'>
This greatly improves the performance of Project#external_issue_tracker
by moving most of the fields queried in Ruby to the database and letting
the database handle all logic. Prior to this change the process of
finding an external issue tracker was along the lines of the following:

1. Load all project services into memory.
2. Reduce the list to only services where "issue_tracker?" returns true
3. Reduce the list from step 2 to service where "default?" returns false
4. Find the first service where "activated?" returns true

This has to two big problems:

1. Loading all services into memory only to reduce the list down to a
   single item later on is a waste of memory (and slow timing wise).
2. Calling Array#select followed by Array#reject followed by Array#find
   allocates extra objects when this really isn't needed.

To work around this the following service fields have been moved to the
database (instead of being hardcoded):

* category
* default

This in turn means we can get the external issue tracker using the
following query:

    SELECT *
    FROM services
    WHERE active IS TRUE
    AND default IS FALSE
    AND category = 'issue_tracker'
    AND project_id = XXX
    LIMIT 1

This coupled with memoizing the result (just as before this commit)
greatly reduces the time it takes for Project#external_issue_tracker to
complete. The exact reduction depends on one's environment, but locally
the execution time is reduced from roughly 230 ms to only 2 ms (= a
reduction of almost 180x).

Fixes gitlab-org/gitlab-ce#10771
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This greatly improves the performance of Project#external_issue_tracker
by moving most of the fields queried in Ruby to the database and letting
the database handle all logic. Prior to this change the process of
finding an external issue tracker was along the lines of the following:

1. Load all project services into memory.
2. Reduce the list to only services where "issue_tracker?" returns true
3. Reduce the list from step 2 to service where "default?" returns false
4. Find the first service where "activated?" returns true

This has to two big problems:

1. Loading all services into memory only to reduce the list down to a
   single item later on is a waste of memory (and slow timing wise).
2. Calling Array#select followed by Array#reject followed by Array#find
   allocates extra objects when this really isn't needed.

To work around this the following service fields have been moved to the
database (instead of being hardcoded):

* category
* default

This in turn means we can get the external issue tracker using the
following query:

    SELECT *
    FROM services
    WHERE active IS TRUE
    AND default IS FALSE
    AND category = 'issue_tracker'
    AND project_id = XXX
    LIMIT 1

This coupled with memoizing the result (just as before this commit)
greatly reduces the time it takes for Project#external_issue_tracker to
complete. The exact reduction depends on one's environment, but locally
the execution time is reduced from roughly 230 ms to only 2 ms (= a
reduction of almost 180x).

Fixes gitlab-org/gitlab-ce#10771
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'fix/reference_filter_uri_decode_error_for_master' into 'master'</title>
<updated>2016-01-13T14:21:32+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@gitlab.com</email>
</author>
<published>2016-01-13T14:21:32+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=c7d9e7806a2cfb887533e1fab24a8340988272d4'/>
<id>c7d9e7806a2cfb887533e1fab24a8340988272d4</id>
<content type='text'>

Fix #9963 reference_filter "Encoding::CompatibilityError" bug with some complex URL;

https://github.com/gitlabhq/gitlabhq/pull/9964

@DouweM

See merge request !2383</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Fix #9963 reference_filter "Encoding::CompatibilityError" bug with some complex URL;

https://github.com/gitlabhq/gitlabhq/pull/9964

@DouweM

See merge request !2383</pre>
</div>
</content>
</entry>
<entry>
<title>Mention channel/key bug in irkerd docs</title>
<updated>2016-01-12T22:54:09+00:00</updated>
<author>
<name>Landon</name>
<email>landogbland@gmail.com</email>
</author>
<published>2016-01-12T22:54:09+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=4819de1e7026849e10a0a05939152dfa01b5ba85'/>
<id>4819de1e7026849e10a0a05939152dfa01b5ba85</id>
<content type='text'>
Per this issue: https://gitlab.com/esr/irker/issues/2

A documentation update was added to irkerd (https://gitlab.com/esr/irker/commit/190808c37d4ab5f0f16fe35352ff36863c2732d5) but the bug is still there. Making a note of it here could save someone a lot of hassle. 

This could probably be worded better if someone else wants to take a stab at it.</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Per this issue: https://gitlab.com/esr/irker/issues/2

A documentation update was added to irkerd (https://gitlab.com/esr/irker/commit/190808c37d4ab5f0f16fe35352ff36863c2732d5) but the bug is still there. Making a note of it here could save someone a lot of hassle. 

This could probably be worded better if someone else wants to take a stab at it.</pre>
</div>
</content>
</entry>
<entry>
<title>Use CGI.escape instead of URI.escape, because URI is obsoleted.</title>
<updated>2016-01-12T10:20:03+00:00</updated>
<author>
<name>Jason Lee</name>
<email>huacnlee@gmail.com</email>
</author>
<published>2016-01-12T09:32:25+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=932a247f5fb4a14b3e096ec88a73f8fce481eebb'/>
<id>932a247f5fb4a14b3e096ec88a73f8fce481eebb</id>
<content type='text'>
ref: https://github.com/ruby/ruby/commit/238b979f1789f95262a267d8df6239806f2859cc
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
ref: https://github.com/ruby/ruby/commit/238b979f1789f95262a267d8df6239806f2859cc
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'fix_jira_shortterm' into 'master'</title>
<updated>2016-01-10T22:12:10+00:00</updated>
<author>
<name>Robert Speicher</name>
<email>robert@gitlab.com</email>
</author>
<published>2016-01-10T22:12:10+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=4de89291a3c487f41ffe6ebd41877ba7a709d243'/>
<id>4de89291a3c487f41ffe6ebd41877ba7a709d243</id>
<content type='text'>

Do not call API if there is no API URL

Fixes #5878 

CE users may not be interested in the new JIRA features. In this case,
we should detect they haven't set an API URL and fallback to the
behavior pre-8.3. This patch does that very easily.

There are planned improvements to JIRA in future releases such as
gitlab-org/gitlab-ce#5541 which will make this more configurable.

See merge request !2341</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Do not call API if there is no API URL

Fixes #5878 

CE users may not be interested in the new JIRA features. In this case,
we should detect they haven't set an API URL and fallback to the
behavior pre-8.3. This patch does that very easily.

There are planned improvements to JIRA in future releases such as
gitlab-org/gitlab-ce#5541 which will make this more configurable.

See merge request !2341</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'suppress-allow-failure-builds' into 'master'</title>
<updated>2016-01-08T17:31:35+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2016-01-08T17:31:35+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=7403df6ca7bd31cd002d6fcf3bf4aa02dd4478eb'/>
<id>7403df6ca7bd31cd002d6fcf3bf4aa02dd4478eb</id>
<content type='text'>

Suppress e-mails on failed builds if allow_failure is set

Every time I push to GitLab, I get &gt; 2 emails saying a spec failed when I don't care about the benchmarks and others that have `allow_failure` set to `true`.

@ayufan mentioned creating a summary e-mail to prevent getting one e-mail per build, but the latter might actually be desirable. For example, I do want to know if Rubocop errors fail right away.

See merge request !2178</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Suppress e-mails on failed builds if allow_failure is set

Every time I push to GitLab, I get &gt; 2 emails saying a spec failed when I don't care about the benchmarks and others that have `allow_failure` set to `true`.

@ayufan mentioned creating a summary e-mail to prevent getting one e-mail per build, but the latter might actually be desirable. For example, I do want to know if Rubocop errors fail right away.

See merge request !2178</pre>
</div>
</content>
</entry>
<entry>
<title>Remove useless assignment to variable</title>
<updated>2016-01-08T14:22:42+00:00</updated>
<author>
<name>Achilleas Pipinellis</name>
<email>axilleas@axilleas.me</email>
</author>
<published>2016-01-08T14:22:42+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d09f1a4443696cdd7187ba855da26e57905ef422'/>
<id>d09f1a4443696cdd7187ba855da26e57905ef422</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
