<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/app/models/note.rb, branch docs-sethgitlab-dast</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Merge branch 'remove-ignorable-column-concern' into 'master'</title>
<updated>2019-08-30T21:59:31+00:00</updated>
<author>
<name>Michael Kozono</name>
<email>mkozono@gmail.com</email>
</author>
<published>2019-08-30T21:59:31+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=88c6423e4a45103cc480467bc8f412a48e1e0b55'/>
<id>88c6423e4a45103cc480467bc8f412a48e1e0b55</id>
<content type='text'>
Remove dependency on IgnorableColumn concern

Closes #66746

See merge request gitlab-org/gitlab-ce!32427</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Remove dependency on IgnorableColumn concern

Closes #66746

See merge request gitlab-org/gitlab-ce!32427</pre>
</div>
</content>
</entry>
<entry>
<title>Use self.ignored_columns += instead of =</title>
<updated>2019-08-30T20:15:34+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2019-08-29T23:10:49+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d93b985df07ccf07541efef709edb8467e0f2955'/>
<id>d93b985df07ccf07541efef709edb8467e0f2955</id>
<content type='text'>
This is to accomodate prepended modules.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This is to accomodate prepended modules.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'security-epic-notes-api-reveals-historical-info-ce-master' into 'master'</title>
<updated>2019-08-29T21:34:24+00:00</updated>
<author>
<name>GitLab Release Tools Bot</name>
<email>robert+release-tools@gitlab.com</email>
</author>
<published>2019-08-29T21:34:24+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=5a008d136840b5c7fd5688060efa73dd1b5491ab'/>
<id>5a008d136840b5c7fd5688060efa73dd1b5491ab</id>
<content type='text'>
Filter out old system notes for epics in notes api endpoint response

See merge request gitlab/gitlabhq!3224</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Filter out old system notes for epics in notes api endpoint response

See merge request gitlab/gitlabhq!3224</pre>
</div>
</content>
</entry>
<entry>
<title>Remove dependency on IgnorableColumn concern</title>
<updated>2019-08-29T20:39:13+00:00</updated>
<author>
<name>dineshpanda</name>
<email>dineshpanda92@gmail.com</email>
</author>
<published>2019-08-29T20:39:13+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=fa6f19d1f83b68f2bb729be889ab7d66adbbedb8'/>
<id>fa6f19d1f83b68f2bb729be889ab7d66adbbedb8</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Filter out old system notes for epics</title>
<updated>2019-08-28T13:04:23+00:00</updated>
<author>
<name>Patrick Derichs</name>
<email>pderichs@gitlab.com</email>
</author>
<published>2019-08-09T12:54:57+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=c9b4dc677abdebc02ecac4dca65a759d3f07b2a0'/>
<id>c9b4dc677abdebc02ecac4dca65a759d3f07b2a0</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Limit the size of issuable description and comments</title>
<updated>2019-08-22T07:43:13+00:00</updated>
<author>
<name>Alexandru Croitor</name>
<email>acroitor@gitlab.com</email>
</author>
<published>2019-07-17T09:54:40+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=5af535d919c50951513f5859730afd924a01c29b'/>
<id>5af535d919c50951513f5859730afd924a01c29b</id>
<content type='text'>
Limiting the size of issuable description and comments to 1_000_000,
which is close to ~1MB of ASCII characters, which represents 99.9% of
all descriptions and comments we have in DB at the moment. This should
help prevent DoS attacks when comments contain refference strings.

Also this change updates regexp matching the namespaces paths by
limiting the namespaces paths to Namespace::NUMBER_OF_ANCESTORS_ALLOWED,
as we allow 20 levels deep groups.

see https://gitlab.com/gitlab-org/gitlab-ce/issues/61974#note_191274234
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Limiting the size of issuable description and comments to 1_000_000,
which is close to ~1MB of ASCII characters, which represents 99.9% of
all descriptions and comments we have in DB at the moment. This should
help prevent DoS attacks when comments contain refference strings.

Also this change updates regexp matching the namespaces paths by
limiting the namespaces paths to Namespace::NUMBER_OF_ANCESTORS_ALLOWED,
as we allow 20 levels deep groups.

see https://gitlab.com/gitlab-org/gitlab-ce/issues/61974#note_191274234
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix first-time contributor notes not rendering</title>
<updated>2019-07-31T13:52:11+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2019-07-31T13:49:56+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=3d9c28af9331feb279053113677af2633e4b8e91'/>
<id>3d9c28af9331feb279053113677af2633e4b8e91</id>
<content type='text'>
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31117 enabled the
HashInefficientHash Rubocop rule that was fooled by the special
implementation of `SpecialRole`. We fix this by introducing a
`value?` method and adding unit tests.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/65383
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31117 enabled the
HashInefficientHash Rubocop rule that was fooled by the special
implementation of `SpecialRole`. We fix this by introducing a
`value?` method and adding unit tests.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/65383
</pre>
</div>
</content>
</entry>
<entry>
<title>Enable Rubocop Performance/InefficientHashSearch</title>
<updated>2019-07-24T18:47:58+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2019-07-24T18:11:18+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=3e001d29ccdb5a5b1ba223710525f8dc7ae844ee'/>
<id>3e001d29ccdb5a5b1ba223710525f8dc7ae844ee</id>
<content type='text'>
When used with a Hash, `.keys.include?` is bad because:

1. It performs a O(n) search instead of the efficient `.has_key?`
2. It clones all keys into separate array.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/64975
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When used with a Hash, `.keys.include?` is bad because:

1. It performs a O(n) search instead of the efficient `.has_key?`
2. It clones all keys into separate array.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/64975
</pre>
</div>
</content>
</entry>
<entry>
<title>GraphQL support for Notes created in discussions</title>
<updated>2019-07-10T00:13:48+00:00</updated>
<author>
<name>Luke Duncalfe</name>
<email>lduncalfe@eml.cc</email>
</author>
<published>2019-07-04T03:33:14+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=073c8b25ea36b6b96eab05eb675e8726b1d5318e'/>
<id>073c8b25ea36b6b96eab05eb675e8726b1d5318e</id>
<content type='text'>
A new `discussion_id` argument on the `createNote` mutation allows
people to create a note within that discussion.

The ability to lazy-load Discussions has been added, so
GraphQL.object_from_id can treat Discussions the same as AR objects and
batch load them.

https://gitlab.com/gitlab-org/gitlab-ce/issues/62826
https://gitlab.com/gitlab-org/gitlab-ee/issues/9489
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
A new `discussion_id` argument on the `createNote` mutation allows
people to create a note within that discussion.

The ability to lazy-load Discussions has been added, so
GraphQL.object_from_id can treat Discussions the same as AR objects and
batch load them.

https://gitlab.com/gitlab-org/gitlab-ce/issues/62826
https://gitlab.com/gitlab-org/gitlab-ee/issues/9489
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix typo in code comments about Elasticsearch</title>
<updated>2019-06-28T11:01:15+00:00</updated>
<author>
<name>Takuya Noguchi</name>
<email>takninnovationresearch@gmail.com</email>
</author>
<published>2019-06-28T10:58:04+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=7d76128de945c565e64f9e578be7543be0968e45'/>
<id>7d76128de945c565e64f9e578be7543be0968e45</id>
<content type='text'>
Signed-off-by: Takuya Noguchi &lt;takninnovationresearch@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Takuya Noguchi &lt;takninnovationresearch@gmail.com&gt;
</pre>
</div>
</content>
</entry>
</feed>
