delta/gitlab/gitlab-ce.git/app/models/namespace.rb, branch gitlab-git-popen

Fix setting share_with_group_lock

2017-09-15T15:38:46+00:00

Prior to this commit running
Namespace#force_share_with_group_lock_on_descendants would result in
updating _all_ namespaces in the namespaces table, not just the
descendants. This is the result of ActiveRecord::Relation#update_all not
taking into account the CTE. To work around this we use the CTE query as
a sub-query instead of directly calling #update_all.

To prevent this from happening the relations returned by
Gitlab::GroupHierarchy are now marked as read-only, resulting in an
error being raised when methods such as #update_all are used.

Fortunately on GitLab.com our statement timeouts appear to have
prevented this query from actually doing any damage other than causing
a very large amount of dead tuples.

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/37916

Refactor based on code review

2017-09-06T19:07:21+00:00

Enable share_with_group_lock on subgroup

2017-09-06T19:07:20+00:00

…when needed

Don't show references to Pages when not available

2017-08-31T07:27:42+00:00

In this instance its subgroups, and given we can't deploy it, we
shouldn't allow it to be shown.

Fixes gitlab-org/gitlab-ce#34864

Speed up Group#user_ids_for_project_authorizations

2017-08-14T11:47:15+00:00

Small refactor in LegacyNamespace and moved back send_update_instructions

2017-08-01T05:45:04+00:00

Move storage specific code from Namespace and Project to concerns

2017-08-01T05:26:58+00:00

Promote visibility level helpers from Group to Namespace

2017-07-17T10:54:07+00:00

In EE, we make use of `namespace#public?` in projects. When the project is in a
personal namespace, this breaks as the `public?` helper isn't present.

Added Cop to blacklist the use of `dependent:`

2017-07-06T10:01:36+00:00

This is allowed for existing instances so we don't end up 76 offenses
right away, but for new code one should _only_ use this if they _have_
to remove non database data. Even then it's usually better to do this in
a service class as this gives you more control over how to remove the
data (e.g. in bulk).

Defer project destroys within a namespace in Groups::DestroyService#async_execute

2017-06-29T16:23:31+00:00

Group#destroy would actually hard-delete all associated projects even
though the acts_as_paranoia gem is used, preventing Projects::DestroyService
from doing any work.

We first noticed this while trying to log all projects deletion to the Geo
log.