<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/app/models/members, branch docs/nested-groups</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Enable Rails/Validation</title>
<updated>2017-02-23T15:31:57+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@selenight.nl</email>
</author>
<published>2017-02-22T00:40:04+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=5cd9c7c6ea1ba5c6ad40799b9476145803dccba5'/>
<id>5cd9c7c6ea1ba5c6ad40799b9476145803dccba5</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Enable Style/MutableConstant</title>
<updated>2017-02-23T15:31:56+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@selenight.nl</email>
</author>
<published>2017-02-21T23:32:18+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=b7d8df503cf35b3048b273dc0cadb5ec39aac5e1'/>
<id>b7d8df503cf35b3048b273dc0cadb5ec39aac5e1</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove redundant class_name and foreign_key overrides</title>
<updated>2016-10-24T20:29:48+00:00</updated>
<author>
<name>David Wagner</name>
<email>david@marvid.fr</email>
</author>
<published>2016-10-18T21:20:36+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=03b6108f6f293830e50d113068877be155549fdd'/>
<id>03b6108f6f293830e50d113068877be155549fdd</id>
<content type='text'>
They were Rails' default and are unnecessarily overridden.

Signed-off-by: David Wagner &lt;david@marvid.fr&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
They were Rails' default and are unnecessarily overridden.

Signed-off-by: David Wagner &lt;david@marvid.fr&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Differentiate the expire from leave event</title>
<updated>2016-10-20T00:26:45+00:00</updated>
<author>
<name>Callum Dryden</name>
<email>callum.dryden@rightscale.com</email>
</author>
<published>2016-10-06T15:19:27+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=9124310f2871117acaac98781be84c9fc016e2ad'/>
<id>9124310f2871117acaac98781be84c9fc016e2ad</id>
<content type='text'>
At the moment we cannot see weather a user left a project due to their
membership expiring of if they themselves opted to leave the project.
This adds a new event type that allows us to make this differentiation.
Note that is not really feasable to go back and reliably fix up the
previous events. As a result the events for previous expire removals
will remain the same however events of this nature going forward will be
correctly represented.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
At the moment we cannot see weather a user left a project due to their
membership expiring of if they themselves opted to leave the project.
This adds a new event type that allows us to make this differentiation.
Note that is not really feasable to go back and reliably fix up the
previous events. As a result the events for previous expire removals
will remain the same however events of this nature going forward will be
correctly represented.
</pre>
</div>
</content>
</entry>
<entry>
<title>Allow Member.add_user to handle access requesters</title>
<updated>2016-09-28T07:43:00+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2016-09-16T15:54:21+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=ec0061a95cbba02286b2c143048c93d8f26ff5f0'/>
<id>ec0061a95cbba02286b2c143048c93d8f26ff5f0</id>
<content type='text'>
Changes include:

- Ensure Member.add_user is not called directly when not necessary
- New GroupMember.add_users_to_group to have the same abstraction level as for Project
- Refactor Member.add_user to take a source instead of an array of members
- Fix Rubocop offenses
- Always use Project#add_user instead of project.team.add_user
- Factorize users addition as members in Member.add_users_to_source
- Make access_level a keyword argument in GroupMember.add_users_to_group and ProjectMember.add_users_to_projects
- Destroy any requester before adding them as a member
- Improve the way we handle access requesters in Member.add_user
  Instead of removing the requester and creating a new member,
  we now simply accepts their access request. This way, they will
  receive a "access request granted" email.
- Fix error that was previously silently ignored
- Stop raising when access level is invalid in Member, let Rails validation do their work

Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Changes include:

- Ensure Member.add_user is not called directly when not necessary
- New GroupMember.add_users_to_group to have the same abstraction level as for Project
- Refactor Member.add_user to take a source instead of an array of members
- Fix Rubocop offenses
- Always use Project#add_user instead of project.team.add_user
- Factorize users addition as members in Member.add_users_to_source
- Make access_level a keyword argument in GroupMember.add_users_to_group and ProjectMember.add_users_to_projects
- Destroy any requester before adding them as a member
- Improve the way we handle access requesters in Member.add_user
  Instead of removing the requester and creating a new member,
  we now simply accepts their access request. This way, they will
  receive a "access request granted" email.
- Fix error that was previously silently ignored
- Stop raising when access level is invalid in Member, let Rails validation do their work

Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'master' into expiration-date-on-memberships</title>
<updated>2016-08-18T14:54:07+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2016-08-18T14:49:32+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=8b1656282bcc39a0c1c7a3dccf74c98b1c3adae2'/>
<id>8b1656282bcc39a0c1c7a3dccf74c98b1c3adae2</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>New AccessRequests API endpoints for Group &amp; Project</title>
<updated>2016-08-10T17:07:05+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2016-06-23T15:14:31+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=29850364eccccc3ce7305f6706cea1d5d073de2e'/>
<id>29850364eccccc3ce7305f6706cea1d5d073de2e</id>
<content type='text'>
Also, mutualize AccessRequests and Members endpoints for Group &amp;
Project.
New API documentation for the AccessRequests endpoints.

Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Also, mutualize AccessRequests and Members endpoints for Group &amp;
Project.
New API documentation for the AccessRequests endpoints.

Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix Rename `add_users_into_project` and `projects_ids`</title>
<updated>2016-08-04T11:55:50+00:00</updated>
<author>
<name>Herminio Torres</name>
<email>herminiocesar@gmail.com</email>
</author>
<published>2016-08-04T04:35:17+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=f15ed5f0a5c298a2f0eb5aaa6d848364133532a5'/>
<id>f15ed5f0a5c298a2f0eb5aaa6d848364133532a5</id>
<content type='text'>
We never add things `into` projects, we just add them `to` projects. So how about we rename this to `add_users_to_project`.

Rename `projects_ids` to `project_ids` by following the convention of rails.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We never add things `into` projects, we just add them `to` projects. So how about we rename this to `add_users_to_project`.

Rename `projects_ids` to `project_ids` by following the convention of rails.
</pre>
</div>
</content>
</entry>
<entry>
<title>Replace optional parameters with keyword arguments.</title>
<updated>2016-08-02T18:37:22+00:00</updated>
<author>
<name>Adam Niedzielski</name>
<email>adamsunday@gmail.com</email>
</author>
<published>2016-08-02T18:37:22+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=b2c8dc6f35ceb08e23422a356831070b5136809d'/>
<id>b2c8dc6f35ceb08e23422a356831070b5136809d</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>WIP</title>
<updated>2016-08-01T18:12:30+00:00</updated>
<author>
<name>Adam Niedzielski</name>
<email>adamsunday@gmail.com</email>
</author>
<published>2016-08-01T18:12:30+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=6d92cd3e836f2252b660479f5b33d15e6456b04d'/>
<id>6d92cd3e836f2252b660479f5b33d15e6456b04d</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
