delta/gitlab/gitlab-ce.git/app/models/members, branch ci-https gitlab.com: gitlab-org/gitlab-ce.git Allow Member.add_user to handle access requesters 2016-09-28T07:43:00+00:00 Rémy Coutable remy@rymai.me 2016-09-16T15:54:21+00:00 ec0061a95cbba02286b2c143048c93d8f26ff5f0 Changes include: - Ensure Member.add_user is not called directly when not necessary - New GroupMember.add_users_to_group to have the same abstraction level as for Project - Refactor Member.add_user to take a source instead of an array of members - Fix Rubocop offenses - Always use Project#add_user instead of project.team.add_user - Factorize users addition as members in Member.add_users_to_source - Make access_level a keyword argument in GroupMember.add_users_to_group and ProjectMember.add_users_to_projects - Destroy any requester before adding them as a member - Improve the way we handle access requesters in Member.add_user Instead of removing the requester and creating a new member, we now simply accepts their access request. This way, they will receive a "access request granted" email. - Fix error that was previously silently ignored - Stop raising when access level is invalid in Member, let Rails validation do their work Signed-off-by: Rémy Coutable <remy@rymai.me> 
Changes include:

- Ensure Member.add_user is not called directly when not necessary
- New GroupMember.add_users_to_group to have the same abstraction level as for Project
- Refactor Member.add_user to take a source instead of an array of members
- Fix Rubocop offenses
- Always use Project#add_user instead of project.team.add_user
- Factorize users addition as members in Member.add_users_to_source
- Make access_level a keyword argument in GroupMember.add_users_to_group and ProjectMember.add_users_to_projects
- Destroy any requester before adding them as a member
- Improve the way we handle access requesters in Member.add_user
  Instead of removing the requester and creating a new member,
  we now simply accepts their access request. This way, they will
  receive a "access request granted" email.
- Fix error that was previously silently ignored
- Stop raising when access level is invalid in Member, let Rails validation do their work

Signed-off-by: Rémy Coutable <remy@rymai.me>
Merge branch 'master' into expiration-date-on-memberships 2016-08-18T14:54:07+00:00 Sean McGivern sean@gitlab.com 2016-08-18T14:49:32+00:00 8b1656282bcc39a0c1c7a3dccf74c98b1c3adae2 






New AccessRequests API endpoints for Group & Project
2016-08-10T17:07:05+00:00

Rémy Coutable
remy@rymai.me

2016-06-23T15:14:31+00:00

29850364eccccc3ce7305f6706cea1d5d073de2e

Also, mutualize AccessRequests and Members endpoints for Group &
Project.
New API documentation for the AccessRequests endpoints.

Signed-off-by: Rémy Coutable <remy@rymai.me>





Also, mutualize AccessRequests and Members endpoints for Group &
Project.
New API documentation for the AccessRequests endpoints.

Signed-off-by: Rémy Coutable <remy@rymai.me>







Fix Rename `add_users_into_project` and `projects_ids`
2016-08-04T11:55:50+00:00

Herminio Torres
herminiocesar@gmail.com

2016-08-04T04:35:17+00:00

f15ed5f0a5c298a2f0eb5aaa6d848364133532a5

We never add things `into` projects, we just add them `to` projects. So how about we rename this to `add_users_to_project`.

Rename `projects_ids` to `project_ids` by following the convention of rails.





We never add things `into` projects, we just add them `to` projects. So how about we rename this to `add_users_to_project`.

Rename `projects_ids` to `project_ids` by following the convention of rails.







Replace optional parameters with keyword arguments.
2016-08-02T18:37:22+00:00

Adam Niedzielski
adamsunday@gmail.com

2016-08-02T18:37:22+00:00

b2c8dc6f35ceb08e23422a356831070b5136809d












WIP
2016-08-01T18:12:30+00:00

Adam Niedzielski
adamsunday@gmail.com

2016-08-01T18:12:30+00:00

6d92cd3e836f2252b660479f5b33d15e6456b04d












Enable Style/EmptyLines cop, remove redundant ones
2016-07-01T19:56:17+00:00

Grzegorz Bizon
grzesiek.bizon@gmail.com

2016-07-01T19:56:17+00:00

9e211091a85c20adea63b89111240350d6d8ffcb












New Members::DestroyService
2016-06-18T03:46:45+00:00

Rémy Coutable
remy@rymai.me

2016-06-17T12:06:55+00:00

4652489f40a4ff2b749f9ad495986a7a17448243

This is to ensure we don't send unwanted notifications when deleting a
project. In other words, stop abusing AR callbacks and use services.

Signed-off-by: Rémy Coutable <remy@rymai.me>





This is to ensure we don't send unwanted notifications when deleting a
project. In other words, stop abusing AR callbacks and use services.

Signed-off-by: Rémy Coutable <remy@rymai.me>







UI and copywriting improvements
2016-06-14T11:18:14+00:00

Rémy Coutable
remy@rymai.me

2016-06-02T16:05:06+00:00

515205d3c1c6655302ed0ae44cc5954dead7ae79

+ Move 'Edit Project/Group' out of membership-related partial
+ Show the access request buttons only to logged-in users
+ Put the request access buttons out of in a more visible button
+ Improve the copy in the #remove_member_message helper

Signed-off-by: Rémy Coutable <remy@rymai.me>





+ Move 'Edit Project/Group' out of membership-related partial
+ Show the access request buttons only to logged-in users
+ Put the request access buttons out of in a more visible button
+ Improve the copy in the #remove_member_message helper

Signed-off-by: Rémy Coutable <remy@rymai.me>







Add request access for groups
2016-06-14T11:07:26+00:00

Rémy Coutable
remy@rymai.me

2016-04-18T16:53:32+00:00

d26f81239a33b80694783ee35f0da0e2ed082c9b

Signed-off-by: Rémy Coutable <remy@rymai.me>





Signed-off-by: Rémy Coutable <remy@rymai.me>