delta/gitlab/gitlab-ce.git/app/models/group.rb, branch replace_explore_projects.feature

Optimize SQL queries used in Groups::GroupMembersController#create

2017-09-05T20:54:07+00:00

The following optimizations were performed:

- Add new association to GroupMember and ProjectMember

  This new association will allow us to check if a user is a member of a
  Project or Group through a single query instead of two.

- Optimize retrieving of Members when adding multiple Users

Merge branch '31273-creating-an-project-within-an-internal-sub-group-gives-the-option-to-set-it-a-public' into 'master'

2017-08-31T17:17:05+00:00

Resolve various visibility level settings issues

Closes #31273

See merge request !13442

revert changes to visibility level helpers from 6f03ddc

2017-08-30T19:37:08+00:00

Address some suggestions from first code review

2017-08-29T05:53:35+00:00

prefer !x.exists? instead of x.none? to prevent unnecessary instantiation of records

2017-08-26T08:31:14+00:00

Fix broken spec.

2017-08-26T08:31:14+00:00

parent_id is being set to 0 by RSpec.

recognize instances where group visibility levels are unavailable

2017-08-26T08:30:01+00:00

separate visibility_level_allowed logic from model validators

2017-08-26T08:30:01+00:00

Add validation to check visibility level of sub groups.

2017-08-26T08:30:01+00:00

Add validation for visibility level of sub groups

2017-08-26T08:30:01+00:00

Sub groups should not have a visibility level higher than its parent.