delta/gitlab/gitlab-ce.git/app/models/diff_note.rb, branch docs-sethgitlab-dast gitlab.com: gitlab-org/gitlab-ce.git Make diff_refs_match_commit validation reusable 2019-08-01T21:00:36+00:00 Patrick Bajao ebajao@gitlab.com 2019-07-18T12:09:35+00:00 70626f324b53b0fc010cbbefcae7095201bf0f82 Move it to DiffPositionableNote concern which will be re-used in EE in DraftNote model. 
Move it to DiffPositionableNote concern which will be re-used
in EE in DraftNote model.
Lock suggestions_filter_enabled as true 2019-06-05T19:09:00+00:00 Kerri Miller kerrizor@kerrizor.com 2019-06-02T17:23:53+00:00 f44eba8c0e537362ccf362480517f12ee7c73130 Most/all of the work we're doing in this method is done at creation/edit time, so do we need to also check at render? Assume if you've gotten to this point, it's ok to enable the suggestion filter. 
Most/all of the work we're doing in this method is done at creation/edit
time, so do we need to also check at render? Assume if you've gotten to
this point, it's ok to enable the suggestion filter.
Avoid 500's when commit is not reachable 2019-06-05T11:38:09+00:00 Oswaldo Ferreira oswaldo@gitlab.com 2019-02-19T19:29:10+00:00 5a89bcc4dae55c40bdd926797aba5e3f0ada05ae 






Get `repository` from noteable in DiffNotes
2019-06-03T14:42:49+00:00

Bob Van Landuyt
bob@vanlanduyt.co

2019-06-03T14:42:49+00:00

7412e2fa7478e1ec6a5a0014b7a4bdc6d07133b2

Getting the `repository` directly from the noteable in DiffNotes
allows us to use a different repository when the DiffNote is not
on a project repository.

It is only the first step in decoupling the DiffNote from a project's
main repository.





Getting the `repository` directly from the noteable in DiffNotes
allows us to use a different repository when the DiffNote is not
on a project repository.

It is only the first step in decoupling the DiffNote from a project's
main repository.







Make `resolvable_types` a class method
2019-06-03T14:41:05+00:00

Bob Van Landuyt
bob@vanlanduyt.co

2019-06-03T14:41:05+00:00

4504959aa6ce6667b9fd5b68ff24a612cb7c027b

This turns Notable::RESOLVABLE_TYPES into a
`Notable.resolvable_types`. That allows us to override it in EE.





This turns Notable::RESOLVABLE_TYPES into a
`Notable.resolvable_types`. That allows us to override it in EE.







Prepare suggestion implementation for multi-line
2019-03-27T15:26:53+00:00

Oswaldo Ferreira
oswaldo@gitlab.com

2019-03-15T17:35:34+00:00

03e0604d5ded6402c7fddc4001ab23d9712c98de

Adds the groundwork needed in order to persist multi-line suggestions,
while providing the parsing strategy which will be reused for the
**Preview** as well.





Adds the groundwork needed in order to persist multi-line suggestions,
while providing the parsing strategy which will be reused for the
**Preview** as well.







Implement multi-line suggestions filtering
2019-03-20T14:30:24+00:00

Oswaldo Ferreira
oswaldo@gitlab.com

2019-03-13T13:57:05+00:00

53a59604964b2cff06b4e25401acae50b1f82d3e

Implements the filtering logic for
`suggestion:-x+y` syntax.





Implements the filtering logic for
`suggestion:-x+y` syntax.







Use shorthand version of method call
2019-02-26T20:19:18+00:00

Oswaldo Ferreira
oswaldo@gitlab.com

2019-02-26T20:03:58+00:00

6fc010bb39f902700b6b1d21b1fdb591c1cd287b












Always fetch MR latest version when creating suggestions
2019-02-26T20:19:17+00:00

Oswaldo Ferreira
oswaldo@gitlab.com

2019-02-20T21:20:08+00:00

e116fcab4151d61087afae17b6bf6cac58be29fc

This is an issue that can only be seen through EE. Further
details can be seen on
https://gitlab.com/gitlab-org/gitlab-ee/issues/9876. In general
we should always use the latest diff version of a file in order
to both create and apply suggestions.





This is an issue that can only be seen through EE. Further
details can be seen on
https://gitlab.com/gitlab-org/gitlab-ee/issues/9876. In general
we should always use the latest diff version of a file in order
to both create and apply suggestions.







Allow suggesting single line changes in diffs
2018-12-13T19:17:19+00:00

Oswaldo Ferreira
oswaldo@gitlab.com

2018-12-13T19:17:19+00:00

ed3034bbb71d43b12944a9da29b5264cb3ff3312