<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/app/models/deploy_token.rb, branch bootstrap-markdown-code-highlight</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Refactor deploy token methods on Ci::Build</title>
<updated>2018-04-20T17:18:41+00:00</updated>
<author>
<name>Mayra Cabrera</name>
<email>mcabrera@gitlab.com</email>
</author>
<published>2018-04-20T15:05:16+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=cdac54e2a2abe4b93bd5a96603b9d6d8745d277e'/>
<id>cdac54e2a2abe4b93bd5a96603b9d6d8745d277e</id>
<content type='text'>
Also include a class method for retriving the gitlab_deploy_token on
DeployTokens
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Also include a class method for retriving the gitlab_deploy_token on
DeployTokens
</pre>
</div>
</content>
</entry>
<entry>
<title>Rename special deploy token to make it more descriptive</title>
<updated>2018-04-20T17:18:41+00:00</updated>
<author>
<name>Mayra Cabrera</name>
<email>mcabrera@gitlab.com</email>
</author>
<published>2018-04-18T17:25:57+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=0dd6d25c251beffca510094281ac8403fad6d8d0'/>
<id>0dd6d25c251beffca510094281ac8403fad6d8d0</id>
<content type='text'>
Also:
- Includes more specs
- Improves a bit the documentation
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Also:
- Includes more specs
- Improves a bit the documentation
</pre>
</div>
</content>
</entry>
<entry>
<title>Expose deploy token to CI/CD jobs as environment variable</title>
<updated>2018-04-20T17:18:41+00:00</updated>
<author>
<name>Mayra Cabrera</name>
<email>mcabrera@gitlab.com</email>
</author>
<published>2018-04-16T20:47:35+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=0903456a0704bd5c4e594c423f0325b29cd99013'/>
<id>0903456a0704bd5c4e594c423f0325b29cd99013</id>
<content type='text'>
- If a deploy token with a name 'gitlab-deploy-token' is exists for the
  project, CI_DEPLOY_USER and CI_DEPLOY_PASSWORD variables will be
expose
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- If a deploy token with a name 'gitlab-deploy-token' is exists for the
  project, CI_DEPLOY_USER and CI_DEPLOY_PASSWORD variables will be
expose
</pre>
</div>
</content>
</entry>
<entry>
<title>Revert the addition of goldiloader</title>
<updated>2018-04-18T13:51:39+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2018-04-18T13:41:42+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=6f292eaa69c771cec8a81d2edaad19a26ab3eae6'/>
<id>6f292eaa69c771cec8a81d2edaad19a26ab3eae6</id>
<content type='text'>
This reverts the addition of the "goldiloader" Gem and all use of it.
While this Gem is very promising it's causing a variety of problems on
GitLab.com due to it eager-loading too much data in places where we
don't expect/can handle this. At least for the time being this means we
have to go back to manually fixing N+1 query problems, but at least
those should not cause a negative impact on availability.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This reverts the addition of the "goldiloader" Gem and all use of it.
While this Gem is very promising it's causing a variety of problems on
GitLab.com due to it eager-loading too much data in places where we
don't expect/can handle this. At least for the time being this means we
have to go back to manually fixing N+1 query problems, but at least
those should not cause a negative impact on availability.
</pre>
</div>
</content>
</entry>
<entry>
<title>Verify that deploy token has valid access when pulling container registry image</title>
<updated>2018-04-10T07:31:30+00:00</updated>
<author>
<name>Mayra Cabrera</name>
<email>mcabrera@gitlab.com</email>
</author>
<published>2018-04-10T07:31:30+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=3e35f65394fad201a9277667772f3ad9c6940d07'/>
<id>3e35f65394fad201a9277667772f3ad9c6940d07</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add cop for has_many :through without disabled autoloading</title>
<updated>2018-04-09T11:47:04+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2018-04-09T11:19:18+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=4ef3e3491e2ecc34e7f4de1221d5ad7b8b4a1e24'/>
<id>4ef3e3491e2ecc34e7f4de1221d5ad7b8b4a1e24</id>
<content type='text'>
Goldiloader is great, but has several issues with has_many :through relations:

* https://github.com/salsify/goldiloader/issues/12
* https://github.com/salsify/goldiloader/issues/14
* https://github.com/salsify/goldiloader/issues/18

Rather than try to figure out which applies in each case, we should just do the
drudge work of manually disabling autoloading for all relations of this type. We
can always use regular preloading for specific cases, but this way we avoid
generating invalid queries through Goldiloader's magic.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Goldiloader is great, but has several issues with has_many :through relations:

* https://github.com/salsify/goldiloader/issues/12
* https://github.com/salsify/goldiloader/issues/14
* https://github.com/salsify/goldiloader/issues/18

Rather than try to figure out which applies in each case, we should just do the
drudge work of manually disabling autoloading for all relations of this type. We
can always use regular preloading for specific cases, but this way we avoid
generating invalid queries through Goldiloader's magic.
</pre>
</div>
</content>
</entry>
<entry>
<title>Handle limit for datetime attributes on MySQL</title>
<updated>2018-04-07T03:28:44+00:00</updated>
<author>
<name>Mayra Cabrera</name>
<email>mcabrera@gitlab.com</email>
</author>
<published>2018-04-06T19:48:17+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=5bc58bac2678aed9c8b2318f9f4d4825baa2b110'/>
<id>5bc58bac2678aed9c8b2318f9f4d4825baa2b110</id>
<content type='text'>
The TIMESTAMP data type is used for values that contain both date and
time parts. TIMESTAMP has a range of '1970-01-01 00:00:01' UTC to
'2038-01-19 03:14:07' UTC.

A Forever lib class was included to handle future dates for PostgreSQL
and MySQL, also changes were made to DeployToken to enforce Forever.date

Also removes extra conditional from JwtController
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The TIMESTAMP data type is used for values that contain both date and
time parts. TIMESTAMP has a range of '1970-01-01 00:00:01' UTC to
'2038-01-19 03:14:07' UTC.

A Forever lib class was included to handle future dates for PostgreSQL
and MySQL, also changes were made to DeployToken to enforce Forever.date

Also removes extra conditional from JwtController
</pre>
</div>
</content>
</entry>
<entry>
<title>Handles default expires_at date directly into DeployToken model</title>
<updated>2018-04-07T02:20:17+00:00</updated>
<author>
<name>Mayra Cabrera</name>
<email>mcabrera@gitlab.com</email>
</author>
<published>2018-04-06T16:23:45+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=18a1569319af918fe3aff7564e344143d04d6aca'/>
<id>18a1569319af918fe3aff7564e344143d04d6aca</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Addresses database comments</title>
<updated>2018-04-07T02:20:17+00:00</updated>
<author>
<name>Mayra Cabrera</name>
<email>mcabrera@gitlab.com</email>
</author>
<published>2018-04-06T14:30:21+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=29913816309c6f6387b20c8702bcc8e90ef3a984'/>
<id>29913816309c6f6387b20c8702bcc8e90ef3a984</id>
<content type='text'>
- Adds a default on expires_at datetime
- Modifies deploy tokens views to handle default expires at value
- Use datetime_with_timezone where possible
- Remove unused scopes
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- Adds a default on expires_at datetime
- Modifies deploy tokens views to handle default expires at value
- Use datetime_with_timezone where possible
- Remove unused scopes
</pre>
</div>
</content>
</entry>
<entry>
<title>Increase test suite around deploy tokens behavior</title>
<updated>2018-04-07T02:20:17+00:00</updated>
<author>
<name>Mayra Cabrera</name>
<email>mcabrera@gitlab.com</email>
</author>
<published>2018-04-06T03:02:13+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=c4f56a88029c1fe73bf6efb062b5f77a65282fed'/>
<id>c4f56a88029c1fe73bf6efb062b5f77a65282fed</id>
<content type='text'>
Also, fixes broken specs
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Also, fixes broken specs
</pre>
</div>
</content>
</entry>
</feed>
