delta/gitlab/gitlab-ce.git/app/models/concerns/mentionable.rb, branch docs-pages-force-https

Turn reference regex constants into methods

2018-11-12T12:50:31+00:00

`Mentionable::ReferenceRegexes` used to define the following two
constants:

1. DEFAULT_PATTERN
2. EXTERNAL_PATTERN

These two constants were built using some of the class methods that
reside in this same module. In EE we redefine one of these methods by
using `prepend` at the start of the `ReferenceRegexes` module. This
poses a problem: we can not move the `prepend` to the end of the file,
because the constants later on depend on it.

To resolve this problem, this commit turns these constants into class
methods that memoize their results. This allows EE to redefine the
appropriate methods before these two class methods are used, in turn
allowing us to move the `prepend` to the end of the file.

See https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/8198 for more
information.

Remove EE-specific code from Mentionable

2018-09-17T11:36:53+00:00

Updates code using class_methods over module ClassMethods

2018-08-29T14:56:34+00:00

Enable more frozen string in app/models/**/*.rb

2018-08-07T07:37:36+00:00

Partially addresses #47424.

Merge remote-tracking branch 'upstream/master' into no-ivar-in-modules

2017-11-30T07:20:00+00:00

* upstream/master: (170 commits)
  support ordering of project notes in notes api
  Redirect to an already forked project if it exists
  Reschedule the migration to populate fork networks
  Create fork networks for forks for which the source was deleted.
  Fix item name and namespace text overflow in Projects dropdown
  Minor backport from EE
  fix link that was linking to `html` instead of `md`
  Backport epic tasklist
  Add timeouts for Gitaly calls
  SSHUploadPack over Gitaly is now OptOut
  fix icon colors in commit list
  Fix star icon color/stroke
  Backport border inline edit
  Add checkboxes to automatically run AutoDevops pipeline
  BE for automatic pipeline when enabling Auto DevOps
  I am certainly weary of debugging sidekiq but I don't think that's what was meant
  Ensure MRs always use branch refs for comparison
  Fix issue comment submit button disabled on GFM paste
  Lock seed-fu at the correct version in Gemfile.lock
  Improve indexes on merge_request_diffs
  ...

Fix link text from group context

2017-11-23T11:59:14+00:00

Use StrongMemoize and enable/disable cops properly

2017-11-17T17:01:53+00:00

Allow simple ivar ||= form. Update accordingly

2017-09-18T17:29:32+00:00

Add cop to make sure we don't use ivar in a module

2017-09-18T13:23:45+00:00

Whitelist or fix additional `Gitlab/PublicSend` cop violations

2017-08-14T16:14:11+00:00

An upcoming update to rubocop-gitlab-security added additional
violations.