<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/app/models/ci, branch multi-line-inline-diff</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Use scope rather than class method</title>
<updated>2016-07-07T10:56:02+00:00</updated>
<author>
<name>Lin Jen-Shin</name>
<email>godfat@godfat.org</email>
</author>
<published>2016-07-07T10:56:02+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=b988644ad853ea00ed23bfc57f83883f96a12016'/>
<id>b988644ad853ea00ed23bfc57f83883f96a12016</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Explicitly set to nil when artifacts don't exist:</title>
<updated>2016-07-04T14:56:23+00:00</updated>
<author>
<name>Lin Jen-Shin</name>
<email>godfat@godfat.org</email>
</author>
<published>2016-07-04T14:56:23+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=b5a2319764be166c5db1d66d1da1dd608555bb0c'/>
<id>b5a2319764be166c5db1d66d1da1dd608555bb0c</id>
<content type='text'>
Feedback from:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4964#note_12867273
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Feedback from:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4964#note_12867273
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge remote-tracking branch 'upstream/master' into save-artifacts_sizes</title>
<updated>2016-07-04T11:14:54+00:00</updated>
<author>
<name>Lin Jen-Shin</name>
<email>godfat@godfat.org</email>
</author>
<published>2016-07-04T11:14:54+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=596f46881f2f70cfca8e30794b4c9572a8644ceb'/>
<id>596f46881f2f70cfca8e30794b4c9572a8644ceb</id>
<content type='text'>
* upstream/master: (175 commits)
  Document Repository#keep_around
  Don't garbage collect commits that have related DB records like comments
  Update CHANGELOG
  Update RedCloth to 4.3.2 for CVE-2012-6684
  Fix typo in Merge Requests API documentation
  Downgrade to Redis 3.2.2 due to massive memory leak with Sidekiq
  Enable Style/EmptyLines cop, remove redundant ones
  Update CHANGELOG
  Cache results from jQuery selectors to retrieve namespace name
  Fix import button when import fail due the namespace already been taken
  Fix snippets comments not displayed
  Fix emoji paths in relative root configurations
  Exclude requesters from Project#members, Group#members and User#members
  Upgrade Thin from 1.6.1 to 1.7.0.
  Many squashed commits
  Cache autocomplete results
  Upgrade Sidekiq from 4.1.2 to 4.1.4.
  Upgrade seed-fu from 2.3.5 to 2.3.6
  use has_many relationship with events
  Support creating a todo on issuables via API
  ...
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* upstream/master: (175 commits)
  Document Repository#keep_around
  Don't garbage collect commits that have related DB records like comments
  Update CHANGELOG
  Update RedCloth to 4.3.2 for CVE-2012-6684
  Fix typo in Merge Requests API documentation
  Downgrade to Redis 3.2.2 due to massive memory leak with Sidekiq
  Enable Style/EmptyLines cop, remove redundant ones
  Update CHANGELOG
  Cache results from jQuery selectors to retrieve namespace name
  Fix import button when import fail due the namespace already been taken
  Fix snippets comments not displayed
  Fix emoji paths in relative root configurations
  Exclude requesters from Project#members, Group#members and User#members
  Upgrade Thin from 1.6.1 to 1.7.0.
  Many squashed commits
  Cache autocomplete results
  Upgrade Sidekiq from 4.1.2 to 4.1.4.
  Upgrade seed-fu from 2.3.5 to 2.3.6
  use has_many relationship with events
  Support creating a todo on issuables via API
  ...
</pre>
</div>
</content>
</entry>
<entry>
<title>Don't garbage collect commits that have related DB records like comments</title>
<updated>2016-07-04T04:11:33+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@selenight.nl</email>
</author>
<published>2016-07-03T23:58:58+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=3286dd7a1db69460573a5fd2c9e997039b1f406b'/>
<id>3286dd7a1db69460573a5fd2c9e997039b1f406b</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Use nil for non-existing files rather than 0</title>
<updated>2016-06-30T16:00:35+00:00</updated>
<author>
<name>Lin Jen-Shin</name>
<email>godfat@godfat.org</email>
</author>
<published>2016-06-30T16:00:35+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=7b06acea1c13b7fa9067902faaed73c7210f4bb3'/>
<id>7b06acea1c13b7fa9067902faaed73c7210f4bb3</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Improve method that tells if build is retryable</title>
<updated>2016-06-30T09:06:19+00:00</updated>
<author>
<name>Grzegorz Bizon</name>
<email>grzesiek.bizon@gmail.com</email>
</author>
<published>2016-06-28T12:24:43+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=f9c5f18d448de3fefced3149550263adc83af1bf'/>
<id>f9c5f18d448de3fefced3149550263adc83af1bf</id>
<content type='text'>
This method now should return false if build is not completed. If build
is running then it is not retryable, therefore `Ci::Build#retryable?`
returned wrong value. This commit changes this behavior
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This method now should return false if build is not completed. If build
is running then it is not retryable, therefore `Ci::Build#retryable?`
returned wrong value. This commit changes this behavior
</pre>
</div>
</content>
</entry>
<entry>
<title>Use AR callbacks as suggested by:</title>
<updated>2016-06-29T09:44:39+00:00</updated>
<author>
<name>Lin Jen-Shin</name>
<email>godfat@godfat.org</email>
</author>
<published>2016-06-29T09:44:39+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=9d8dca08e440ccb730f20dcd79b3b47aef8aeb2e'/>
<id>9d8dca08e440ccb730f20dcd79b3b47aef8aeb2e</id>
<content type='text'>
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4964#note_12744656
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4964#note_12744656
</pre>
</div>
</content>
</entry>
<entry>
<title>Also remove ci_builds.artifacts_size when erased</title>
<updated>2016-06-28T12:37:46+00:00</updated>
<author>
<name>Lin Jen-Shin</name>
<email>godfat@godfat.org</email>
</author>
<published>2016-06-28T12:37:46+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=1bc0d732f604d7a4a616ba34b8ccbb1987038951'/>
<id>1bc0d732f604d7a4a616ba34b8ccbb1987038951</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Just save the size in total rather than individual files</title>
<updated>2016-06-28T11:16:48+00:00</updated>
<author>
<name>Lin Jen-Shin</name>
<email>godfat@godfat.org</email>
</author>
<published>2016-06-28T11:16:48+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=0a294698db01112c407575e690a8a368be6b15f8'/>
<id>0a294698db01112c407575e690a8a368be6b15f8</id>
<content type='text'>
Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4964#note_12741046
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4964#note_12741046
</pre>
</div>
</content>
</entry>
<entry>
<title>Introduce ci_builds.artifacts_sizes as JSON:</title>
<updated>2016-06-28T10:14:21+00:00</updated>
<author>
<name>Lin Jen-Shin</name>
<email>godfat@godfat.org</email>
</author>
<published>2016-06-28T10:14:21+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=fe0c59d2e61238e1241be448a37be0e3e702a5ce'/>
<id>fe0c59d2e61238e1241be448a37be0e3e702a5ce</id>
<content type='text'>
We store the sizes as a hash from path to bytes like:

``` ruby
{'ci_artifacts.txt' =&gt; 27,
 'other_artifacts_0.1.2/another-subdirectory/banana_sample.gif' =&gt;
71759,
 'other_artifacts_0.1.2/doc_sample.txt' =&gt; 1314,
 'rails_sample.jpg' =&gt; 35255,
 'tests_encoding/utf8 test dir ✓/regular_file_2' =&gt; 7}
```

So that it's easier to access than reading gzip file again.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We store the sizes as a hash from path to bytes like:

``` ruby
{'ci_artifacts.txt' =&gt; 27,
 'other_artifacts_0.1.2/another-subdirectory/banana_sample.gif' =&gt;
71759,
 'other_artifacts_0.1.2/doc_sample.txt' =&gt; 1314,
 'rails_sample.jpg' =&gt; 35255,
 'tests_encoding/utf8 test dir ✓/regular_file_2' =&gt; 7}
```

So that it's easier to access than reading gzip file again.
</pre>
</div>
</content>
</entry>
</feed>
