delta/gitlab/gitlab-ce.git/app/models/ci, branch docs/fix-commit-api-render

Merge branch 'drop-usage-of-leagcy-artifacts' into 'master'

2019-04-04T19:46:37+00:00

Drop legacy artifacts usage as there are no leftovers

See merge request gitlab-org/gitlab-ce!24294

Renamed terminal_specification to channel_specification

2019-04-04T18:32:02+00:00

We're moving from using terminology related to terminals when
we refer to Websockets connections in Workhorse.
It's more appropiate a concept like channel.

Drop legacy artifacts usage

2019-04-04T09:19:43+00:00

Legacy artifacts have been correctly migrated to new place -
ci_job_artifacts. Now it's time to remove the related code, but before
that we should ensure it doesn't break anything by using feature flag.

Backport EE change

2019-04-02T08:55:06+00:00

This is for merge request pipelines

Merge branch 'persist-fulll-ref-path-for-mr-pipelines' into 'master'

2019-03-29T10:46:02+00:00

Use merge request HEAD ref for detached merge request pipelines

Closes #58454

See merge request gitlab-org/gitlab-ce!25504

Merge branch 'sh-fix-gitaly-find-commit-caching' into 'master'

2019-03-29T10:31:57+00:00

Allow ref name caching CommitService#find_commit

Closes #57083

See merge request gitlab-org/gitlab-ce!26248

Create detached merge request pipelines

2019-03-29T06:58:45+00:00

By using `refs/merge-requests/:iid/head`

ok

ok

Improve naming nicely

Add nice tests

add nice tests

fix some more

revert

Inherit from ApplicationRecord instead of ActiveRecord::Base

2019-03-28T16:18:23+00:00

Guard against nested allows with ref name caching

2019-03-27T23:17:25+00:00

This avoids the case:

```
allow_ref_name_caching do
  allow_ref_name_caching do
    # using-feature
  end
end
```

Allow ref name caching CommitService#find_commit

2019-03-27T19:46:39+00:00

For a given merge request, it's quite common to see duplicate FindCommit
Gitaly requests because the Gitaly CommitService caches the request by
the commit SHA, not by the ref name. However, most of the duplicate
requests use the ref name, so the cache is never actually used in
practice. This leads to unnecessary requests that slow performance.

This commit allows certain callers to bypass the ref name to
OID conversion in the cache. We don't do this by default because it's
possible the tip of the branch changes during the commit, which
would cause the caller to get stale data.

This commit also forces the Ci::Pipeline to use the full ref name
so that caching can work for merge requests.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/57083