delta/gitlab/gitlab-ce.git/app/models/ci/runner.rb, branch multi-line-inline-diff gitlab.com: gitlab-org/gitlab-ce.git Rename according to: 2016-06-20T08:52:05+00:00 Lin Jen-Shin godfat@godfat.org 2016-06-20T08:52:05+00:00 4efc1c4a68538126bc4cfad6d9b60710bee36f14 https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4093#note_12563922 For clarification and consistency 
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4093#note_12563922

For clarification and consistency
Use FIXME instead, feedback from: 2016-06-16T15:20:13+00:00 Lin Jen-Shin godfat@godfat.org 2016-06-16T15:20:13+00:00 4852acef9256ee60d76564ff7509dc72e016a863 https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4093/diffs#note_12501400 
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4093/diffs#note_12501400
Return the association and check it in controller instead: 2016-06-14T15:11:43+00:00 Lin Jen-Shin godfat@godfat.org 2016-06-14T15:11:43+00:00 9cf45b058627f039040165519de9c2074dda141f Feedback: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4641#note_12444891 
Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4641#note_12444891
Merge branch 'prefer-assign_to' into feature/runner-lock-on-project 2016-06-14T15:05:33+00:00 Lin Jen-Shin godfat@godfat.org 2016-06-14T15:05:33+00:00 6c500034f4e626f28fa0a47534c24f7181131b43 * prefer-assign_to: Give 409 Conflict whenever the runner was already enabled We're checking return value rather than rescuing exceptions Prefer Runner#assign_to instead of creating directly 
* prefer-assign_to:
  Give 409 Conflict whenever the runner was already enabled
  We're checking return value rather than rescuing exceptions
  Prefer Runner#assign_to instead of creating directly
Give 409 Conflict whenever the runner was already enabled 2016-06-14T14:25:11+00:00 Lin Jen-Shin godfat@godfat.org 2016-06-14T14:17:01+00:00 f74f42386029077d0f12ac407fc6ee39aaeeaf53 






We're checking return value rather than rescuing exceptions
2016-06-14T09:28:11+00:00

Lin Jen-Shin
godfat@godfat.org

2016-06-14T09:28:11+00:00

1b03c5807fab6d2122e5a590cebfb2e7978a6659












Rename specific_for to available_for:
2016-06-14T08:07:57+00:00

Lin Jen-Shin
godfat@godfat.org

2016-06-14T08:07:57+00:00

cbd6ca6985c1a7eefcfa5b3ca170fdf1865aee45

Feedback from:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4093#note_12413950





Feedback from:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4093#note_12413950







Merge conditions. Not worth an additional pointless method:
2016-06-09T08:00:24+00:00

Lin Jen-Shin
godfat@godfat.org

2016-06-08T07:43:43+00:00

8b34687a36c1ec4e558724513bcabdfa3b706854

Feedback from:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4093#note_12321267





Feedback from:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4093#note_12321267







Renamed to available_for? Feedback from:
2016-06-09T08:00:24+00:00

Lin Jen-Shin
godfat@godfat.org

2016-06-08T07:38:34+00:00

d7b08024afa41d59c5d41c0e1972e2580e019996

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4093#note_12321240





https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4093#note_12321240







Remove Build#can_be_served? and rename Runner#can_serve? to can_pick?
2016-06-09T08:00:24+00:00

Lin Jen-Shin
godfat@godfat.org

2016-06-08T07:19:49+00:00

268f7713a9c076204a8b6badb847d2e23bafdd71

This also moves tests from build_spec.rb to runner_spec.rb





This also moves tests from build_spec.rb to runner_spec.rb