delta/gitlab/gitlab-ce.git/app/models/ci/build.rb, branch multi-line-inline-diff

Use scope rather than class method

2016-07-07T10:56:02+00:00

Explicitly set to nil when artifacts don't exist:

2016-07-04T14:56:23+00:00

Feedback from:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4964#note_12867273

Merge remote-tracking branch 'upstream/master' into save-artifacts_sizes

2016-07-04T11:14:54+00:00

* upstream/master: (175 commits)
  Document Repository#keep_around
  Don't garbage collect commits that have related DB records like comments
  Update CHANGELOG
  Update RedCloth to 4.3.2 for CVE-2012-6684
  Fix typo in Merge Requests API documentation
  Downgrade to Redis 3.2.2 due to massive memory leak with Sidekiq
  Enable Style/EmptyLines cop, remove redundant ones
  Update CHANGELOG
  Cache results from jQuery selectors to retrieve namespace name
  Fix import button when import fail due the namespace already been taken
  Fix snippets comments not displayed
  Fix emoji paths in relative root configurations
  Exclude requesters from Project#members, Group#members and User#members
  Upgrade Thin from 1.6.1 to 1.7.0.
  Many squashed commits
  Cache autocomplete results
  Upgrade Sidekiq from 4.1.2 to 4.1.4.
  Upgrade seed-fu from 2.3.5 to 2.3.6
  use has_many relationship with events
  Support creating a todo on issuables via API
  ...

Use nil for non-existing files rather than 0

2016-06-30T16:00:35+00:00

Improve method that tells if build is retryable

2016-06-30T09:06:19+00:00

This method now should return false if build is not completed. If build
is running then it is not retryable, therefore `Ci::Build#retryable?`
returned wrong value. This commit changes this behavior

Use AR callbacks as suggested by:

2016-06-29T09:44:39+00:00

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4964#note_12744656

Also remove ci_builds.artifacts_size when erased

2016-06-28T12:37:46+00:00

Just save the size in total rather than individual files

2016-06-28T11:16:48+00:00

Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4964#note_12741046

Introduce ci_builds.artifacts_sizes as JSON:

2016-06-28T10:14:21+00:00

We store the sizes as a hash from path to bytes like:

``` ruby
{'ci_artifacts.txt' => 27,
 'other_artifacts_0.1.2/another-subdirectory/banana_sample.gif' =>
71759,
 'other_artifacts_0.1.2/doc_sample.txt' => 1314,
 'rails_sample.jpg' => 35255,
 'tests_encoding/utf8 test dir ✓/regular_file_2' => 7}
```

So that it's easier to access than reading gzip file again.

Merge remote-tracking branch 'upstream/master' into feature/runner-lock-on-project

2016-06-20T14:04:14+00:00

* upstream/master: (353 commits)
  Put some admin settings in dropdown
  Add styleguide on configuration settings documentation
  Remove Duplicated keys add UNIQUE index to fingerprint
  Avoid autoload issue such as 'Mail::Parsers::AddressStruct'
  Move appearance settings as sub tab to application settings
  use rails root join
  fixed a couple of errors spotted in production
  Fix RangeError exceptions when referring to issues or merge requests outside of max database values
  Fix bug in `WikiLinkFilter`.
  Grammar and typographic changes to artifacts documentation
  Tweak grammar
  Small frontend code fixes and restore 8a2d88f commit
  Warn about admin privilege to disable GitHub Webhooks
  Listing GH Webhooks doesn't stop import process for non GH admin users
  fixup! updated docs for api endpoint award emoji
  Update CHANGELOG
  Ensure Todos counters doesn't count Todos for projects pending delete
  Add endpoints for award emoji on notes
  Sort API endpoints and implement feedback
  Add endpoints for Award Emoji
  ...