<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/app/models/application_setting.rb, branch NicoleSchwartz-Python-Blog</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Add a memory cache local to the thread to reduce Redis load</title>
<updated>2019-07-02T05:23:01+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2019-07-01T19:17:37+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=978647c6cb0f81c3695c4d20e98619c2025532c5'/>
<id>978647c6cb0f81c3695c4d20e98619c2025532c5</id>
<content type='text'>
Loading `ApplicationSetting` from Redis was responsible for at least 50%
of the CPU load of the Redis cluster on GitLab.com. Since these values
generally don't change very much, we can load this from the database and
cache it in memory, skipping Redis altogther. We use
`ActiveSupport::Cache::MemoryStore` as a drop-in replacement for
`RedisCacheStore` even though we probably don't need synchronized access
within `Thread.current`.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/63977
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Loading `ApplicationSetting` from Redis was responsible for at least 50%
of the CPU load of the Redis cluster on GitLab.com. Since these values
generally don't change very much, we can load this from the database and
cache it in memory, skipping Redis altogther. We use
`ActiveSupport::Cache::MemoryStore` as a drop-in replacement for
`RedisCacheStore` even though we probably don't need synchronized access
within `Thread.current`.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/63977
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove ignored circuit_breaker columns</title>
<updated>2019-06-28T08:30:40+00:00</updated>
<author>
<name>Zeger-Jan van de Weg</name>
<email>git@zjvandeweg.nl</email>
</author>
<published>2019-06-28T08:28:28+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=cb4a514207c914069410a01de8b493076156752a'/>
<id>cb4a514207c914069410a01de8b493076156752a</id>
<content type='text'>
The circuit breaker itself got removed a while ago, when that happened
some parts got left behind. Using grep old stale settings and
validations were found and are now removed.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The circuit breaker itself got removed a while ago, when that happened
some parts got left behind. Using grep old stale settings and
validations were found and are now removed.
</pre>
</div>
</content>
</entry>
<entry>
<title>refactor: remove Sentry from application settings</title>
<updated>2019-06-25T19:17:19+00:00</updated>
<author>
<name>Roger Meier</name>
<email>r.meier@siemens.com</email>
</author>
<published>2019-04-30T20:06:08+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=946ffc67b711b39512a789213779d2736fcc0049'/>
<id>946ffc67b711b39512a789213779d2736fcc0049</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Store Let's Encrypt private key in settings</title>
<updated>2019-05-28T04:47:34+00:00</updated>
<author>
<name>Vladimir Shushlin</name>
<email>vshushlin@gitlab.com</email>
</author>
<published>2019-05-28T04:47:34+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=4687ff7c9be789341e82a6440234fce43f30b5be'/>
<id>4687ff7c9be789341e82a6440234fce43f30b5be</id>
<content type='text'>
Storing this key in secrets.yml was a bad idea,
it would require users using HA setups to manually
replicate secrets across nodes during update,
it also needed support from omnibus package

* Revert "Generate Let's Encrypt private key"
  This reverts commit 444959bfa0b79e827a2a1a7a314acac19390f976.

* Add Let's Encrypt private key to settings
  as encrypted attribute

* Generate Let's Encrypt private key
  in database migration
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Storing this key in secrets.yml was a bad idea,
it would require users using HA setups to manually
replicate secrets across nodes during update,
it also needed support from omnibus package

* Revert "Generate Let's Encrypt private key"
  This reverts commit 444959bfa0b79e827a2a1a7a314acac19390f976.

* Add Let's Encrypt private key to settings
  as encrypted attribute

* Generate Let's Encrypt private key
  in database migration
</pre>
</div>
</content>
</entry>
<entry>
<title>Add Let's Encrypt application settings</title>
<updated>2019-04-27T04:38:01+00:00</updated>
<author>
<name>Vladimir Shushlin</name>
<email>vshushlin@gitlab.com</email>
</author>
<published>2019-04-27T04:38:01+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=db6989ddb0dc1dc630803ea3748542779b5f9090'/>
<id>db6989ddb0dc1dc630803ea3748542779b5f9090</id>
<content type='text'>
Store Let's Encrypt account email in application settings
Also add explicit terms of service consent
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Store Let's Encrypt account email in application settings
Also add explicit terms of service consent
</pre>
</div>
</content>
</entry>
<entry>
<title>Externalize strings in app/models</title>
<updated>2019-04-12T12:28:07+00:00</updated>
<author>
<name>Martin Wortschack</name>
<email>mwortschack@gitlab.com</email>
</author>
<published>2019-04-12T12:28:07+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=cd6f77409359de53c20c99c5d291ada3545d9d28'/>
<id>cd6f77409359de53c20c99c5d291ada3545d9d28</id>
<content type='text'>
- Update PO file
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- Update PO file
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch '60278-fix-development-seed' into 'master'</title>
<updated>2019-04-11T09:32:02+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@gitlab.com</email>
</author>
<published>2019-04-11T09:32:02+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=79b0bf2a9fa226e5b1b03252bf28e41f2cb7f184'/>
<id>79b0bf2a9fa226e5b1b03252bf28e41f2cb7f184</id>
<content type='text'>
Fix ApplicationSetting development seed

Closes #60278

See merge request gitlab-org/gitlab-ce!27213</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fix ApplicationSetting development seed

Closes #60278

See merge request gitlab-org/gitlab-ce!27213</pre>
</div>
</content>
</entry>
<entry>
<title>Align UrlValidator to validate_url gem implementation.</title>
<updated>2019-04-11T06:29:07+00:00</updated>
<author>
<name>Thong Kuah</name>
<email>tkuah@gitlab.com</email>
</author>
<published>2019-04-11T06:29:07+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d119d3d1b25aac661e6251addf87b280bd37f0c5'/>
<id>d119d3d1b25aac661e6251addf87b280bd37f0c5</id>
<content type='text'>
Renamed UrlValidator to AddressableUrlValidator to avoid 'url:' naming collision with ActiveModel::Validations::UrlValidator in 'validates' statement.
Make use of the options attribute of the parent class ActiveModel::EachValidator.
Add more options: allow_nil, allow_blank, message.
Renamed 'protocols' option to 'schemes' to match the option naming from UrlValidator.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Renamed UrlValidator to AddressableUrlValidator to avoid 'url:' naming collision with ActiveModel::Validations::UrlValidator in 'validates' statement.
Make use of the options attribute of the parent class ActiveModel::EachValidator.
Add more options: allow_nil, allow_blank, message.
Renamed 'protocols' option to 'schemes' to match the option naming from UrlValidator.
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix ApplicationSetting development seed</title>
<updated>2019-04-10T13:56:46+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2019-04-10T10:03:37+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=22c1c9805b00ebc3bbb48fabba49cf2ba3e696e0'/>
<id>22c1c9805b00ebc3bbb48fabba49cf2ba3e696e0</id>
<content type='text'>
It could happen that there's a cached (in Redis) ApplicationSetting
record, and calling
`Gitlab::CurrentSettings.current_application_settings` only returns it
instead of creating a new DB record, which makes the
`ApplicationSetting.current_without_cache.update!` call fail.

Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
It could happen that there's a cached (in Redis) ApplicationSetting
record, and calling
`Gitlab::CurrentSettings.current_application_settings` only returns it
instead of creating a new DB record, which makes the
`ApplicationSetting.current_without_cache.update!` call fail.

Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Move Contribution Analytics related spec in spec/features/groups/group_page_with_external_authorization_service_spec to EE</title>
<updated>2019-04-09T15:38:58+00:00</updated>
<author>
<name>Imre Farkas</name>
<email>ifarkas@gitlab.com</email>
</author>
<published>2019-04-09T15:38:58+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=9bc5ed14fe97fe63cd5be30c013c6af978715621'/>
<id>9bc5ed14fe97fe63cd5be30c013c6af978715621</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
