delta/gitlab/gitlab-ce.git/app/models/ability.rb, branch tests-for-diff-notes gitlab.com: gitlab-org/gitlab-ce.git Make Ability#project_abilities return unique values and fix counts 2016-08-20T13:53:14+00:00 Stan Hu stanhu@gmail.com 2016-08-20T13:33:53+00:00 1954bb17eca49d375c92a4b8fa7f52fa39873a7d 






Fix assorted rspec failures due to stale, cached user permissions
2016-08-20T13:53:14+00:00

Stan Hu
stanhu@gmail.com

2016-08-20T05:22:52+00:00

41d89533e61f6009b5d800afc00c184e2807eafd

RequestStore is disabled in tests, but the Ability class was
caching user permissions based on the user and project ID of
previous test runs. Revise code to use RequestStore only if it
is active.





RequestStore is disabled in tests, but the Ability class was
caching user permissions based on the user and project ID of
previous test runs. Revise code to use RequestStore only if it
is active.







Merge branch 'master' into diff-line-comment-vuejs
2016-08-17T18:10:09+00:00

Connor Shea
connor.james.shea@gmail.com

2016-08-17T18:10:09+00:00

d8654744cd6c8fa4cbe4617c2428cd79d4bd5179












Move action to render board lists to `Projects::Boards::ListsController`
2016-08-17T15:58:59+00:00

Douglas Barbosa Alexandre
dbalexandre@gmail.com

2016-08-15T22:50:23+00:00

cd98ff179cb20d9dc4460d173288d0e1582c4293












Turn board for public projects accessible to everyone
2016-08-17T15:58:59+00:00

Douglas Barbosa Alexandre
dbalexandre@gmail.com

2016-08-09T16:07:35+00:00

5490a9fe835f12e3d931bc0a47c0ec177c802140












Add authorization to issues board related controllers
2016-08-17T15:58:59+00:00

Douglas Barbosa Alexandre
dbalexandre@gmail.com

2016-08-08T22:03:41+00:00

a8b1ad250e1ebc1c1e835399ccd010b223108a1d












Merge branch 'master' into diff-line-comment-vuejs
2016-08-12T22:23:19+00:00

Douwe Maan
douwe@selenight.nl

2016-08-12T22:23:19+00:00

c770201061c5d39e6e297951badfafc8ddf14906












Move abilities by subject class to a dedicated method
2016-08-04T14:00:31+00:00

Rémy Coutable
remy@rymai.me

2016-08-04T14:00:31+00:00

705085db0c3b869f62f1b0f742686cc2082001fa

This will avoid lame conflicts when merging CE to EE

Signed-off-by: Rémy Coutable <remy@rymai.me>





This will avoid lame conflicts when merging CE to EE

Signed-off-by: Rémy Coutable <remy@rymai.me>







Merge branch 'master' into diff-line-comment-vuejs
2016-08-03T22:32:00+00:00

Douwe Maan
douwe@selenight.nl

2016-08-03T22:32:00+00:00

538e66d71c0f7125cc62ea51480668ba8b342544

# Conflicts:
#	app/models/discussion.rb
#	db/schema.rb





# Conflicts:
#	app/models/discussion.rb
#	db/schema.rb







Method for returning issues readable by a user
2016-07-29T10:51:18+00:00

Yorick Peterse
yorickpeterse@gmail.com

2016-07-20T18:13:02+00:00

002ad215818450d2cbbc5fa065850a953dc7ada8

The method Ability.issues_readable_by_user takes a list of users and an
optional user and returns an Array of issues readable by said user. This
method in turn is used by
Banzai::ReferenceParser::IssueParser#nodes_visible_to_user so this
method no longer needs to get all the available abilities just to check
if a user has the "read_issue" ability.

To test this I benchmarked an issue with 222 comments on my development
environment. Using these changes the time spent in nodes_visible_to_user
was reduced from around 120 ms to around 40 ms.





The method Ability.issues_readable_by_user takes a list of users and an
optional user and returns an Array of issues readable by said user. This
method in turn is used by
Banzai::ReferenceParser::IssueParser#nodes_visible_to_user so this
method no longer needs to get all the available abilities just to check
if a user has the "read_issue" ability.

To test this I benchmarked an issue with 222 comments on my development
environment. Using these changes the time spent in nodes_visible_to_user
was reduced from around 120 ms to around 40 ms.