<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/app/finders, branch document-lambda-deploy</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Avoid calling freeze on already frozen strings in app/finders</title>
<updated>2019-09-04T03:49:07+00:00</updated>
<author>
<name>dineshpanda</name>
<email>dineshpanda92@gmail.com</email>
</author>
<published>2019-08-31T19:21:48+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=a3de0cd60369f6ee70e98a47b8db5a309a655354'/>
<id>a3de0cd60369f6ee70e98a47b8db5a309a655354</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch '62284-follow-up-from-resolve-api-to-get-all-project-group-members-returns-duplicates' into 'master'</title>
<updated>2019-08-29T06:34:26+00:00</updated>
<author>
<name>James Lopez</name>
<email>james@gitlab.com</email>
</author>
<published>2019-08-29T06:34:26+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=9174d9a23f7f6fddec94b5ce22f99a2ce6bb491e'/>
<id>9174d9a23f7f6fddec94b5ce22f99a2ce6bb491e</id>
<content type='text'>
Resolve "Follow-up from "Resolve "API to get all project/group members returns duplicates"""

Closes #62284

See merge request gitlab-org/gitlab-ce!28887</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Resolve "Follow-up from "Resolve "API to get all project/group members returns duplicates"""

Closes #62284

See merge request gitlab-org/gitlab-ce!28887</pre>
</div>
</content>
</entry>
<entry>
<title>Uses projects_authorizations.access_level in MembersFinder</title>
<updated>2019-08-28T15:48:55+00:00</updated>
<author>
<name>Jacopo</name>
<email>beschi.jacopo@gmail.com</email>
</author>
<published>2019-06-19T09:51:15+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=864bd12be4a91aadaed9674c3f454015dfda4edd'/>
<id>864bd12be4a91aadaed9674c3f454015dfda4edd</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Update CE files for GSD projects filter</title>
<updated>2019-08-28T14:26:42+00:00</updated>
<author>
<name>Victor Zagorodny</name>
<email>vzagorodny@gitlab.com</email>
</author>
<published>2019-08-28T14:26:42+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=e4fbd94cf5eba0b103bd97627d822f2014dfe474'/>
<id>e4fbd94cf5eba0b103bd97627d822f2014dfe474</id>
<content type='text'>
A new param with_security_reports was added to
GET /groups/:id/projects API and the code to
support this logic in GroupProjectsFinder and
Project model. Also, a DB index was added to
ci_job_artifacts table to speed up the search
of security reports artifacts for projects
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
A new param with_security_reports was added to
GET /groups/:id/projects API and the code to
support this logic in GroupProjectsFinder and
Project model. Also, a DB index was added to
ci_job_artifacts table to speed up the search
of security reports artifacts for projects
</pre>
</div>
</content>
</entry>
<entry>
<title>Add service classes for mutating AwardEmoji</title>
<updated>2019-08-20T23:39:41+00:00</updated>
<author>
<name>Luke Duncalfe</name>
<email>lduncalfe@eml.cc</email>
</author>
<published>2019-06-18T01:44:43+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=37b17fa61a1fb5efe5942ab2cb27b15685bf905e'/>
<id>37b17fa61a1fb5efe5942ab2cb27b15685bf905e</id>
<content type='text'>
Adding, destroying and toggling emoji previously lacked services and
instead were performed through methods called on Awardable models.

This led to inconsistencies where relevant todos would be marked as done
only when emoji were awarded through our controllers, but not through
the API. Todos could also be marked as done when an emoji was being
removed.

Behaviour changes

- Awarding emoji through the API will now mark a relevant Todo as done
- Toggling an emoji off (destroying it) through our controllers will no
  longer mark a relevant Todo as done

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/63372
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Adding, destroying and toggling emoji previously lacked services and
instead were performed through methods called on Awardable models.

This led to inconsistencies where relevant todos would be marked as done
only when emoji were awarded through our controllers, but not through
the API. Todos could also be marked as done when an emoji was being
removed.

Behaviour changes

- Awarding emoji through the API will now mark a relevant Todo as done
- Toggling an emoji off (destroying it) through our controllers will no
  longer mark a relevant Todo as done

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/63372
</pre>
</div>
</content>
</entry>
<entry>
<title>Renaming AwardedEmojiFinder to a Service</title>
<updated>2019-08-20T22:00:00+00:00</updated>
<author>
<name>Luke Duncalfe</name>
<email>lduncalfe@eml.cc</email>
</author>
<published>2019-06-18T05:15:53+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=330cbddec30840a72a52aade383286e58545ce98'/>
<id>330cbddec30840a72a52aade383286e58545ce98</id>
<content type='text'>
This finder class acts more as a service, as it only returns mapped
data.

Renaming this class allows us to create a new AwardEmojiFinder without
the ambiguity of there being two similarly-named finders.

https://gitlab.com/gitlab-org/gitlab-ce/issues/63372
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This finder class acts more as a service, as it only returns mapped
data.

Renaming this class allows us to create a new AwardEmojiFinder without
the ambiguity of there being two similarly-named finders.

https://gitlab.com/gitlab-org/gitlab-ce/issues/63372
</pre>
</div>
</content>
</entry>
<entry>
<title>Rework retry strategy for remote mirrors</title>
<updated>2019-08-13T20:52:01+00:00</updated>
<author>
<name>Bob Van Landuyt</name>
<email>bob@gitlab.com</email>
</author>
<published>2019-08-13T20:52:01+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=452bc36d603ed89d3fa5e3409338dd905230bd2f'/>
<id>452bc36d603ed89d3fa5e3409338dd905230bd2f</id>
<content type='text'>
**Prevention of running 2 simultaneous updates**

Instead of using `RemoteMirror#update_status` and raise an error if
it's already running to prevent the same mirror being updated at the
same time we now use `Gitlab::ExclusiveLease` for that.

When we fail to obtain a lease in 3 tries, 30 seconds apart, we bail
and reschedule. We'll reschedule faster for the protected branches.

If the mirror already ran since it was scheduled, the job will be
skipped.

**Error handling: Remote side**

When an update fails because of a `Gitlab::Git::CommandError`, we
won't track this error in sentry, this could be on the remote side:
for example when branches have diverged.

In this case, we'll try 3 times scheduled 1 or 5 minutes apart.

In between, the mirror is marked as "to_retry", the error would be
visible to the user when they visit the settings page.

After 3 tries we'll mark the mirror as failed and notify the user.

We won't track this error in sentry, as it's not likely we can help
it.

The next event that would trigger a new refresh.

**Error handling: our side**

If an unexpected error occurs, we mark the mirror as failed, but we'd
still retry the job based on the regular sidekiq retries with
backoff. Same as we used to

The error would be reported in sentry, since its likely we need to do
something about it.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
**Prevention of running 2 simultaneous updates**

Instead of using `RemoteMirror#update_status` and raise an error if
it's already running to prevent the same mirror being updated at the
same time we now use `Gitlab::ExclusiveLease` for that.

When we fail to obtain a lease in 3 tries, 30 seconds apart, we bail
and reschedule. We'll reschedule faster for the protected branches.

If the mirror already ran since it was scheduled, the job will be
skipped.

**Error handling: Remote side**

When an update fails because of a `Gitlab::Git::CommandError`, we
won't track this error in sentry, this could be on the remote side:
for example when branches have diverged.

In this case, we'll try 3 times scheduled 1 or 5 minutes apart.

In between, the mirror is marked as "to_retry", the error would be
visible to the user when they visit the settings page.

After 3 tries we'll mark the mirror as failed and notify the user.

We won't track this error in sentry, as it's not likely we can help
it.

The next event that would trigger a new refresh.

**Error handling: our side**

If an unexpected error occurs, we mark the mirror as failed, but we'd
still retry the job based on the regular sidekiq retries with
backoff. Same as we used to

The error would be reported in sentry, since its likely we need to do
something about it.
</pre>
</div>
</content>
</entry>
<entry>
<title>Revert "Merge branch '4221-board-milestone-should-persist-any-none-properly-ce' into 'master'"</title>
<updated>2019-08-09T09:59:38+00:00</updated>
<author>
<name>Winnie Hellmann</name>
<email>winnie@gitlab.com</email>
</author>
<published>2019-08-09T09:59:38+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=915bc89396f6c8f7a1a82ffc3fce8ba5c0ac4a5f'/>
<id>915bc89396f6c8f7a1a82ffc3fce8ba5c0ac4a5f</id>
<content type='text'>
This reverts merge request !30613
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This reverts merge request !30613
</pre>
</div>
</content>
</entry>
<entry>
<title>Handle reviewer comments on !24690</title>
<updated>2019-08-07T18:49:37+00:00</updated>
<author>
<name>Camil Staps</name>
<email>info@camilstaps.nl</email>
</author>
<published>2019-08-03T10:57:33+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=e726ed5e128893158f102b87e1407ec0a36fc3ce'/>
<id>e726ed5e128893158f102b87e1407ec0a36fc3ce</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Address reviewer comments</title>
<updated>2019-08-07T18:49:17+00:00</updated>
<author>
<name>Camil Staps</name>
<email>info@camilstaps.nl</email>
</author>
<published>2019-02-08T13:09:54+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=73e6ba448db379216f5b703b11295f3751fee16a'/>
<id>73e6ba448db379216f5b703b11295f3751fee16a</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
